From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7A6D1358B for ; Mon, 28 Oct 2024 00:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4B646B007B; Sun, 27 Oct 2024 20:53:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA9F6B0083; Sun, 27 Oct 2024 20:53:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE9116B0085; Sun, 27 Oct 2024 20:53:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B0B1A6B007B for ; Sun, 27 Oct 2024 20:53:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 499AEADFB1 for ; Mon, 28 Oct 2024 00:53:07 +0000 (UTC) X-FDA: 82721187822.25.7E98421 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf13.hostedemail.com (Postfix) with ESMTP id 0368420021 for ; Mon, 28 Oct 2024 00:53:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=A6qICg1J; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730076671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N16Jp8tznM8DulWuoA5xP+0ZyrmcKSQ+sCeRmlWOB5k=; b=DIKsdT/feFf5JG8gWwd/nujWMKW0hA01q1J3/+Vw/dgfp/rDyv0rhLLWH9yebu0kPqnXQW Gy/4KKryQBPeO8BH88/DnPPv6zPlAZTognYfXaMS1bUiYEqiWX90c3VaGD4QAO1SgAbZQj 0IgnPiCUXRcr1MoUaZ+9c2KCiElCwiw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730076671; a=rsa-sha256; cv=none; b=MfGD6H2ztCYTt3pFiXideTI4qgf/0OMFrJppR/fvJDCmYNCWPNoTEfOPzUZOVi4W1HlFMm 2PGlCAeCOmKoi2I0LEj31ao9fh0VntWAJGEAC0caORa6hZuTJ3Yj3hBylCLuC52LWfojNs /PSkmHDXhyEZIHMklz89OBBQD4p6L4U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=A6qICg1J; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7592EA4156D; Mon, 28 Oct 2024 00:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F264EC4CEC3; Mon, 28 Oct 2024 00:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1730076828; bh=CH91t1nwZod1AQvGkBhSnoMv4jweZ+uWR14f+TMhc4o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A6qICg1JiO6ZaQXnyQwSnCwGbR89tbeKSQAgeyxKTkp36a0Rp2VJGUFxWKwo3GRZT RggiAZOBt559LsZyxa3nqc5mgpuaT+w2Och7nILlzQuEurbO22yaJeoVz/jWPbHIKY mRjVHWVYTY4rYC3mWtO1DD8XKtvsLvCtebOO1lsw= Date: Sun, 27 Oct 2024 17:53:47 -0700 From: Andrew Morton To: Wei Yang Cc: vbabka@suse.cz, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, "Liam R . Howlett" , Jann Horn , stable@vger.kernel.org Subject: Re: [PATCH hotfix 6.12 v2] mm/mlock: set the correct prev on failure Message-Id: <20241027175347.af0faeac9fdfc2fc8ae051e9@linux-foundation.org> In-Reply-To: <20241027123321.19511-1-richard.weiyang@gmail.com> References: <20241027123321.19511-1-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0368420021 X-Stat-Signature: xerju15yuub3pdrfti7x3w4jy9qc8oan X-HE-Tag: 1730076805-773621 X-HE-Meta: U2FsdGVkX19lC4jOzMGNtivdJerfue6LvWvstaPTm25HE0rGx15cQqY80cGyRpV4rVL7TXlcInMNEU0NhhrxVC2lqVYl65itcuJEaQF4qkbILf1wWjMTccbf9jQRJ6p4h9WQ2C2LXdOcafr34fZrsFLLxVFIuf302zQrTXOCQLRTc1VkdPsZJ5Wwc0W6sfdB/g/dXKmuGE6kbVWMln51RltGL+l9e1P5/pb1bpRemOJJWmNeIxmYgF62RZ2XLf39p3NrpqiVaEmL4cs07st+jWQwI3DG3qW2SXyeb1Bg/9LlXJyV8twr3at+ZSmg4/+blLbUUzguBvQ1Fgrugxg93mcll9IhNTUykh6eb+N2vQ5osCMITcg2byor35Ww7CNq13vXRbSV0+0e/V0dQDiUdt0hBWc5QBdiwalv7/eS7cUOJdDq8ZpOkKGr0QBewlvxIsgUoGWwCEySK6ZMImMDJKwamxRYDmKSU8CRZBS+kPhKX8HB/OER7ioao4KMKOVSHJhPAh0OBwf3z2mRo+yIw9Qw3aHQQRPHcwHA22GYb7bNgXAW1DfHYaSoM1mFxDo1ouEhHLMLv4Am7eSSwzibxcTdkjzLjp6MCkbwrOz0oJYJKG1XklO5fvRX02cf5Q2SnprmO1DJ5pXQBrH4MOrPYj7L4sOVnX3/ldKliCxaMIsh0c56d5WK3VDcwzrk5/fxYigh+UItm81r5IEPQ8phfkJ1OZYzueJZUx05cxsxYV76JKILrenSA8Ritp7IE7ohEaM1XvJNWUO4U3G47jTYFfNU1ltRgDjQNVxPN4TFTl+E8xbVg3y/rGJ2ceyzrxMs1ADldMBE3A1N200ug4Hb6Bjhc5a5sEHi/hHqBM5aHQVvUD65yPkjuIl3qnJodIHgElq7aUMdYuViAtblX641ExrhH1MNKmP3Gbx9hU/+nUeP2iZRghDal0bifd3znRuNDOz5jx+XsFRBaYZBJEl /okYrh3t Pgv9ShG4UXGRuR4wgQQnvljO1JRHYSSVwsvyptn+jQ11ctXjzqLH5l4SC1VWXw4/P4yBsDJ481kcmcUsBkGy0wQkVKqLoW9NLk6szaEJQ9b5IsbhG094whkqTxAWhsHQdRJNMGpG2/KwF91B2vL7k0UmyZlywiEYCAp943REfxB9KRnmLFEjpnjswwTamSiLHBunRkvoc0i2hw3NUPPYEdEmeI5d7IYT+2bOIYYgeUvvCYlFfqB4fAYzVXkl5nTkdkHKEPNHVhS80qx1goqG49OnanEdE/zEgO1eEZrPFKACFcFgvI1sD+OjYZiUes3LcaMYe08R+2iT3fyTlMfj7epuMnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 27 Oct 2024 12:33:21 +0000 Wei Yang wrote: > After commit 94d7d9233951 ("mm: abstract the vma_merge()/split_vma() > pattern for mprotect() et al."), if vma_modify_flags() return error, the > vma is set to an error code. This will lead to an invalid prev be > returned. > > Generally this shouldn't matter as the caller should treat an error as > indicating state is now invalidated, however unfortunately > apply_mlockall_flags() does not check for errors and assumes that > mlock_fixup() correctly maintains prev even if an error were to occur. And what is the userspace-visible effect when this occurs?