From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0FCD13572 for ; Sun, 27 Oct 2024 17:33:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C2DD6B00AA; Sun, 27 Oct 2024 13:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24B606B00AB; Sun, 27 Oct 2024 13:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5BA6B00AC; Sun, 27 Oct 2024 13:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DEF336B00AA for ; Sun, 27 Oct 2024 13:33:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5256C161C2F for ; Sun, 27 Oct 2024 17:33:19 +0000 (UTC) X-FDA: 82720078896.23.6A3D9D8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 60B6040012 for ; Sun, 27 Oct 2024 17:33:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Z/HgRXEE"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730050369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QYO8XtOnj8lawKKfcxgXMsbeB17K18fEOfvT63qDlCg=; b=e42HEzls+f6lnlgc7ISNA6O7SsW+VlCtDetQ6aexfSdG/SGXo8a1DtAjBzav38Dz80ZYy3 QXrbri50vWfSMvqyDXK2MhoD3/NsP64zpwsX1vFmS1eNiMNlb4TgttSkTFveyiTlEsLnS2 RuC5U0EsLPFRFycVe+UvPSHc4tW3yaE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Z/HgRXEE"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730050369; a=rsa-sha256; cv=none; b=zawhbw0XkXAEQ2ZJRIM7HXTkPABTwxoS0JvxYxb2NugLdLM55BU9lupltBKYnxtyawUYJi cbYaHEspGhUJ7v2uokv87CfE79g/h7cXBGcAAQumtN1Lh1W4oQvJDBHeYiYs9ncgeTe21a PZQOZHJqPDxiRVqGgsRADDCnaavLzUE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 52505A412DF; Sun, 27 Oct 2024 17:31:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A01E0C4CEC3; Sun, 27 Oct 2024 17:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730050420; bh=VWpp83wY/7sIKdkFNIyp1Jg+vorbUuwQIz2kzxgO0PY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z/HgRXEEGU42Ocq71KDo8ZGFxN8sRZUU5qaq8EAw5EFi4NXYpnznHAffdoKsRiBqe Ka2MuxN060J4OFFqoSrzZu97VmkaG0UVK253Ooa832PFa29qgVM82KhxL8i9i4UMKb 3+PZ+TNS13rSGuxJo8teZqqccaJPSJM16Pt8Rtv9OxVBZSorxf+8kw7C+wdmn7o8VL 3LUe4lH3kySNsSm6TyMtjM81ZjVruEI/ozOWACwqbXnX6NklXKXQ99pMVyfRdhf9Qa 7kosHTnwgOEJLdXjXcdGLWdK2mebuLrk2DZNYQOd8GVCGS4CAqdqJhDLInoczcZJao OjcG5O3fnr80Q== From: SeongJae Park To: Shakeel Butt Cc: SeongJae Park , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team , Yu Zhao Subject: Re: [PATCH v2] memcg: workingset: remove folio_memcg_rcu usage Date: Sun, 27 Oct 2024 10:33:38 -0700 Message-Id: <20241027173338.148147-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: yqpijndpwx6rit71n9tqge5h4cdafhec X-Rspamd-Queue-Id: 60B6040012 X-Rspamd-Server: rspam11 X-HE-Tag: 1730050412-489128 X-HE-Meta: U2FsdGVkX1/gpWVcfeZzDPVeY0ia/mD8agkPZbpc4Mncjop2eQ+0GRP81Hqhw3w8x/EsURW26yD+ZMaw1/+6Ku6hupDxDu47UBML0DrfvkXFJp1H2iDtfpVwqIKXsiU4aOZ0iZaIqxuIgSoroSTUky5b7YXTpohV5XGNofTefPfcCn4Ou6QfTQuMW2IXhEldcMhvDOIisDRM6cJx+3awi7pCFs6xI0qL3VELmkmyf6jCgDR66jMtJIbBHdZHdUueCEOlaBw5nZ+a8yZy+6j8I9YJ90gJIjCkLj8wncErANpMFKDsjs3QKA6pdl9ZLKJxFHFyn7PqZGLQ3kuvWnbkuCm1/FZYEeEpQSZi7j9ndpzjf53VR4Nw9roTuNt4A5XpsmNO87Zf40NVXbBLFaOQz9dzwhAfsSsnJM3xqAaWPtZ5GTlHWYT9G4VfSK3Z0q0LKGGqM199MwRBGCEORJSIsTWASCGfQrwrBBWzchTWvsvNq18G7gyEUwkwcfdEJriK2sTERKdxc4cqut5ec3KCA/fFAPLhLCFacF8EqAgdnyJ9avEyI0x0AWQtZzOTCur6+ZKkLlNw7YjDIZtZ24YqzxJf1lgcPcVvLJkuTOmHeQS0G4S2Z9OUaCn2zqfCJ0bIyf22HxKskcsC1Gy5yq4k3AUxJCJlDObQK/E/EGcngu5iQ1br0oQlwz0OgIe9dmeMiI0eukKJxez3sRVFlzS59J2cjltii1w3uU7XgCerGaBCpdgf7SVkwrLpeBz81Dufui6ca8Dg++Bq13vsEdoftca1UNPRHt1rZWf0i/Ew7GJcikfpyceAXK67mV/YzDee0uqibDS+LRM0VKb0qClg0hYUEIQULs7q7PtfCma2nhRpJetUH4oHh2wypvdkBYWcuRMiObMUB5lfae1rokzxfwN40NvXeAEQNeH9IB6jKSO3rjlLNdMiTBmW82+d7+X/K1ohE+xRRvjVR+Ur/eo sMwrH78b Gp+uWj5fHqHZB6VZCbWGfnwqxeAXHQKcblo2PzPwVAV9jTESQfPMLT+Xe3BgF1oD9gZx3aL72/B51WJWKpsuI9AYBG22oW256xuGNz1/A4/y6BLQts5L/Et1NJ6QMHqh3mQmEVliTaU05aH3zTfLjcOeXt1wOag5Is++3J36oAs72+uRgYp3B4eKp9Z9ewvKX3UR+6d7B15yEkH8QkuYmm0tjCeHtRLlKLSwbH4e9QXwrxCabo4aaNm08u22eJ9FxmKUpcN35zNV95E8QKzneJq4vNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 26 Oct 2024 23:55:14 -0700 Shakeel Butt wrote: [...] It seems like folio_memcg_charged() is not defined for CONFIG_MEMCG=n > config option. The following stub should fix the build for such config. > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 89a1e9f10e1b..5502aa8e138e 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1055,6 +1055,11 @@ static inline struct mem_cgroup *folio_memcg(struct folio *folio) > return NULL; > } > > +static inline bool folio_memcg_charged(struct folio *folio) > +{ > + return false; > +} > + > static inline struct mem_cgroup *folio_memcg_check(struct folio *folio) > { > return NULL; Tested-by: SeongJae Park Thanks, SJ