From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283A4D116FB for ; Sun, 27 Oct 2024 12:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E9EC6B0088; Sun, 27 Oct 2024 08:38:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 599A46B0089; Sun, 27 Oct 2024 08:38:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 460896B008A; Sun, 27 Oct 2024 08:38:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27FEF6B0088 for ; Sun, 27 Oct 2024 08:38:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C672C1A1B94 for ; Sun, 27 Oct 2024 12:37:35 +0000 (UTC) X-FDA: 82719334698.28.ED06570 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf10.hostedemail.com (Postfix) with ESMTP id D32F7C000C for ; Sun, 27 Oct 2024 12:38:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HIE+DDs4; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730032484; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CkUpKN4SxLckxVwlRZpNZMxK1Bt8WpjAdAcUZh+I4r4=; b=Iutd4g8U63gQnl6ZKyPng9eexpQ7pPwuO5hga1uhB0CIAzLBtrNb7pmhIH3OU9UVRABbL+ kfULoMPWM8n6Ym0UlO8iQd9F3BlhMBnV+uQI6klCIok5RG3v2SoSERB70xruCiXM1SoesF D1aQIuUne0Y5T8BG2O/q5GT6FI8K3Y4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HIE+DDs4; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730032484; a=rsa-sha256; cv=none; b=yK3I699eqww95lKUcm+SHd6CrwbV7K+VZunKRglmeKPiKvjooKf61IaSUQhDaW91EM79qe rVZVzWQxYuqi4uG34NEhUNIncwzBYaF8xX/J12ncEvI1Idw7evn3tdBxyfusNoXVaKb/2a CImeRpepbLLmscLuPKXcM7bMZQhytQs= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5cb15b84544so4306261a12.2 for ; Sun, 27 Oct 2024 05:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730032691; x=1730637491; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CkUpKN4SxLckxVwlRZpNZMxK1Bt8WpjAdAcUZh+I4r4=; b=HIE+DDs4DNiJ+Afn1L/NbFY1O6niX5XCVPNZaips/BafYuEzd/fn5PTF87z/K7mCPR 5Z0BmD6a2sU0dLnrIuL1ndSo21cEOMBmrx+VUI4A3dKPXWNrH3cTXlEi9CQxwwHVe3Qd 1Fv74wigQ8E+2kwJO0uNCIu2DO9XbTgjAJiB2o1wi9q9HpVwI0QyXPMbTV+JtltYyGAL hKdzcMbsx+dl9MwggbLa5kdfNL7OCMKbIMKINa54kzwWRLQKVbGALvy7SsnOVSKEFwZE VEY3Y46MAC6nkwUdTOTtah7oKMu+/SX/Fyf2qXFyWpMCbA6Boyv41qLGxlgWpAIDxSBr 7+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730032691; x=1730637491; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CkUpKN4SxLckxVwlRZpNZMxK1Bt8WpjAdAcUZh+I4r4=; b=Ys2WQmuBL1fxVj1dGnlOX02yYuLYA6mYQzwm19K6qTtOK43BQ2kaoqqnL8OD2Tc8Ni H1vuSrepGaA0FF3pk58/xqXbeXJaK87FzHs/08MjIDhqckqBJfmXWNTZ4JbiKDG5YmIj ydNGFNHZaPzQPFNObmiv6RaPiDw6g+PhEIC072tS3VyqxdvvfNW0On8Tqn0EB3SNeYTB zv9x9mjXPJ+D7OvWVV8t2V9XwbsI4sqIiSAk/FnOeXkdk2VLc9o5RHlq5OBNjx/N8+kI +782iKs9ZL1wN2pVgQSDwy4Ii0Wep8M2s9b9Bou6b9eYvZwW9Pbp1YY5aho/gWHrLfIe DVOA== X-Forwarded-Encrypted: i=1; AJvYcCXV+vUrxsEx0f5YFEq4+TkU6xK/4Yznb58Sukje6Ck+FaXRcftP8DJBBNRLdzf153+Y324clG7QkA==@kvack.org X-Gm-Message-State: AOJu0YxmiPPck++Wwie3quRw03eHYSU1vEBhBy7+6YoxZO6V0Gcw02cn b1Ejg6m32KI2xFEYw7h7Io0qvDaVB0Ymjn312iRT2giJOZlYsrKQ X-Google-Smtp-Source: AGHT+IGOKX1apQuNNpotfXfbp/Dd5dDZQbMllyf5T/n3APN/ItC3lNU4TG+wPBZkDcL3TEtd2Scevw== X-Received: by 2002:a05:6402:34c1:b0:5c5:ba82:c3b1 with SMTP id 4fb4d7f45d1cf-5cbbf9429a4mr4581160a12.29.1730032690895; Sun, 27 Oct 2024 05:38:10 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb625526csm2473819a12.6.2024.10.27.05.38.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Oct 2024 05:38:10 -0700 (PDT) Date: Sun, 27 Oct 2024 12:38:08 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Liam Howlett , Vlastimil Babka Subject: Re: [PATCH] mm/mlock: set the correct prev on failure Message-ID: <20241027123808.o3vooaayyfvukt6t@master> Reply-To: Wei Yang References: <20241027025629.14715-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D32F7C000C X-Stat-Signature: cra15c59gup6d8o3pxcwdf91usywg5xh X-Rspam-User: X-HE-Tag: 1730032682-464692 X-HE-Meta: U2FsdGVkX1/SvsQsZKoHJrd5QZ+4JbYNrqX+yxKQhGohXoiHfNN9EmmsDA5GSgukOCNCg5Cu4+cEcdby6kLLXFYn8HYC31tmP4pe5eME+dLvt4WwpeRl2CLzI4q374PojWQHSg7EsQQE8ZsPEJe5jWOvVT3cwNuxtFjynkk0ZIt9qOOBwbzIO3AqhqyW5REDxd5zzH7pBuL5yZh0g3UEmaErFSxdSOL49eFbNfmQsjujmXxnmOx9hzn9SWjfx24WTOM+wTZpUQYtlDyFY445MXiviajAO7sE7Bbs40OKTrDXSWyJ6AAPcJIkRbz3SSy6exSoxK/cLpB+2WGN4LTFrIvMUMN72LHHP+cJTVnrYxTh0IVwVDQia+EhP5bzKUq/Ke9vMn7i6HGVfG1Ub6Ie3XLiBvo1r0yEAfJmlW+xbMqwf9/Q0rycCJZWQmnWfX0KCkX80g2+g5/GoRRTfGU1MLxzQ0UeokyX4TBPriun90Fe6zd6nvIgZQqeIUU0qx/3vTpQOKJs/nai2m5mkkBVUT39CQYknlAAzLMlL2gCtbPzqZUgUdjMZT5KzIYbP6oPbdsEMvXYmfAvUPCdDrwYKp1U07VIQ2o+UyezEwUkPqONMMocxnE6EROkK+a2UtVlAogwkTqqFsQQVOpZ5KV7qQaY7AmfZcusKsPS5KMCSoZ5JCuNbT42oTLM1kV3BTFcSfhhKbi+EISe9B51evWUywIp4rlwSSS1Z0eU2ld8jGZFCcSyc2B7R3FRE/pZvGZq3vcIqURxiwP+F8yvdhnjW6DBvZvXtEjPSNqz5ymw6r2z1CqjvPC+49Bc4S13ndZabjAmqh1r9WGBS4PBR025eo4JV8JrySd1/cBuMuW9QKTRIWw6ECOe0byhO19kegvFaB8/aWd/8XEQT7hC7c/pSvn43OV4TXm7I6C/Lx3HZOMJGlSIAwZtKd8wBxwNx0l8yygfj0prRE56r07xZyW 2fdrINy+ ilggo69/CK0zxIqnoXm376idOJbUfJETGYdz/HEkatT2x9ggpS9EgSgHmJJiR7shjnat0a1EftYD7X8RSiG74XztTuq0nVrBZOX0iq0rEZpHJOLkGlCo36/5XXxIK5O4p9aAYYRdvlsAP0UOkt4RBisMMq30RD50yk5eCccFROVIw2v/VD35BCDnW+oXzvxMGOfYSyKlEJi/8zTeXBOiqGv4YXUomc+CKXE+kjj0Z0FXAce1DlToVGhp3fr4QeU57ct566IT3TC7/AdSi+eRljNCZur1YoQf3g6YNjqzu+PKqC4b1bBoTEn8OF+DqNjste1EYsr65vn18uh6fJk7Ola9v36zRxbmbM3PaLHxoHQjfo0FqZCItpGrg9aiWiUvVgb6NzQgLI+rCWDBIhntUlxBIV74xGpWQVJWPw7mp+YMNj7UTd7k4fGTsYiRTmIRxBqicaOC1s7j1j5B3jtjik2b62uF8X+RwNmwAvRJdrHm2b578WbDGW67fNLlxpjEPMRsCVlA4b+xAI1/MfdWzThFBy+Mbl7aOJjiHuZzjcSxz95ZCjBV7NUThcDD8uXkhV/QJFNB5pW2SrWQObT8/Y6eMXqNzWskPrVmHHKv/shJKQ0O28fhvT4QwVqgsaH1Yl7tNh1m0R6/AC+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.100629, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 27, 2024 at 11:41:13AM +0000, Lorenzo Stoakes wrote: [...] >> >> > >I'm happy for you to resubmit like this and take full credit by the way! :) >assuming you agree with this approach. > >This is also reminding me that I need to refactor all this crap, the whole >passing prev around and looping like that is horrible. Also the outer loop >should be maintaining prev, not the inner one. > Looping like for_each_vma()/for_each_vma_range(). Any other stuff? If you would like to name others, I will pay attention later. >This is going on my TODO list! -- Wei Yang Help you, Help me