From: Wei Yang <richard.weiyang@gmail.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Liam Howlett <liam.howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm/mlock: set the correct prev on failure
Date: Sun, 27 Oct 2024 12:38:08 +0000 [thread overview]
Message-ID: <20241027123808.o3vooaayyfvukt6t@master> (raw)
In-Reply-To: <ded7692c-dcce-450a-8c76-ae2138aa6d08@lucifer.local>
On Sun, Oct 27, 2024 at 11:41:13AM +0000, Lorenzo Stoakes wrote:
[...]
>>
>>
>
>I'm happy for you to resubmit like this and take full credit by the way! :)
>assuming you agree with this approach.
>
>This is also reminding me that I need to refactor all this crap, the whole
>passing prev around and looping like that is horrible. Also the outer loop
>should be maintaining prev, not the inner one.
>
Looping like for_each_vma()/for_each_vma_range(). Any other stuff?
If you would like to name others, I will pay attention later.
>This is going on my TODO list!
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2024-10-27 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 2:56 Wei Yang
2024-10-27 11:41 ` Lorenzo Stoakes
2024-10-27 12:15 ` Wei Yang
2024-10-27 12:38 ` Wei Yang [this message]
2024-10-28 15:07 ` Liam R. Howlett
2024-10-29 1:23 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241027123808.o3vooaayyfvukt6t@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox