From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B75D0C604 for ; Sat, 26 Oct 2024 23:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056C66B007B; Sat, 26 Oct 2024 19:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 004E86B0082; Sat, 26 Oct 2024 19:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F516B0085; Sat, 26 Oct 2024 19:12:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C27136B007B for ; Sat, 26 Oct 2024 19:12:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB54E41903 for ; Sat, 26 Oct 2024 23:12:19 +0000 (UTC) X-FDA: 82717303452.03.124C82F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id AFD5F120005 for ; Sat, 26 Oct 2024 23:12:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yk6cmSEL; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729984296; a=rsa-sha256; cv=none; b=QgLMXucuAYBXKVHeYg0V9KLqnjhVaxWMYXu6IX8kT7901pyyL1clJZD3Ln1pYJ/XNIhZyt gLiNr2UJdS6znFuyo1OB1Qq3OhGhKy/gq0MG8KQPv4YRuF74Ovfib6GiqzqPXsrndaX9yz 0o3NNJLCb04SigKHwpBgL4XT3F+Tqss= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yk6cmSEL; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729984296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+LlQsmPVKN5k9OAvvq5WWGhtUnHuVFtG4/O9DljR0PI=; b=zBajYOzbvo51LZVvfkSAzgGTfaO6SUYXfZvoG02uodcIPmewt+iqX7465xLcQmU4KQF6nT lt3JX4dHAbaWImhC4n6LsH7+yCL7gjwrIYKppqjrhi0BZTC4mUziLX/7awHIitRfQRtqGy dzqc+aAUjYjbFHfgikAahQQBMCiE02w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 428AD5C5480; Sat, 26 Oct 2024 23:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E32AC4CEC6; Sat, 26 Oct 2024 23:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729984347; bh=+OlQxkESBOx+ICfUACsJI13rWm9BKFIpOHxESElZsNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yk6cmSEL4+4f/peOBANCoOT0mIjHW2ib7h4rZm2hx4zrImH01M4W9VGnsJYz8793J t72ZsR1w98DVs0lVb+Wxe6nLtPQ1+WSBSxx06cEQO0pf4cI2A/wAqXDvz/GWf5kWQF i6v2KcxYxJDGznnJgN74C4Js7GFZW3YJUWQ7kuyc= Date: Sat, 26 Oct 2024 16:12:26 -0700 From: Andrew Morton To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangweiyang2@huawei.com Subject: Re: [PATCH -next] memcg: factor out mem_cgroup_stat_aggregate() Message-Id: <20241026161226.baba18b5aaa91d806209a9da@linux-foundation.org> In-Reply-To: <20241026093407.310955-1-xiujianfeng@huaweicloud.com> References: <20241026093407.310955-1-xiujianfeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: AFD5F120005 X-Rspamd-Server: rspam01 X-Stat-Signature: 9zcgpqwjdgoaf1rmjcxed8u6jsyrdcfx X-HE-Tag: 1729984320-644412 X-HE-Meta: U2FsdGVkX1/9EKzzA2RpPPZDwM452+SzthELG+6aEII5rGnfMmtpDzvADH44ZcfKmdZh9qzuaNFm/V4niThyY+DnwxwKjmrNvE2cKFA74vNru9mvVHs4wrpXPRsWpULqD2mLOaKY5t/fxCQE9i4cR8foKoJ6wfRYF7OGcS3eQMJiX4WMn1WFtyPhgctTBmopAB+jIEm/R8bmZbJx87ytDlP5I6akj5hyXvUOkzO3aNW14RI2au+LewUvNXBJ8eCFW1lmiMQ+QQXAlqJ1jrqC47HajiGAbfu5Talq2r/jSLbzA8U8BdpTbniVs74SXkj2Pa0nUy0nqoeVhgsjEWXq87adjRpJjIbkStLaYxhr7SII2Xz0Y0fYKd0RsATufPCfG1n2iBeZ5c8cnAo2lr6eMQx2JuxaVcB+Gt4ZaDrgNoaHrmSTy0UbWN5n5/s17EwHskR+rDalgCna/idNCLDHEJM/izyioPIu+LrD42e/dRbjwAgctM2sNyP4c0AlGvbVGYfT+TZ6sSxL/s6JqOPoO/zFF2rZ/YNGB0FODOCNwB9fxF6zlO+gjqcoVsbAzA1HxOVU+xPpcY/MPPTDbZ5NIPHB5GlMFyzTCDyRj/pFSNec6jV+WkTsaEYdnkq24+rJC4Nz9IZ23B1NMi0h8PqwnQDfjtf8JjkVQfrBYCJOvWI34kISkm2h16lXyZDNzsSZcP41/nVxXpierjggwijtux/jy7UFW7+q6FrXrTiWKNsGiWGwbwm0q+x5ieuOSJvAYrGr/JM8w53/iqQdwyl+kW73mLU8XHtKk1GjOA24v5WnYG1LZn/jLtW+sidxvnjEm6+Chs6ZZKJTQb43g3Od9hRNoOfgfDOC7xHQqUd4qEiLg5Hmj6n8anmnleAxuOW/0I6aYgkAG5W2VfvbBrrOdQV18tWcViSN6oixV/OSeGr11sBM9w+zJwGpyfOjXKwaRukXV4hLlc7EpkqTpaO W+P5CcVU DKT85u53OOSbjNKlMbzuI1hBG596XFpWF5aUS7zUv7QtPIiF38u310biSEqXUpFu2yKWwQGURn4E0ybc1t18ztcfggUvJZkuGr2oTf336H7FPkZbb+s0MKZs6R8IA+z1nPftQZTx4L0TP40sRI2a0+bkuTEsX1mNJWipKeoq1OwY1dARueX7B18CzwEfhtZxI89fgNf9mR4Fw1pt00CEmEvdQ0GUGlJ0gBjkaj36Oe8WruJgqcf2bMcCSa7ZyiB5/rNXDlVE9H4xTDKFGk4yTp2uw8mhLpvDIZpJS8cLZ1SoTS2yxGwM5IJxRJDTGTS0IU8uM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 26 Oct 2024 09:34:07 +0000 Xiu Jianfeng wrote: > Currently mem_cgroup_css_rstat_flush() is used to flush the per-CPU > statistics from a specified CPU into the global statistics of the > memcg. It processes three kinds of data in three for loops using exactly > the same method. Therefore, the for loop can be factored out and may > make the code more clean. Thanks, I guess that's better. I'll queue it for testing and shall await input from others who work on this code.