From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8C2D10BE3 for ; Sat, 26 Oct 2024 05:43:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5FD6B0083; Sat, 26 Oct 2024 01:43:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A849F6B0085; Sat, 26 Oct 2024 01:43:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 925136B0088; Sat, 26 Oct 2024 01:43:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 76D9D6B0083 for ; Sat, 26 Oct 2024 01:43:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4C5A121495 for ; Sat, 26 Oct 2024 05:43:05 +0000 (UTC) X-FDA: 82714660140.12.BC4F0C3 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf14.hostedemail.com (Postfix) with ESMTP id D0272100010 for ; Sat, 26 Oct 2024 05:42:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729921246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=/fh1gU6Wn1DnVNCIGW3lJXBoC0dOGky8VU+qUWJ4HsA=; b=6Q+Iv9BNAJ5hC+V9uyfnxkSmzKXOko5Yovn4A4vK2Ps3BCzDjwaiajY4c0ghmxCy7dG+Js XgOleWtaj0FIhUee7sAsd2Ner4eMt9zG6Rp0+s3RNlAYRYHe5kvl3nkB5hU30dqlCBGTnH dRQ4yX2mvD8Qzt87wMt0b1dTENxLviY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729921246; a=rsa-sha256; cv=none; b=bC1A95tQYHHvXZYpZc4qXaivV3x2sWGb5FBIlPg//JioaXGwfidxYNmarwDgbtXagd97JC qmL3j+vVnZDagggoP8K0XOF0B1Na6LNUwKcbkBwLdNLLA9h4EzeEAPousZvy7B3Nc2sdZc CNqwn/zcEBQipM5DyLfn5kd9WXzM/r8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Xb7qH3WlNz1ynKb; Sat, 26 Oct 2024 13:43:23 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id A1D3D1401E9; Sat, 26 Oct 2024 13:43:15 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 26 Oct 2024 13:43:15 +0800 From: Kefeng Wang To: Andrew Morton CC: David Hildenbrand , Matthew Wilcox , Muchun Song , "Huang, Ying" , , Kefeng Wang Subject: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() Date: Sat, 26 Oct 2024 13:43:06 +0800 Message-ID: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D0272100010 X-Stat-Signature: guh9oxn8j1a8fqouaxda6nnfn14nziya X-HE-Tag: 1729921378-521236 X-HE-Meta: U2FsdGVkX192+61GvKPe/Yh8XLk1XHMMRw9tSNGDT+Dmb6yA3ZNpA8SA1IQE6lUPTmZmQbplsujGZT/RPLgiJpUZOe5sJnDPodsMVaZxyKmrZwtlOXqG4UbhgUVnHSPlsWA6SmxfQ7FkYeVRc3lbPWv8cYqZr/q1dHHvDzLIYXVol1Hj6+/D3OSk5rjO7oQr66zuMS+GFDqLOTNRrnWd8WPbUNq3xYyKudxSh8/1SUReVY4BVwX/mvp6YCupToIxizqJunqlcIzbJQT/4muYOPIa6HV7EO94EGQo17fHYBoFwnm66ync7Aos3Xh6Mz5RQFrdD2h227AI52FldaD21h7V0JUgFqbljmHDWUxMWiaQdTytV57lB3dqbUPNgqCwREf2CGtTi9lUz1E/UoOpiddvHvAcDr3UqMpKJGn4DzJr7YMPfLuq3TZxfAjCdph1y3bS6Z91TNMnybWOEuy/5z4Oo+PJTjIo3FKutubI0uUPmhqAUKZozw2U530Z6RDl62G28/GgGjoLVSuamWtj/riayVw/DqvjoVP48Al4Y42Z5WqUgikOeXj+DpKGXrkgKQLQOrR0EOklQOuZeZjXWTgRncgVJj+6BkjwlfUbEhMM6OhAAx6vfNU55phWX8vaAysQUUEUYewA4BpGoBccxKfXoME0N+kn4ogxcvQSS0Mq/gF/mNRPSd7FSndlplpsc+71buIhLoJTfh1NWZ7Cq8PLlRpMdGiQpt97iy8qseAJrBmaS8lrrSGNqCE+kZzNbFd3D+ni+Wqml5MKRvgnYupzkCU++K6dIZwYZOpQhXIIT58oy+/PgsqzNxG2QpROoeoetO6tG/AzxRNY1BQxbxM+vxorhpS9dJ/mNviHh9KT9T9MUjDTa4b0XiSFLRPN0CfKX27r7AJubV6a4zUfYY8qvUMagGJWp4mg1ktsFB5q2aAk61WMFfiv1sBscI8ZmdvfitHhZyv1CYIQN+K QZY+zuJZ GWDuetsxH75MWUOlYXxefHHcoXiTMcr26BSYu6+4QW66viiaUFMvUV3lp4P0SskS6E4jHhRETsddwXiX46i2jW7FDCoW42nPCycI15UMZjpCUjVm+rBLk9uUuIDFmMTBAm+1x6+J4nFiecHFMI7vuMHkrgRdtPGGChSUZUwpR1ccBcPJBXg8NiB8C4jQEpCs6FSs2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When clearing gigantic page, it zeros page from the first page to the last page, if directly passing addr_hint which maybe not the address of the first page of folio, then some archs could flush the wrong cache if it does use the addr_hint as a hint. For non-gigantic page, it calculates the base address inside, even passed the wrong addr_hint, it only has performance impact as the process_huge_page() wants to process target page last to keep its cache lines hot), no functional impact. Let's pass the real accessed address to folio_zero_user() and use the aligned address in clear_gigantic_page() to fix it. Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to folio_zero_user()") Signed-off-by: Kefeng Wang --- v2: - update changelog to clarify the impact, per Andrew fs/hugetlbfs/inode.c | 2 +- mm/memory.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index a4441fb77f7c..a5ea006f403e 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, error = PTR_ERR(folio); goto out; } - folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); + folio_zero_user(folio, addr); __folio_mark_uptodate(folio); error = hugetlb_add_to_page_cache(folio, mapping, index); if (unlikely(error)) { diff --git a/mm/memory.c b/mm/memory.c index 75c2dfd04f72..ef47b7ea5ddd 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6821,6 +6821,7 @@ static void clear_gigantic_page(struct folio *folio, unsigned long addr, int i; might_sleep(); + addr = ALIGN_DOWN(addr, folio_size(folio)); for (i = 0; i < nr_pages; i++) { cond_resched(); clear_user_highpage(folio_page(folio, i), addr + i * PAGE_SIZE); -- 2.27.0