From: James Houghton <jthoughton@google.com>
To: akpm@linux-foundation.org
Cc: lkp@intel.com, jthoughton@google.com, linux-mm@kvack.org,
oe-kbuild-all@lists.linux.dev, yuzhao@google.com
Subject: [linux-next:pending-fixes 301/373] mm/vmscan.c:3498: undefined reference to `pmdp_test_and_clear_young'
Date: Fri, 25 Oct 2024 19:21:06 +0000 [thread overview]
Message-ID: <20241025192106.957236-1-jthoughton@google.com> (raw)
In-Reply-To: <202410252141.djLwbAYF-lkp@intel.com>
Hi Andrew,
The following diff applied to the second patch[1] fixes this error. The
diff is functionally a no-op; the get_pmd_pfn() immediately following
the code here would return -1 in the !pmd_present() case.
I can send a brand new patch if you'd prefer.
[1]: https://lore.kernel.org/linux-mm/20241019012940.3656292-3-jthoughton@google.com/
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 29c098790b01..70604eef0dd3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3486,7 +3486,10 @@ static void walk_pmd_range_locked(pud_t *pud, unsigned long addr, struct vm_area
/* don't round down the first address */
addr = i ? (*first & PMD_MASK) + i * PMD_SIZE : *first;
- if (pmd_present(pmd[i]) && !pmd_trans_huge(pmd[i])) {
+ if (!pmd_present(pmd[i]))
+ goto next;
+
+ if (!pmd_trans_huge(pmd[i])) {
if (!walk->force_scan && should_clear_pmd_young() &&
!mm_has_notifiers(args->mm))
pmdp_test_and_clear_young(vma, addr, pmd + i);
next prev parent reply other threads:[~2024-10-25 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 13:12 kernel test robot
2024-10-25 19:21 ` James Houghton [this message]
2024-10-30 11:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025192106.957236-1-jthoughton@google.com \
--to=jthoughton@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox