From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B46BD149F8 for ; Sat, 26 Oct 2024 00:11:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1013B6B00AB; Fri, 25 Oct 2024 20:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08A786B00AC; Fri, 25 Oct 2024 20:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E46CE6B00B0; Fri, 25 Oct 2024 20:11:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C56226B00AB for ; Fri, 25 Oct 2024 20:11:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 52BF61C6CE6 for ; Sat, 26 Oct 2024 00:11:13 +0000 (UTC) X-FDA: 82713823206.17.C58A712 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D15C040013 for ; Sat, 26 Oct 2024 00:11:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Iq6g6CMG; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729901324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yup96rpVoUNvmwEkEkZfD2cw1B2WNak40seWg9m+sBU=; b=3XlaQLyk+T9o3GHKDj5PPmmK36fLEjXrlIad0n0/i/Msnqw0P+50idar2pScrE1zYG9up9 IOddYBeWjRuXkcIUxHkHwX1F0i+YHtXab/3te5qDN1MEmojDnZdViHBK2Aq45RUzmfGYAW L4HIK50jR9ySD9J6hYLzh5aG5HE7LO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729901324; a=rsa-sha256; cv=none; b=74cBwFNdJ/7adw85PpDrRieOQdUYKsAXvxwbnUVLQy2w5FxcVFOkwy5BM7v7p131oKiHw9 BKS4g3bvJ2MZ8mEUJvc6m1CAlYZu8NyR62uKw7jfk0L9ftuZ9YJOMHnbrFnM9hrB290+SI IJfww/TCU0X3huCI0JKvafMFELKgUjo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Iq6g6CMG; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1DF525C5C49; Sat, 26 Oct 2024 00:10:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE760C4CECD; Sat, 26 Oct 2024 00:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729901492; bh=8bPiJCh5vsLoeLgwY5AooV41PIGxIvoymC+u5FvvIbg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Iq6g6CMG8g/qm3f7tHs9mC3I7vEzro9rr68maumpd/NjylEk8s7S7CS1gMQIvW0M+ 96cVDePeTgt8QGsJrS+kxVaVL5Qp3iGjXtJmuIgYrCh3cuJ4WtTPw5sXilInVamYUY 8rMLgMJR5TiK1tBBXa7D2hRJwIL8jSQpFnAqcMD0= Date: Fri, 25 Oct 2024 17:11:31 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Richard Henderson , Matt Turner , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Chris Zankel , Max Filippov , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, Shuah Khan , Christian Brauner , linux-kselftest@vger.kernel.org, Sidhartha Kumar , Jeff Xu , Christoph Hellwig , linux-api@vger.kernel.org, John Hubbard Subject: Re: [PATCH v3 3/5] mm: madvise: implement lightweight guard page mechanism Message-Id: <20241025171131.9ceabcec32ff4c569d87875f@linux-foundation.org> In-Reply-To: References: <415da1e6c5828d96db3af480d243a7f68ccabf6d.1729699916.git.lorenzo.stoakes@oracle.com> <20241023161205.003ad735d5f6ec50ec2eb054@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D15C040013 X-Stat-Signature: 1hco3f1dm4dyczc13txrryitm1b1becc X-Rspam-User: X-HE-Tag: 1729901468-522007 X-HE-Meta: U2FsdGVkX18S4WDNsBUStNIFcAaSupAA6vrXD3UnZdrkJjA77KKctLFAnkGnHpOPCMDqafLQ04wsTJZ8a7XRFOiU0SFMKrvJPImS1K1GloeD2aE2m/w5td1q+bkYyDaohEVNreSdU8oGFi3F00VPWqVgsn3vi5kUXJLkJgM2c7nZIMKE0SR41fk2yaVLKDENR+exAYuI9nkN4SDMP6r4NtcmLiR6B0vhwhbofidOHNWoYBGdPpZhul39htlge+qu2WcYZfPjyGexgjwx4mYkRz3C6svhvtrYJ8auePGKA+dbVAp+eo0ymqy6TGFN1h4aLSdSzAO9P6dxtZWLqRluCNM04EJ9hlLoqwBsetZlKVABwmKJQmqz1HhQFc4GQL4scWqsBSdP6qQOYbF0718v4/0K3z0UNcZj6UWHjTI55P6DFR5mkn3o99A9ra7nSUp2VH5GKnTYo5beJ8Wta0q/TSbkqfDhLOlnIFEw9yeChvMPWrsCxT/N0KOl0DmttUbGObK7831e5LR5ynFJk9f49yQxQ7eX39YEtk71cb7bpWfpyI1nsya1ByFnakAa7b6KfVu5C2P9XGwjM8O4d4DjziZl/mQtbWbw5mXtL8R+BFOqMrmZ9luDmypLu1EUrh1AAhjrkmViEemCdkn0dlllF+IJPToHIDxmZ2hZMIMASlqgPLYn4K6KSHHO/0CVvzkGUW6rnJL+76uiFowlcFmR6efPV53xBIOQWaNqmLWeVBucebAmoH0LQRb6/nxpFlGtgX4FhN3RYc3U/gZOzYRDQJ+aQO88dCswCPDc5D2IuJd9myNA/6EMEdl4t4wQ8Tj9ujDK8zX+S/Q3D4el1PPA/ui4o/JBhjgVNrAlWlk42nZkOTpPMESVZCLzX1IbcaKr1VHthxh0GEmQK86wWJuJc80OEAscfj0N9Vld8F4umPQSpu6EGgyjEPInnPZoLVY6RSvRRguRFpX0IYu59BF LyFXnNGa uD38WFlVBRb2H+Z26sX8rMqo+OshU5wFmf4TZUeUNQMAl3WfxXvKRWczW57DsSPaxMdQjgIzPfkN58HVI22MjGsw6ftC7wZekZbzzaZPw+lQLftppCiv/lwvkZGl7SOvEHY+isEEmBCd8OtrU8fZkp9SY3rQIoJj2AX0rlfZPPuDvFsMl+ydGCmRZkwbdRaHVD8fa26BYe9aqhNxfOHZUynH9CZoCTImWG6Q4coCc2ZtiS0C8SAo3RVluouq+gYrW8sbyvLjd56VjaqSjLHcOtgTUSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 24 Oct 2024 08:25:46 +0100 Lorenzo Stoakes wrote: > I actually do plan to extend this work to support shmem and file-backed > mappings in the future as a revision to this work. Useful, thanks. I pasted this in. > > > > (generally, it would be nice to include the proposed manpage update at > > this time, so people can review it while the code change is fresh in > > their minds) > > It'd be nice to have the man pages live somewhere within the kernel so we > can do this as part of the patch change as things evolve during review, but > obviously moving things about like that is out of scope for this discussion > :) Yes, that would be good. At present the linkage is so poor that things could get lost. I guess one thing we could do is to include the proposed manpage update within the changelogs. That way it's stored somewhere and gets reviewed alongside the patches themselves. > I do explicitly intend to send a manpage update once this series lands > however. That's late, IMO. Sometimes reviewing manpage updates leads people to ask "hey. what about X" or "hey, that's wrong". Michael Kerrisk was good at finding such holes, back in the day.