From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D759FD149F6 for ; Fri, 25 Oct 2024 22:56:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42A1C6B00BD; Fri, 25 Oct 2024 18:56:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D94E6B00BE; Fri, 25 Oct 2024 18:56:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C85E6B00BF; Fri, 25 Oct 2024 18:56:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0DC9A6B00BD for ; Fri, 25 Oct 2024 18:56:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 65DCE80B59 for ; Fri, 25 Oct 2024 22:56:02 +0000 (UTC) X-FDA: 82713633912.01.7D264FC Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id D681C40010 for ; Fri, 25 Oct 2024 22:56:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AuI5IEfa; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729896772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vBeYNylojodyyxvClBjvaJ6QQQV0+mit1FCbx/jM1aM=; b=eRTyu+AGp0EtvtWIYp/awu+qhyiOHJSniMus/rhnY15RpuIYbpadQXbcywsJ0qeAPOmg5V SZrhQTr6rOvSmduCw/OAn4b/7xJ66RZF2dZK+qTijqKkY78q9NKZ1Qs9SkzYWPkU5lkMCR OEnDLbjtWxNVfjHnPPCsnxSxnT44y8E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AuI5IEfa; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729896772; a=rsa-sha256; cv=none; b=cl+WWyUBwV6LE+Ul8KOu3/UZUkeILUcJF/yRpjfn0RmqxEOrFk2rq2nVFT1yTnH/OUf24s Qw5IRWHKiAjR+GlV+/xFzoUBInfzRxYhq3yMurFutbFzDobBfxC0EEtEuL5P7QtRHSJXYY c+MqKLSZ09A1H9DdSTHlWj59P/ijZxk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 803FEA450A8; Fri, 25 Oct 2024 22:54:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5647BC4CEC3; Fri, 25 Oct 2024 22:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729896976; bh=TSZPTnu+NAlxCCIKdwIu3l0MByRsE75Y5Hz+QbhYlUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AuI5IEfa3PmasVCivFevnaKPNthoRV8hOAxCzai72+RdyBx0s/CJNJvapQyulqqcO RzMZF6R64mo21SBF3i00TVXsVl9I1CMSXaTszwGBwXqYjfUNUkNH/OIITVxyI2nXqW hYv7X1VHDBdJVebuf+NECwq0TRNVqoUmynU65n44= Date: Fri, 25 Oct 2024 15:56:15 -0700 From: Andrew Morton To: Kefeng Wang Cc: David Hildenbrand , Matthew Wilcox , Muchun Song , "Huang, Ying" , Subject: Re: [PATCH resend 1/2] mm: always use base address when clear gigantic page Message-Id: <20241025155615.bd9570fd6147ebd764c858fd@linux-foundation.org> In-Reply-To: <20241025004456.3435808-1-wangkefeng.wang@huawei.com> References: <20241025004456.3435808-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D681C40010 X-Stat-Signature: xfhpjp5sx36ygkikwztxzcgiyeun1jzo X-Rspam-User: X-HE-Tag: 1729896961-123558 X-HE-Meta: U2FsdGVkX18DyaN1ihQjPOstSJFmdrMgq0jhW9EQtSuU/yb0xzmhPwVhJGSrlI80FjueVd3EvQ/qbZSgYe9awcyRmZ2fjqNDLfRLwKpMjyOXQN1IljV8y/nJRoLMZ9YgnDW/DvaXNO+DCQqbnfQvu1Tl2sOkkElk2cZeizhjFhlwdg1uODUa992DT9jNaN+i5O4ZU++ctozpjlp90trzEvu8gxIMV5x6uiN/TDVUb0qNZ/gcziIMag2uJseBmyd0E371ZFErxGHkIqe3LNSNWYJoCuRqQ/dOZbj9bP7Jbe028njt1ompyr9jpP+qzGHLac+ksKjT9ncQT7snWBdnUM9JA2PwIvM13HbYuoji4cUyofz0BSXtPBY4/QtrzV+tL8oLVQZL0JFIKMKFeSjPXEzeZ8PlwmA3gH39ifdJwSxaK5WbulKwL6G/DL9jsCzWJtaPut6PFf3cbHr3+a99haMXpdyEp3PPs+nWeL8sT3aPeqqLJzCoqZ0U9bsTfraoJabnYfNwZ3CgGID9HgLlqJ6Gd8W3frL7D9VvIJnwRq1tFqFiGjXSCTy1AxNtZtL1ypJemQ8GpNRGByan6DOAZTvM0Qdk7J+Qy3TjLD4zmp1KeVyaZd4DQ7Mpf/OhEUrch5+qLESZbmYeXNambS5j1SJDjdgEl8vmMvGTBULVMQWOA120hy3gHJgN3ZRrgW+tgI3RNZ9hnwxIp0cL+vOQSiBfhHohQ1kCkStysK8ZLj+6DRovu71xstnjfpUro8N82L6oexm8jDdCBAVa1ujFld7wWe+A6GFRqILv1JR4nOEhUzxajtcyjNVJInjANKhV0Jl9s7lp1K0AfJG3bd7TutqysukE+2NnlM4yzJ5kdQBQ6zIIFlS9o0DrDt1h6aSC3MbpjVXWyUBzDa3QiCTLh7yLZsFYZ88D4ak3xTtD2t0YeE7n9diImo7Lp868NiD+3J2yLiNsmAcltzR2vOa K/ZJu8ti z56e5s9t3lVPyl2A62PCyWotuc9cH/9gawDYiapz4v3ZMCFopCapK1kNgOOMYIk3KHzPv3rzsoM2o05/3WLexBPcxXh3UJ052Xp2JaYXZFBy985Ra7a6FBA2OywuADlqqKSu6NrwFc7baJn7RBSLlehBSc5pUgFxy1njA4i9Znw9bG6iX5XKd7OfwjtF5dAcr24HOLX0V54A1kOn4qucwA4Yay+SjN5UlcL7plsGK4nHPwYmmgwcI/NVreumRMs+pt1cp+EnHQwh/OIE/wB4/GFu/GUn0EPd0gwv5cZKVmwPwtnEvSFtjiQLV3QiAq8nOVFSMk22K4HEmcQ4tNbMXpRmwB/7HJST6SwNY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 25 Oct 2024 08:44:55 +0800 Kefeng Wang wrote: > When clear gigantic page, it zeros page from the first subpage to > the last subpage, that is, aligned base address is needed in it, > and we don't need to aligned down the address in the caller as the > real address will be passed to process_huge_page(). Matthew just told us that folios con't have subpages (https://lkml.kernel.org/r/ZxsRCyBSO-C27Uzn@casper.infradead.org). Please carefully describe the impact of this change. I think it's "small cleanup and optimization?" Also, I find the changelog rather hard to follow. I think we're adding the alignment operation to the callee and hence removing it from the caller?