From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Muchun Song <muchun.song@linux.dev>,
"Huang, Ying" <ying.huang@intel.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH resend 1/2] mm: always use base address when clear gigantic page
Date: Fri, 25 Oct 2024 15:56:15 -0700 [thread overview]
Message-ID: <20241025155615.bd9570fd6147ebd764c858fd@linux-foundation.org> (raw)
In-Reply-To: <20241025004456.3435808-1-wangkefeng.wang@huawei.com>
On Fri, 25 Oct 2024 08:44:55 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> When clear gigantic page, it zeros page from the first subpage to
> the last subpage, that is, aligned base address is needed in it,
> and we don't need to aligned down the address in the caller as the
> real address will be passed to process_huge_page().
Matthew just told us that folios con't have subpages
(https://lkml.kernel.org/r/ZxsRCyBSO-C27Uzn@casper.infradead.org).
Please carefully describe the impact of this change. I think it's
"small cleanup and optimization?"
Also, I find the changelog rather hard to follow. I think we're adding
the alignment operation to the callee and hence removing it from the
caller?
next prev parent reply other threads:[~2024-10-25 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 0:44 Kefeng Wang
2024-10-25 0:44 ` [PATCH resend 2/2] mm: always use base address when copy " Kefeng Wang
2024-10-25 22:56 ` Andrew Morton [this message]
2024-10-26 1:34 ` [PATCH resend 1/2] mm: always use base address when clear " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025155615.bd9570fd6147ebd764c858fd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox