From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E08ED149F6 for ; Fri, 25 Oct 2024 22:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAAE88D0007; Fri, 25 Oct 2024 18:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E57A38D0001; Fri, 25 Oct 2024 18:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20238D0007; Fri, 25 Oct 2024 18:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B192C8D0001 for ; Fri, 25 Oct 2024 18:45:31 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 617F7141294 for ; Fri, 25 Oct 2024 22:45:10 +0000 (UTC) X-FDA: 82713607074.12.7D4AAFD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id D2B8020016 for ; Fri, 25 Oct 2024 22:45:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="czGX/vG9"; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729896289; a=rsa-sha256; cv=none; b=HAJ/NrOFV/KTi+YuR0SDNRvnzrJmBZ/3t5sinWf+sniolfIPYxMNVnQa1+154/T03Ue3tT 4lofDDJTNU/X9ai9ET2VH29gaB5B6wMiirpRaO61+JFrhlKgvhzxweBsj8D1++yW8w3Tf9 Rgiqy4vj1xWy/436QM4jc9CyFKryM0Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="czGX/vG9"; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729896289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i2KHKYk2unE7IDf3Toyj3sHjJGAp8GTWB6xVZOedarE=; b=kbNM1abZRLNgUGiLH8tonWdQJfV+c6H3bzpiisin695WaDmdLZ73Q0/EXoiqILEInjkdnF S9t6W9QPzSF0kKyLSENJ9fkz5uCE5yK6ilt8/kukngGruTuAFNheTPMfhS7+667IWXfwKh NxGsEa5tD1HdfNMaeUZms4++dJc4bDk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7A1345C54E1; Fri, 25 Oct 2024 22:44:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11D46C4CEC3; Fri, 25 Oct 2024 22:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729896328; bh=4bjvBAHBNnKIvt0MmCHkfl9XQKQ+4C/OYg2iexwWGIw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=czGX/vG9LV1Rv1Hjt9kkVbCUwwpAK/+T5wi0yLxQNjFRLyjJUZuqXGPS00iKuXdPF Ozw/pHZFPoixNMNAoDRI2JMW1K4GZez+ZaEcnZAlmIw3aqFFLeohQhcShGW2ZLcMVU x3fXM3O0ZCBIgTypod37u6+HSjauJ6SgLcsVxD0E= Date: Fri, 25 Oct 2024 15:45:27 -0700 From: Andrew Morton To: Baolin Wang Cc: Matthew Wilcox , hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com, shy828301@gmail.com, dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: shmem: fallback to page size splice if large folio has poisoned subpages Message-Id: <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> In-Reply-To: <01423085-1622-41ed-a882-64291f3e97ab@linux.alibaba.com> References: <01423085-1622-41ed-a882-64291f3e97ab@linux.alibaba.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: y9iaubeuwkzn75e9yryeq3tx5pcnwbyj X-Rspamd-Queue-Id: D2B8020016 X-Rspamd-Server: rspam02 X-HE-Tag: 1729896308-231332 X-HE-Meta: U2FsdGVkX19F3EAiBwqX0f2KRwAki1dbsMthsqBccXNHK7Dg6xOP5FPI4D03KclyM7qvhziC6+NS2MJIPEgV68DvNit21Htxr8DRTUOv4/2PsCKxB1GINpWZ6jfvMGOYwR6eFELRdHlEr1f9/O/hmxbEii8VBrGwbicZ5aOH8Qn5y7htWNutrb/cvwZhtnrpIIqF8hvJlUsOkp+qsQV0c+kYRjwEvEH3qN5fgYXSqZvkOKRw8yIlDvhER+3gzNG5hkRCi0bLy7EVfvAQB96rnHRwrPFpP12FVRzIK21dlR0lEVh/k48NrcR6I5XG4G9WdLnyLyGUYld6Au7pUSKDrJ4g7+hgXxLeUooxd/A5U9mzUgpa7hnH1luA17X1TfaKIRy55KOnG3O6AyTXMSsapqGtTRmoSgB8pExc93m4ibhWXhbOF6Q/qoE5JSjOAV6DqVr/0LuRqqT1Iv8z/OZQsAvWrQlQInEUaGLdebCyAeu+wa0ec2wWuYaUTl2KJqsfprrKSVwKe6SFuG7T+mOQ4AXJ+orEPil/CsWMI5EVuk4+o0uHTxQOi5eOu3HVcpEJ1pxGkrfcZRgL7Xiz4nGCOjy2RMu7idZnj0sQ6xKiN72Xm1m9hw9n9xx+CpoqKOJATToyp+BB6Qg8dxdCGlb9y/VFhdqfw+DBufUNwUoCfwS6rxt6zbyw0ICa5+jS1T7gdu6/b9Pw5jrGO0Mqd6Wb7pu29rZdSrPgbSEOL2zEPtf1v4jQ+wdzW9Crz0uirrq7tg0C+FvrN6T/vk4ogFWyb7r8vAF/Nn2/jSzN5mqpBApAzze1SPMAruVPhv5zZZgJ7Zs/kifPB7XzwNGIowsUjo1urQ97KPmMtfkfDFPPj3X4k+xU0V8+TLtTQLa/mC96RFsERNbv2cCMni8t9j+dHY7FWbQ2zGIGLwLIo8BrQGpbhKUDDRM4OoqxFtoIceVrfQjenD6AAx2DjaIXeiB WKZJCb1t jOV+WDxng1d5k1HKHm5DAhVbTNORdEtLqcbLUwH+CFmPchD19oQimV4UOUXQSQJbnJk0LFtaN8OTBVZfLaWoZUksOnf5n2OXcUpeynuM632u6UpyvirFoVfXQGHDR1d5FKvQpDkF14rZ3Ls/ALnJFcXahpwOno7d4dGdSRkobIaqlFFfYgE3m+qSK633pklmqMHNZloNiVUzAMFkTiuEhKfko5f16TFbV9oHa10V6y1rAANeH+yENDzotSS9fC8nNV/eXleHK0NjTZjo+WoOCzmIjzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 25 Oct 2024 11:41:28 +0800 Baolin Wang wrote: > > > On 2024/10/25 11:31, Matthew Wilcox wrote: > > On Fri, Oct 25, 2024 at 11:26:39AM +0800, Baolin Wang wrote: > >> The tmpfs has already supported the PMD-sized large folios, and splice() > >> can not read any subpages if the large folio has a poisoned subpage, > >> which is not good as we discussed in previous mail[1]. > > > > folios do not have subpages. folios have pages. do not use the term > > "subpage" anywhere. ever. > > OK. This is my previous habit of naming it. Will change 'subpages' to > 'pages' for folios. While at it, please try to avoid depending upon references to previous email discussions. The links may be bad 10 years from now, and it's laborious for readers to trawl through the online discussion archives to extract the information they need. Including the link is fine, and potentially useful. But please also include the relevant information right here in the changelog.