From: Andrew Morton <akpm@linux-foundation.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Matthew Wilcox <willy@infradead.org>,
hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com,
shy828301@gmail.com, dhowells@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: shmem: fallback to page size splice if large folio has poisoned subpages
Date: Fri, 25 Oct 2024 15:45:27 -0700 [thread overview]
Message-ID: <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> (raw)
In-Reply-To: <01423085-1622-41ed-a882-64291f3e97ab@linux.alibaba.com>
On Fri, 25 Oct 2024 11:41:28 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
>
>
> On 2024/10/25 11:31, Matthew Wilcox wrote:
> > On Fri, Oct 25, 2024 at 11:26:39AM +0800, Baolin Wang wrote:
> >> The tmpfs has already supported the PMD-sized large folios, and splice()
> >> can not read any subpages if the large folio has a poisoned subpage,
> >> which is not good as we discussed in previous mail[1].
> >
> > folios do not have subpages. folios have pages. do not use the term
> > "subpage" anywhere. ever.
>
> OK. This is my previous habit of naming it. Will change 'subpages' to
> 'pages' for folios.
While at it, please try to avoid depending upon references to previous
email discussions. The links may be bad 10 years from now, and it's
laborious for readers to trawl through the online discussion archives
to extract the information they need.
Including the link is fine, and potentially useful. But please also
include the relevant information right here in the changelog.
next prev parent reply other threads:[~2024-10-25 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 3:26 Baolin Wang
2024-10-25 3:31 ` Matthew Wilcox
2024-10-25 3:41 ` Baolin Wang
2024-10-25 22:45 ` Andrew Morton [this message]
2024-10-26 4:01 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox