From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49927D0C600 for ; Fri, 25 Oct 2024 11:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63BC6B007B; Fri, 25 Oct 2024 07:41:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C14366B0083; Fri, 25 Oct 2024 07:41:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADCE46B0085; Fri, 25 Oct 2024 07:41:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 90B086B007B for ; Fri, 25 Oct 2024 07:41:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 72EF01208C8 for ; Fri, 25 Oct 2024 11:41:41 +0000 (UTC) X-FDA: 82711934508.09.8F20FC6 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf26.hostedemail.com (Postfix) with ESMTP id C2816140016 for ; Fri, 25 Oct 2024 11:41:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=VUvvfTl3; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729856312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W0DVzmPMFN972kQ5XLuL9QZ110lUVLY1NfnDbsO27vM=; b=SlqaBw13ZwEebE4cINg2bXRSqpR2/T0xZ0F9SftO9a83oI0i7Z33V3DFNFLzJXjHuRlrEs WZKsZ/QenkRx7piGn4hTvJzivVaf1uofpWYDewVHpauvwudFhAAMqYdyI/ksaGPyTK58Gh 7SjItm+y1xX856iKIAQbiFJPyA0VQj0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=VUvvfTl3; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729856312; a=rsa-sha256; cv=none; b=LM5TUFBIOiz9w3X7Tv3uaR7hrk2Pmiw5lirxpKl5ymdRlDMe1SJsaCUlD0o6gKEnPTAMDZ sA8zVcem4Z257hMAd72z5i8iAV7+XQcmD1W1gFqLj4/GHqxlnWlykjJSGeJVwLIhUCCJTI zZzf+WWmFhCm0n04hQYEp3gYEr988d0= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 9CFA640E0169; Fri, 25 Oct 2024 11:41:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7weFIKA90ptE; Fri, 25 Oct 2024 11:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1729856507; bh=W0DVzmPMFN972kQ5XLuL9QZ110lUVLY1NfnDbsO27vM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VUvvfTl36/iLQrTzO5mk38ABMVHvX7D1AlYONVrY9//XOjKpvM3njLYRHkgJaguEB C8WucBdKQreWh75tuPNXus5lOR0V8ou3Zn6xouq5uk42zdLdL2I91MRk1HupN8XYiU Xxw9QIY3r5zG7CJ8N7SXit6dvzKUSk8h0HIOu+bwvgs9odmtLxo1tvJOPG85zUF5Iv yj+bhvNt/OncsG5Ywdxk40l2OoJdOxD5pOMCNz+ix/9o8+bq5wlyMNHUaRcxXKbXh2 JWf3b/tezuCnzTuXJrAb9CQFE4PUT7K9Vpw5+np0qRGW8ysfyUDzyujapMwulKBk1R bANta0GGBwopuR8trRMHKGEohjMN8XTwD1Qaua0FJSU0wRBgTxE6ucnXL1x+RvBOax YRTYE6JWAXnnAegxJxhYc8r6aNVMnykeeaGj92ZeAIEHH/5IE+y+/2CFSvL8a6Py7S UA0GYeYYVOB85aT4YYQV1jJlCF8KbJj+JEBrlcblpiUtpcd0IsIdvrWj5S/FDe9iCa sYPtIH7SluBZpS3+Ej9kpuhMSdP/MtWYaP2rpLEVY1ADKUOCx5+V0W6YBCXAkiFwwU v1wxze11USbY5gLRrt01ii+E0eqIIdvQewW8uoZw+qn2jHIoKdD6VVLUkJiHwK78Mt AshtcaC+ocOAcj8yqhmbTdEE= Received: from zn.tnic (p5de8e8eb.dip0.t-ipconnect.de [93.232.232.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3CDC440E0192; Fri, 25 Oct 2024 11:41:06 +0000 (UTC) Date: Fri, 25 Oct 2024 13:41:00 +0200 From: Borislav Petkov To: Brendan Jackman Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Sean Christopherson , Paolo Bonzini , Alexandre Chartre , Liran Alon , Jan Setje-Eilers , Catalin Marinas , Will Deacon , Mark Rutland , Andrew Morton , Mel Gorman , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Michal Hocko , Khalid Aziz , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Valentin Schneider , Paul Turner , Reiji Watanabe , Junaid Shahid , Ofir Weisse , Yosry Ahmed , Patrick Bellasi , KP Singh , Alexandra Sandulescu , Matteo Rizzo , Jann Horn , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Subject: Re: [PATCH 01/26] mm: asi: Make some utility functions noinstr compatible Message-ID: <20241025113455.GMZxuCX2Tzu8ulwN3o@fat_crate.local> References: <20240712-asi-rfc-24-v1-0-144b319a40d8@google.com> <20240712-asi-rfc-24-v1-1-144b319a40d8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240712-asi-rfc-24-v1-1-144b319a40d8@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C2816140016 X-Stat-Signature: yyq1rb74gzwif4jiowx1zrxi6szh38xk X-Rspam-User: X-HE-Tag: 1729856501-584440 X-HE-Meta: U2FsdGVkX19tE9F8Ro1cdJpyN6XFQ9rXWNY6/orLJTXU3ZbivPyDcoNQhSiXHWItUS7AMjE2chKRLzw7APK8cc1Wo1y6HYlbA/WDKq7sAXJka7ZImVz1WwyanJ+3yp1UNbdhRFVAH8jDe349vbn0Cdh0G5OErUQClOnrQ5vW48GgHiND8Kc4KmGNvOA15K0+zfipAsW5SWQjfsd2HMvGHNXVVRIvGvMAubRGV7NhUzCazCOqwpXBsNHglPyONimdzZRt3q048jh8HaqNXjJ39rCwGvLIhUB+6nxWk37WqEgc2AEzuZ/HzEh1unzGZTF64otHfY6KpvvFkuNbtL4LWNAnogSsAED/CPA8QQCM9vNiN06aNBM+SC3gfGWRNqG/jzAE7wgaFXjvmGEDzzWKamLSxUN5rPTckp12XWwTbOGlcZJcJdu0vr8SuAfJznN2QpOIuKJaHqrCb2qJFi8Zse0y1tCGuvoS5YqLXnHnOk48GzctnVnAc9Bb1wsPv0xUxWW3IgUKelRp3v7rZN2ic8kMgrw1BWiaiZa1X4n2LBvsvFGI7HeJ1/1IVweXNsDQSbSMAfRnJT+He5btlRX+J7Ko2xip9jikYTHaT7/Fl1nLJ3wvHflLe4au6NnyqrxavUVUKFeaJVOzcrPoPEv3OXx7sFF4+enMpwsjBaaLgUr1QDfC3E9/IUH7cKO/p+vYZpEZI0xdGzAzY+nVyDKoIJ9jd6p2Tv2+X4Ubbmhp7q4s/flcLpp7j/xBNjpXuxo+PHFAxJKlz4SNyLYc5vEg8MwydbGY8e6MBKUjg9YPsqrqeAeCpjGir6kTtLhSDT/P0wPVguKHtUkLDL6qYR9tftq0dR0eWyXZFh58QUuasZbqNq/632jhWP87edIzpeUeyRof+RVNPZ7QqrKZ9wlhdrcX5vjDelaVOiqGttUfmnFALfnHT2q0yr2dX0eZjt5Rg0rWUyOPsP3mRDjMdKN QVx4mz7z TwLrvF9Xt/wNv5WSaBoBuhZsoVmgz5ccdTCkC2gVaoPmujrkwYEfd7jp2WiHAN8fhAe6ovs3jPknlHW1H41MmZKW93x93FfnW7Lf6TYpFJZIDi5WaTJV3QW3JNoHWVZfUAmOeo2+uRfH6Xfh67qoKCzGBu1MqSTopcZ6bhBcqAu3B3FmB6ro+ihmjTUQnNuc7iLYfH+4/xQVNwa4ik0F6L9lbarV9lijyj8zA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12, 2024 at 05:00:19PM +0000, Brendan Jackman wrote: > +/* > + * Can be used for functions which themselves are not strictly noinstr, but > + * may be called from noinstr code. > + */ > +#define inline_or_noinstr \ Hmm, this is confusing. So is it noinstr or is it getting inlined? I'd expect you either always inline the small functions - as you do for some aleady - or mark the others noinstr. But not something in between. Why this? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette