From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621C0D0C5EC for ; Fri, 25 Oct 2024 09:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1F9F6B008A; Fri, 25 Oct 2024 05:11:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0476B008C; Fri, 25 Oct 2024 05:11:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8971F6B0092; Fri, 25 Oct 2024 05:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6A8966B008A for ; Fri, 25 Oct 2024 05:11:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADDDCABD3A for ; Fri, 25 Oct 2024 09:10:29 +0000 (UTC) X-FDA: 82711554702.25.03F51ED Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 180FC100006 for ; Fri, 25 Oct 2024 09:10:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EesCWQDN; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729847387; a=rsa-sha256; cv=none; b=TLbJYwL7M25q3YSzZFrs6CK954rwfgBDWC6jQbJejZLrorFje6wEj2SkdJudmslAjhm23N 0g5fdEoxuKFWFmh5szLOrddfVLu0QTEA3Nna6d2St6K2TUx1m6SQ7O7m9wYnwtrzifVMAx EErI/PHZhUP5eXDu/GUff0Jd340HW9s= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EesCWQDN; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729847387; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=msGy2w6JMuz2azl6hoLpq7gT6+IMgXqpWJsnaxh0+/Y=; b=OP6JzI08ThDAYkk/MjDcgLA+K0BYDx4M0MAGDc3agLTGnqKg2mA4Zpo1gPQekCw7O3rFQz fgKXoK89MQvjxR5WnS4O/rsPIBkk79LhsUG4lQZstohyK8BOj88/GmyHKyHuhYl7WyNzkS 6iiux3b+sBXC8JWlaGlu/AfRlR9FWYI= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso238990266b.1 for ; Fri, 25 Oct 2024 02:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729847465; x=1730452265; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=msGy2w6JMuz2azl6hoLpq7gT6+IMgXqpWJsnaxh0+/Y=; b=EesCWQDN9gNq1CgEL2gEf6XCYzr50WmLx5o+X0pdpmy+ewivA+jcOAk1FvMTkwlOpx PoyGIWRMFF55+RX9Rd8Od0lEwAGSeG8t5UckcABiJi7GZtDzqNqQ5fStMESMErijrNNN Lyr9cTXw5Xp2oeJacOBBzvUFDQ/3dqBMxi+OIJ4fG+uxCs/2vWnyKih26TeCdPSx50P/ 32JB9CWESzc8QgVITEex3l8yvBDD4ShclyfbyPpAucEtq2PS1uxCrleAgqYTiTxvH8HX NHrSZGsinQ89N6jFt0qWGbsClfJJkugTSCMEZkL0AYpV3+Qrcg14XgIPdArPWdeiBynS gt4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729847465; x=1730452265; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=msGy2w6JMuz2azl6hoLpq7gT6+IMgXqpWJsnaxh0+/Y=; b=pqBroXkHjCNySCXYvxWMVW5rlFHo6mUSzwwBGDaxDGPBACHxU9x9cksz0Or0FBd0wu pKYQCKjIhpABKjq5zgnnBGfkusxPMMwjhvN+KXmqFGC9X00fVNCiMRJb7fL9aT1nbtyV A0H2nxUdYq84gqRU+wKUdP6F730L1/3XFqZ7rAFTFX/vOGvg5wyCxAs2MKPunmUKdT2r SnYylLx/kgLQnEZoqZyQU2gkMkMCihF8FavWja71zYEh6kWRVVG6inislbf0HFwY8def cYK4EuJmGGQfRMlCKhkGp1wP2jtbm/pdjuhX2R3LqGJVx2SfVRK/vZVbkhdCs49neozp QNMA== X-Forwarded-Encrypted: i=1; AJvYcCWIE0a1wt6Eqle33bxplwSdVrxdlgKV7Xgx/96dS3EHzOB2sGywjJn92LgTV34YXibP64zqOkgi6Q==@kvack.org X-Gm-Message-State: AOJu0Yz04Hm69AaCccC0nfdUKz0jk9KV6XAGmJ7xX1VMgXmbHzZFCbLz FxXu7mFFS24Mt0uYGTQPvhcT7P31aM5fWiX73C8iun743CjBxEMr X-Google-Smtp-Source: AGHT+IEebWOBG+wr8jQgdSgSrHCsVmKWexnHZsJlm4nfmVtXGhMKtgICbHYDQGjnRkcZyVD/IOalfg== X-Received: by 2002:a17:906:da8e:b0:a9a:1e4d:856d with SMTP id a640c23a62f3a-a9ad273096bmr477683866b.22.1729847462988; Fri, 25 Oct 2024 02:11:02 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f0298aesm46621066b.66.2024.10.25.02.11.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2024 02:11:02 -0700 (PDT) Date: Fri, 25 Oct 2024 09:11:01 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <20241025091101.eizclmjq7rakfoky@master> Reply-To: Wei Yang References: <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> <20241025084919.m7etchfw4riavxmj@master> <20241025085409.hpoi46cazmkogbfg@master> <87ab8c21-2dd5-438d-916a-2fd9c48679e1@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ab8c21-2dd5-438d-916a-2fd9c48679e1@lucifer.local> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: wg483ub7eu81akfbogfkecskfajfwwe1 X-Rspamd-Queue-Id: 180FC100006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729847428-734070 X-HE-Meta: U2FsdGVkX18ASPFh6WHOE3yOeaomVkQ6VAU+sXBGsxF8YnPCgB9Jz8jW0+SWVTTm3apUg48Jsg6uoaHigTioKVEajAaigNq4lFlVpDwcZqzCyFCXHSnMik8lNeTp/xLIw8SKcdEJabhcW7s/IezTBh2VxUUDp20Ozx84K8YsOj4C9TtKNj3mErjGYczFfe5VRwBoOFWg+qPB//w+kViLtfIAwLen7x4NV+Jsc5wFEA6ajeLN7u9nftrQBASzsaLItTqwNBI1Kgt6XiPtQAc9X/1w8jqapJwQq7C41O2JJB9YKUvVfKn1IUq2m6jJyU8xycIeeUJs8afoe0y1X6payPG5AyU0mEEVDAMkorvZNcVQOEgtILjkjFrv/fWcLzygICl41glMT9puiBCL2kFbmPgullvNWGtrkNI/9GbqaMvUkuz7s0u4FhFUI9hKZPz0h8SvNeJRnACbY4CALoP99FBfS7KfeYVNzrXdEXO+D5S9vuLSy0jiH0io0hrLDPbgGzBQC7bwXIHbtKSJ+BB6B+zdHCWKbZ2AFWNypzWznGlS9dzdvfs35q74zgq9dAfgBTYrZ/O1Lf8kXntzN7nGndV9EKtUiNNK6H0bKf4HX5trVZ3j7ylid7M1QXaI8mp+CqAy4L2JaXn9U6p4h2wD2BDzm4PGr29Mf0ESVETYqWb8mJ603WJw3pJZwkpzjcbmkKlvkUxHyAvgv9da5fADXyvwcsKrOMRECUvz6jaTluiSGqx3BcKDJtdXwhCUZVjc9Gm8RDqfmlqD1TeBk2NkVfDcXVGa6PHdG0sFIUXKMmNl6tclXveDVlIolxMZGTMC6KXFRs3BO2vaYD7KHnem0QBGHbDNN+VZ2hEOJSj51qsxgaZHBsI7uuh9VSXe05UdcD4zXslzkBLjM8RmC1m2kXT8GhUlngEu8urTsCciS4KPmZW+z6zdJbe0AMwlALi31Yxfes7cV52xjHfc+bj Y1Plny+u 6iZlhxxKKpX2fe08eiLENsBW5ihjEXeaKT0H/5RuDoTDzLlv8h6P5cuK5qIa87aVvLd9oAI3Y7aplGT2o9a/m0VZVKheZc73c3g9UiWUJglHXlD0pd8KKFspMjlO3enuceVPmthlWgEJh4zs6fYT9+y0HPZ43/CUxHB/A8NPoRAiYDgyOjq2x7nTEAvCQGwdwK7dDlsfPnn9Tctk2TCaM2ZRyBQdHnyxsPYIKnXpzekl5SU3KeTLUo1R4QaxwdmYFeJq4/ncAAqz4wFbUK6bX+Ea07u1Za2QgqMR/UfjyUPEDxlYVkAD3WSs2/QbLLBT8e8kFZoXhcHhfVFh/IRPTjCc8HzXdiyLhsWEIV2oaZa1Z54BHTO1ezEj1YtiLJjcgTjdQ7FnkK2Ev45mSPVWdF9qa9ojsrGTdbZQdlNPFT1eH+YE7wKyWguJQyYRpg2H6y8nLYa+G/Uy6cxoVums4/FyvGNkYuBReCOSiop+uOSVFTy+5dRqjogRft+rVDYW5wyYMm4wiQrPsLYohUZ+3Mos9AadY1L7u0+IKswhWu2hxUluHywjO2ODoms5eTM9R9+1uy9JZPHgOTrRt6AugxCCd6dwOjjSdVVJJ8neAFom+1J9QnVrQ+ED9Og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 10:01:36AM +0100, Lorenzo Stoakes wrote: >On Fri, Oct 25, 2024 at 08:54:09AM +0000, Wei Yang wrote: >> On Fri, Oct 25, 2024 at 09:51:12AM +0100, Lorenzo Stoakes wrote: >> >On Fri, Oct 25, 2024 at 08:49:19AM +0000, Wei Yang wrote: >> >> On Fri, Oct 25, 2024 at 09:40:25AM +0100, Lorenzo Stoakes wrote: >> >> >On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: >> >> > >> >> >> >> >> >> But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. >> >> >> >> >> >> Lets say just_expand is true and can_merge_left is true. Now we will adjust >> >> >> vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't >> >> >> restore vmg->vma/start/pgoff, since just_expand is true. >> >> >> >> >> >> Is this what you expect? >> >> > >> >> >Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't >> >> >realise :) >> >> > >> >> >Actually at this point, I don't think we need a follow up patch, sorry. >> >> > >> >> >As I think perhaps I will make this change as part of an existing series >> >> >where I am reworking mmap_region(), since this is the only place where it >> >> >matters, and it would make everything a hell of a lot clearer. >> >> > >> >> >Thanks for pointing this out, it's very useful (and an embarrassing >> >> >oversight on my part...!), but I think it'd be better reworked this way. >> >> > >> >> >Thanks! >> >> >> >> Ok, for now I would just remove these two lines with the change log you >> >> suggested. >> > >> >NO! Sorry I've not been clear - don't send any series. >> > >> >I am going to make a change that eliminates the need for your change (sorry, but >> >in discussing this I've realised that's the best way forward). >> > >> >> Sure, go ahead. > >Thanks, apologies I know it sucks, to be clear I very much appreciate your >input here! > Ha, np. Glad to talk with you. >For more detail - we are refactoring how the '2nd attempt' at a merge >works, also avoiding any abuse of vmg-> fields to keep track of start/end >of a range, so it becomes better to just open-code 'reset' of these fields >precisely at the point we need them. > I am not sure we mention the same thing. One confusion during code reading is on the vmg->start/end and vmg->vmi->mas->index/last. For many times I lost who is who... >Do please let us know if you notice any other silly mistakes like this :>) > Let me clear my glasses :-) >Thanks, Lorenzo > >> >> >> >> >> -- >> >> Wei Yang >> >> Help you, Help me >> >> >> >> -- >> Wei Yang >> Help you, Help me >> -- Wei Yang Help you, Help me