From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4213FD0C5E6 for ; Fri, 25 Oct 2024 08:54:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B95FD6B0088; Fri, 25 Oct 2024 04:54:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1E346B008C; Fri, 25 Oct 2024 04:54:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE976B0092; Fri, 25 Oct 2024 04:54:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B49B6B0088 for ; Fri, 25 Oct 2024 04:54:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AFF23ABFB0 for ; Fri, 25 Oct 2024 08:53:36 +0000 (UTC) X-FDA: 82711512492.04.39A88ED Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf30.hostedemail.com (Postfix) with ESMTP id 367B98000E for ; Fri, 25 Oct 2024 08:53:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FF5w2XzP; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729846300; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQ0zS5GOTo/sQgcGr5N1XWp0sNVj2dbYYBooIF+lUfA=; b=TlqtvtAPxGIU+S04CU4t+iB1iisI9Cy9AMC/U9JbmudgvhQTWfVvqkgEFhgY11k3B7FmCP 2MppZI2k9hNlFoHuTfKq7HZjINiarmHZK55OA0Xyyu/iYdpQsA0JiW+UJhYxcpSwwAEMgj z718Sv+fkj4vU15oSJQN7nNPiP4JDS8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729846300; a=rsa-sha256; cv=none; b=RytzTAmgqBETm3qs0bbSaUCGOOYPTLBFoY8BeYHYaWIrAVA+MfXOUbExa1HctYe1+20uos XBs8XKPDSZ7LPajE2fji9W6/y9POkctE7LwIXqiOhh8Ma307FHbRVJjJ9IdOmT45OZt8rZ zfIe0Dbgh7paM2eyz203MC5U6rXkI/Y= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FF5w2XzP; spf=pass (imf30.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5c9850ae22eso2385539a12.3 for ; Fri, 25 Oct 2024 01:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729846451; x=1730451251; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XQ0zS5GOTo/sQgcGr5N1XWp0sNVj2dbYYBooIF+lUfA=; b=FF5w2XzPxPJaT5vNc8a1mx85rnD50rqV1zBOqGJMSNMclmGVp6cEmPJlqdkNDpJqeF GEI/UucRtag+bcWxyWhNtFnO3C34I8v1Uih/bm2uQMwWRcCUeIVNXYA2wzl6Bk1XmWjO 7O05FYykLLjdvQTF6tzU2CP5UEfVt1O7lEdtsP4LuHua4ZJAsic4iaRaY6IrYrds0jA+ VoYivo7fYEievMfm5vOQE+LkAuQrukXjsaWH1xc0zbcBIyipmbXiamy8RVvlDikmYguA DnjN6RaMyo0eJYLBeGaZuoawlAkPmk3O3Cf8tQWiuCRoLsgWneQNNROM6iAPGDYu9zMT aKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729846451; x=1730451251; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XQ0zS5GOTo/sQgcGr5N1XWp0sNVj2dbYYBooIF+lUfA=; b=HmVqTUg/D9WsyjbSoowWrMEsR+C1oCeR3X26yWSFVi+8wKU42Fbt0iAitVr0h7O0ci sjrkZMN+hUKjwxnEmGe+6zj8qR4QVQXLpYHwmT6wtdxW7lrXJoWYwjpGrqllEnGjE1Tw krmO+FVWC7hxlzT+L3lR7EpUQhl35eQU1QNi1HKGegzze/Nh77bdurZfZJXdiAQVCKl2 52l/TWFS7/0fZ0AWY4gyliwntgBHWKYhpsrJeYAfw4WFJQVWNIRemYIKwi1lDOxzUpt0 F07tMJ9polCc+Fr9PEiZ3qTqaWavYp0E7akIQ5Pk/F3OnYrDsa/v9ZoPKFfelFdc700X Pa1w== X-Forwarded-Encrypted: i=1; AJvYcCWa/QI9DU6NzKksGbnY9j66WoFSd72jTLW9yfPrar36JLoHcc6qPCy+PxMVqKi/CFll2LVuSahXNw==@kvack.org X-Gm-Message-State: AOJu0Yyt5OqjAAW3AyV1wjGLMobl2YRvHtXjqRRYxive9/GixQswwygx 5Wtw2VPKHi4cZLw1GaVYZ+SNiZXS/GZHSYyFbt3BGsnmMuaQ34Q/ X-Google-Smtp-Source: AGHT+IFGLhEaMbjC34KMCHM9ZSdfYEYyuRyT96GgCxULsweu9pkKYy9PshpLxo7zVg9gude5qm53LA== X-Received: by 2002:a17:907:97d6:b0:a9a:2a56:91f with SMTP id a640c23a62f3a-a9ad2715a29mr386092966b.2.1729846450933; Fri, 25 Oct 2024 01:54:10 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f029874sm45465566b.79.2024.10.25.01.54.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2024 01:54:10 -0700 (PDT) Date: Fri, 25 Oct 2024 08:54:09 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <20241025085409.hpoi46cazmkogbfg@master> Reply-To: Wei Yang References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> <20241025084919.m7etchfw4riavxmj@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 367B98000E X-Stat-Signature: ggmnf8mcnsn9cyrpxa3k8txyemteqqct X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729846415-936421 X-HE-Meta: U2FsdGVkX19LFMiMnpIkW3C2tHhkdUqxayO0yf58hx+sf6q7ky2w2njWIWkeJUwRLDZ6v6bkhKXbyJDl3d4SY81+sgXFr3VpaGFGKyJma9ZgC2wogAabK8Ut9yujpCrsAeFbtQadl5uNXw/Nxxu1u9fBegrNqtt2laTvQf2yXDOqOlmhiqOpUoIVT3+irLDFqqeuD1cT3fbA4mv7vRI0WvnO+aTgQnQltSbprEWcRKl+ITq2d8clG56Pn1T34diiKDudPg6hGILxtZBGyGPPYoOfdEQgwkEK11MLYoubImh5vEXCqQUPWQnag11sc8w6i/w7mat/TndDylCYi2tMWMtNzXATdwZ4X1ayl+GmTEbjPMNi1YPtKxxintKF7WfYDQs4vvkTcr0j3GtLBzQd/Bq2tvDU98dJQt3633Wu+jphThT30je/iH2UfCKuy88W/gkIkU8NMS5L5BSCd8T5kkAvGgsmyyAHIZK2Wz1nNy9CeiCldiLydyDfodPA1l7S/WzsFDKz06xnYxK9wcv+1e4yYp3u/cWAdtz0rrQISnE95iWb3sgKvhJoUkCtvED+xjL5f0q6uerJZzkbDYdtK9mzik13hCNiWS/1zXOHvMfgc/rXdCZinwlu6GNE0RZUhJpGWnd2jUmGRb5Oi5SpXVyoe5O0ojkGj8NxhIlFiyPt3rv99WlfSoSUGwQFe3UPS29VUEUdZO3+EQ4/lRxVobLOOmBvpq/tJ6suWfcuSnBL5hgycwzexsYCpnrMsXOXNobEI0MDsfNA5gVhNe7PlAzMZw+bFa8zY763ofTxgFaKCFwqG9i8idpx1anXX/F2wVMjwf1InMzNxsS0TchsZtYpepgA2rHPgl55kJhny1nrv8eiN4usClMMZbi5OtxAP1p9V7aiEpJseq0NuNIlaOcp1T1H9y2dvui63Xa0xENM9fjt90g2mKYMJfXR1PvU74BwRrjX09AJQDLxm+F DXHkDQ9O BFUfMmnVZBvXzTcjUO3ThRmg980Qo+MYvT2DSWpiXx9QWVkVFwPJH0l9OlxsNeIMSMqwXsXuySdIDGLaXk39zrlMQIWGqLTvrRX1TBBrz2jAzGREMSB0tWAaOB8IsGrylDQ+u7izEhbXeefBIO6nr1AaeFXBfQgvkkTCZJEevplN3kKaDZfQDe6zCPVWJhTfzgjzoMnVUbL4+EGaoPwBOA3VqKyopKLgkSJKi+IGZEY3QXfk7oejiOQSGYFnJRJ6eoKXkRpJzwEW1326TPlHQmRVMcx83WxNslzEGjXkvks6ZpvwONj5HJf+Y+4CesWLWT+9e1PUvXzlrsrqFII7a6ZWV09OXSIU18U7hGCnjoWGtRodNJx5rHUMJM8Jptw/zuJaMXcPnBgZdpM8/vgYAICT9vCuHn+pR5LOFGg5UhjapIihnTVvMqcd9f33cvZrDpaC/ZHtvCQ6BQP4R6GDXZZ3IGYxaJWTxXt00FpIJGWTqpG6Z11ZfgtwL93HNB/deVYdBmz1b+Y5/hXmQz3PmiBW6MnQA90ClkRMQ/XS8zQa2avnTD6tDMX5lcvuZebkMYVaiblAVin+XosJQ1g+Ii4rk6DU8V2ODSnOsdbdajaUVodTS5li6OZyjww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 09:51:12AM +0100, Lorenzo Stoakes wrote: >On Fri, Oct 25, 2024 at 08:49:19AM +0000, Wei Yang wrote: >> On Fri, Oct 25, 2024 at 09:40:25AM +0100, Lorenzo Stoakes wrote: >> >On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: >> > >> >> >> >> But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. >> >> >> >> Lets say just_expand is true and can_merge_left is true. Now we will adjust >> >> vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't >> >> restore vmg->vma/start/pgoff, since just_expand is true. >> >> >> >> Is this what you expect? >> > >> >Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't >> >realise :) >> > >> >Actually at this point, I don't think we need a follow up patch, sorry. >> > >> >As I think perhaps I will make this change as part of an existing series >> >where I am reworking mmap_region(), since this is the only place where it >> >matters, and it would make everything a hell of a lot clearer. >> > >> >Thanks for pointing this out, it's very useful (and an embarrassing >> >oversight on my part...!), but I think it'd be better reworked this way. >> > >> >Thanks! >> >> Ok, for now I would just remove these two lines with the change log you >> suggested. > >NO! Sorry I've not been clear - don't send any series. > >I am going to make a change that eliminates the need for your change (sorry, but >in discussing this I've realised that's the best way forward). > Sure, go ahead. >> >> -- >> Wei Yang >> Help you, Help me >> -- Wei Yang Help you, Help me