From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DAAD0C5E6 for ; Fri, 25 Oct 2024 08:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 882DA6B0085; Fri, 25 Oct 2024 04:49:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8332A6B0088; Fri, 25 Oct 2024 04:49:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FA836B008A; Fri, 25 Oct 2024 04:49:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50C176B0085 for ; Fri, 25 Oct 2024 04:49:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0362780506 for ; Fri, 25 Oct 2024 08:49:06 +0000 (UTC) X-FDA: 82711500060.30.C46A64A Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf24.hostedemail.com (Postfix) with ESMTP id CD612180017 for ; Fri, 25 Oct 2024 08:49:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hVlyXWhb; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729846007; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdnTLBFO6V1lSocyCiYKWRYE4Pxfc8WbCU97p6led7I=; b=jsFbOAIUKgkxMDKXtVwvqgDL5dcDpx+l3GeH96KzsnOFrdU9S1L4B9hWp7j/84wf6ptpJy vg/nJdYYBMjl4BIKwLpvL0POqGrNbYbyQGIve4qyFYCP5bXLoDRVIFg3PMxlV/vXBojqMH oNpLYkOAD8rUjdHH4j8qx3KRNtm1suA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729846007; a=rsa-sha256; cv=none; b=FOpeLNQC7YJyXYfVltIxkppwCQHbKigLcqgaKITGnbxabi/4ObBs4awgplLOxVA3bjxq7+ xnsDPB0AnEs3gQRO1GJIimmKg8ugFHndbcDJtmPVQvFuE2hr6IV0t2BUu/OqqB+Jl70JU9 Y+4kghh/LeIaHToOgX7p4gZp+rK9c8E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hVlyXWhb; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c9404c0d50so1966068a12.3 for ; Fri, 25 Oct 2024 01:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729846160; x=1730450960; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BdnTLBFO6V1lSocyCiYKWRYE4Pxfc8WbCU97p6led7I=; b=hVlyXWhbQh6bW/y1abP7jWPOLwaNajWQfJsqXsqh7PoDxO6JjR2VkeENEVgcWhs7Hb l78HMxFatzo++ABLIc19k50/F+Nkth+FeQZckGVPdgrAQ6AyLAVCI9e+rMzO4QYtG5nR XFsbyMn8fpcOdWilPE6BYtWSsR9b2IrrK9bnX4+6e/BaA4Ts+popb0YmykFOBTW7+RgG h9TV/RDX8/TtI1YLXe2iReHFWswEyQUuQHqOAm3ZPHmlYL60GgYlQd4Ru4qDaliYxfZj Yhtl1Jjp0wx+1JU1Wq8TByDgIHh8fqEq5H9BgN2qmAShIViFTpWeSj+UzBwjIU8W4zO6 0Okg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729846160; x=1730450960; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BdnTLBFO6V1lSocyCiYKWRYE4Pxfc8WbCU97p6led7I=; b=vZSrLzKpwdrGXbDmMrE0xHCtp5xFHXIFJERyaQLlWA0ih9pqiA+Ti/8MNouvLnueqi Apew+bxVANrMTf0MiAWr+i0kS6ZOrTaTh4h9XQf/cu62myTSk2gzDYRW6JlgaNDWWvHD 8az3EQVtjejb8hp+6IVPo7HNjdVB+1CLfyUbu0zFlDgvfGyQpNMIjh5HwIw/o90mYoiY bscBtU6tvPzJDsvRmnFwWli3MGiM13X6+CZNAFKnXG2kfV5AzR+2gmHdsT4IXEA3XugG S71e47b5XNNFgBq7HUgppqMqrNrkp3urAJzcKqUqRKsmCVqMEEHiOQUjoZEal+F8LqqU DGBg== X-Forwarded-Encrypted: i=1; AJvYcCXme/+RYOC7Mk7OFxs1znAiAya9CZaYBaeNxQz6G6/TMSk14QDP2wgAEL754zPaYKZXHUcEZE01OA==@kvack.org X-Gm-Message-State: AOJu0YwnDuJxEUF7sWs+Iocn0G7N5JVYBrju4Y4WudzJeSTNGLbIzhJc pHUm3FaV45jA9x/7AQzBHdc6OgInT5AGeHKWnaYOVrBidiHqeWsb X-Google-Smtp-Source: AGHT+IEenYq42r/uIOJ7NStT78ZkC7dTcr0NeqS6x0jPFly3hLkDWfqFpAPaYX1uWtFq9W+nxg5UWg== X-Received: by 2002:a17:907:94c3:b0:a99:92d3:7171 with SMTP id a640c23a62f3a-a9ad2870d95mr403599166b.61.1729846160061; Fri, 25 Oct 2024 01:49:20 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f037045sm44740366b.86.2024.10.25.01.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2024 01:49:19 -0700 (PDT) Date: Fri, 25 Oct 2024 08:49:19 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <20241025084919.m7etchfw4riavxmj@master> Reply-To: Wei Yang References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD612180017 X-Stat-Signature: 5x1zgxznabkggmbazisd6pi7x46ijff5 X-HE-Tag: 1729846158-670119 X-HE-Meta: U2FsdGVkX1+nlP2jj2Wqlq4BXD3gl//JlEPjwcsn3tr2R1jNuhkVehjCJfBtFTttyDSLjnbVgmK1phUkf6TXquFpimJD4tKfGe5cfADRTY6+7IDXWdrm6wBiSGszkB+M8y82B7dwEOKNvBayNaQNOuExiWOnHBLnXjqBcQlszIqt/OMSbyQZ90iSeplFPPAEEwjwC7ahQN4VVBBnInYXOLPLJyiO8vTWL+7jEjOGocK+L1y9d6iqJyLB1OPH6N8kbJEKQCbpKLCoLTXc2LqW1KK1YQ3NTOpLRN5kNtwYveo2Y6kOr35/Q7YCCgixWs2MHo5InNEYsWT61pUVRDSJ0YsJHN701wNEfs8SVEdg3ZntJKb7uWVgnS3dBAve2ihsgqNq47WMOFU5KmpwAVfSoZmNdS9+ICZi2ogQisYaaGe64pEMtE7oRnn3rG96yMj8d1zkXkAqyuzIzlpq+TBNQbaonNtRpmzIdixcuhEm2P6DlK5/ge0JTSIspxE8zpiiqH+gualiRU8QrImJqmrFEXgTXfhV1akSgWiyDr2r88oxPH8shp/puwJYXqi/UH0tSKMQOOP7DfwQ9nG+pBeJp0uPzJ3FrlMXRDzydy/4GyNluzq0jpfNqK1APROa+wLnfM3nZRtiMwcjpafAtiOmJsWC7Qj0EvcXMLIFJ56Q7SWENnbWaldr8t1zUxLn424dsSZscwoYtCXO5spVdgTsx4n5gPgKitD4fbAL413Ay37S68IOI0un1lSUZ/MFEeM/HPsR3qyfYYwYEU0wo+pMwf0vEPi5a3rVQOD5o+Y6LgBmUh6zwVAf36s+WDnF8C3ZSjlHOdxX73aW1X5e0nHJXu3y7QpNsDPaIozDlMqb9qcIiO650wBxlqQbLEQ+WMC9dh03bbN27sp81j+P2hCNUzxdQdtSR3iVwRCj58l1JbhSVNfSGl+M0fBjxnrT4BeK9WD1gdXZInrukj8TQMf S0soY9oI a86bu7gqRp48Z8Cl5CO5YrPtttaYaYbWE+aI4xP9/8GzFDT6i+56xI15QTHQKVlXvro7b7lJYNb0fDKz/eZCaQOwyBOB9TztqwIW6AdWDzQ7USQ3kQY8Hqj/ztX4jK4hBqHB5QzhinybCYhoqzJRwKazOQgOaApc2r6TSJ/XI7dvnrM7XBjVrMvdizOWtZTyhZBa7WsdN4AGb9tP+cb1/PMj2DWrbcLEgvpAXoF49WkOqf2qwcqZ5oLH4z8x9/BTmwYEuLWKE7EuJ3S30srYx4TYve/+2L64jz+3wd415r1p0zrJbrFcIfLzmZVGgv+lUUdt+f8+q+yVkdiFhffcoBhyMcjNn36Au6Gzia9qqpVyvgMwx9nDmHzQwB/NkdEyXxLDvjom6wQzyVzbsw1kqoirwEPnYev780EJO+wFr0OtqY1ATNdqbgz4eDu7/5DKIroSB4NnW6mh0CVtR1yEPjeOm97SPC7y6fT9ErSYHRGxN0jHZLeFraiuOxJQW7mYRdcQTPfOw+FyH3oMTCCvJNqnPhDb3KNo3Wwf/roD7mZkhkZk/JRHJGJarQofmm77FsBoJ5RtsZvwROxT7Ft8xUI+ar7e1amELSq/DerG3ZBp+oR+iNR/fO4mz5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.011958, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 09:40:25AM +0100, Lorenzo Stoakes wrote: >On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: > >> >> But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. >> >> Lets say just_expand is true and can_merge_left is true. Now we will adjust >> vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't >> restore vmg->vma/start/pgoff, since just_expand is true. >> >> Is this what you expect? > >Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't >realise :) > >Actually at this point, I don't think we need a follow up patch, sorry. > >As I think perhaps I will make this change as part of an existing series >where I am reworking mmap_region(), since this is the only place where it >matters, and it would make everything a hell of a lot clearer. > >Thanks for pointing this out, it's very useful (and an embarrassing >oversight on my part...!), but I think it'd be better reworked this way. > >Thanks! Ok, for now I would just remove these two lines with the change log you suggested. -- Wei Yang Help you, Help me