From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7606D0BB4C for ; Thu, 24 Oct 2024 01:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BAAB6B0082; Wed, 23 Oct 2024 21:26:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36AD66B0083; Wed, 23 Oct 2024 21:26:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20B7B6B0085; Wed, 23 Oct 2024 21:26:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 01F536B0082 for ; Wed, 23 Oct 2024 21:26:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E608E805D6 for ; Thu, 24 Oct 2024 01:26:07 +0000 (UTC) X-FDA: 82706754900.10.9B734FB Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf11.hostedemail.com (Postfix) with ESMTP id E2D9240017 for ; Thu, 24 Oct 2024 01:25:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPL1x1N8; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729733030; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LW5s0ts3emXbAO6ktoSaK2rpBNc0+jdR3nk1YUAiJOA=; b=SENj+wUwKOUJ9RKw92re8+BBcaupG+2SWQqEIYgbXp8SMiBrzUU5bhdKEES6RYYFw3msy7 AgOqdKC452onmLlh0cPefQ/a6DvZu2QFzBWNn6bfkaIwx8XsetvXSLJTyYrRdtVLWm9WLG sC8XzWxTG5Hmx/STBzSsMLTl1pNEAzI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729733030; a=rsa-sha256; cv=none; b=E8uiuA62UNy0AIU13D+4b7FTsfAGHi+tfFWImAVtcvQoZS8DoN/3/ownPyMyEr6b06IDJ5 5yzEHGxUSORWSLZ36RlrRaWaCSz5Gk7SQ+0KMztGcmZe695MRcUHAnFrDwlMDSSXefOTZc Er/boJar5l2HcqG9M9r/qI91Mqz89lI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPL1x1N8; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a9a16b310f5so44089966b.0 for ; Wed, 23 Oct 2024 18:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729733180; x=1730337980; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LW5s0ts3emXbAO6ktoSaK2rpBNc0+jdR3nk1YUAiJOA=; b=WPL1x1N8FUltA8EEOzwZ9dAb0Aq2fFSwZDwPtEytAqiT2l/ga+AQfe5V2dsWd2cywY IRBY59zqsOeClB4ziOoCsSC3SKJx4HsLa/NEP3OmwbCL3ESJv3ymp2Lt/QIu8WS6escF 1WstFyXK9UvN5Abu9o45iHwSPGuPAEwi3QEqZT69xg/vQsioWZEY4mbIJOxIWLP+kZFZ TQ5guJgP1YNahpr719UOap4AwOKjax+dueZYyb+wunBl7ypNkehAwS/JHaoyHg72mSkK lAorNWR8qu2lSbLJ48xogdaR9LPcaN9dP9yGPfec34rhLp6a7zFszbudsENRMcsfX0Mj tojg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729733180; x=1730337980; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LW5s0ts3emXbAO6ktoSaK2rpBNc0+jdR3nk1YUAiJOA=; b=GOXIIsU/RkprO8kUt7+3MaPrn4mCAgrb4t3F4CF6KihqY7p5pJTT7TxWdu5J7upShh qOqRZ+toX1xXqA4ExGC5fW4tPjsR9zcS4IbiWRCW39lRAMIx8DjKpo0GwNrXvUhW0adJ Ls65IIozoHjA4nvc8tSGO+HwwPn91y1zwpFPs6kgaLOa5wJm21Bwx/35MYmnmSVEdFXj 6+IizTREAAzKgBmGmdWr6BCSQ+813I8sFxiDQ/s4+gy/7jwuBGEYYnHgqtSRp9MUKeaY rFML7mGpgqgOOtOIdKU1ZELIIyXG91uHQ1Wgmto5TnGvsPZaqOAicCFm0wP4UT1rzph4 u1ig== X-Forwarded-Encrypted: i=1; AJvYcCWftq+zRFPM3KWnzrNsUl0UvQ5cGbbTWE8Tfm5Qmb075apv3sQdXAfQ9ZovzlVcdiynR58UBMP5UQ==@kvack.org X-Gm-Message-State: AOJu0YwSwCdkLy8Nanr9MBcj+WW/UYs2xjNUO3wm5S2RK8Te+8BVA+EU pRL/qEgpoKs30mbEjmpUUMbwHVP0FhumhVeDHDGxgi7YrOAIMOPM8K7Waild X-Google-Smtp-Source: AGHT+IEo4g1u2FNmLLJkzwzUMo8Asoi2Ziinj7nHCIeWeufUFc+rLd3+DKvMOLce/onIHXTPndiI7Q== X-Received: by 2002:adf:fd8d:0:b0:37d:4125:5cba with SMTP id ffacd0b85a97d-37efcf2e89cmr2606343f8f.32.1729732841949; Wed, 23 Oct 2024 18:20:41 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a6a491sm5083154a12.44.2024.10.23.18.20.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2024 18:20:40 -0700 (PDT) Date: Thu, 24 Oct 2024 01:20:38 +0000 From: Wei Yang To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, surenb@google.com Subject: Re: [PATCH v4 16/17] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc() Message-ID: <20241024012038.zf3dpqsflnyi4wce@master> Reply-To: Wei Yang References: <20240814161944.55347-1-sidhartha.kumar@oracle.com> <20240814161944.55347-17-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814161944.55347-17-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: E2D9240017 X-Stat-Signature: prjyny8uuk1se4ynmetajf5iw17wd7db X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729733159-460145 X-HE-Meta: U2FsdGVkX181+ZQ/ePGfbmH4wQcBfgigtdReDSBSFPhcG0k8YQqgeEUpnW6jVQE+FDeC42PV1bquB2ANeqaJmmHityBDTxJtUoeZwL+YNIEljaGtpTtzyyKJCMevNIEs1+4VTDk52iU36pmvhbDCaDVV/Mlw9GqCXP0lVdyeaU/Uqm5hgN9IGQh/1widk0MtfmjqM9QkxQUCyKKwrpKZFL46cBkTjpNgc73B2DGiudiEqeVz50lMP5MnCpdFrKzA59L+wLf6QCpD8xHF1VoQJxmxSFVd1Ba5tBRxJ0VRFhzfaj5nAlVdGvhjq47Qou+tJlhTbO2PFX75D2WmdqtW1ukNrB3pzQrVxqCB3sMHDjoGVLrS49SFzTOKGnBWK1xanm4oKUtKU4pNqZiixGUa/tA8Q4KBIKnjuqYFZIRuidPd87oJRq+kEKQPsWsegDqVDl4YRPl65So3tOzrDaL5AccHgCMl4TDVh5GBFO2f1sok6DMPp7VoJsaJAppYEm3X+xiqNqbY5tJWK8dJcbluObz+MMHyMRy5tGuklIXO54bEkpQeDg61mHxx6oEfXyBuqM7wsPm4hNe6ZjFZGAjzmqYCJJFe9z2FZ2EHOa4OY96nsNJo0oxPJVYP2BTRwa3wyMESLQVRSD21ZbDwfPkSGuvI3QrRTmEX2DMEHJf0AH2y5Qv3gQvrsSmmBM5ynqzz9ypzpYpZ1ItGRuX6DXSzHvPIHG/umb+zEnkbG9zO5cCHPBwCdPYESi9SyrffYDz30ntcWptjngaB70CfxfmJW/QS54OMcT1uvKD3tl0FjmSKFmwRpouPLTsb/01/GSBeCQkc9gsKmibzLrzbgdjDtnKwn0yDh18CN0Z6uJluZUpvuxwXm1CIsqNKjQrqnmvCr1y49aL5EWwp6EFBJQuD/GXC1NGWRtKDA3rQs1TQGhmVowAilfCaQIHDOD/U7NdwvSj0vn9U+kpEDcAGm71 KfM8RAmm 0ySfN6reGsMtOHLCCYnNVNwvw9ZPSIFbT8lxmvpyzOzbQjKyeWZXai6wA3VcgPLMXvomuc1uiHB2HU5P3Eq+rewlKbdST/npXTnn5luANk3BTzS4/GhbnFrzO3VBTiqHwZNd3xeKQ0LJ5ZDcEK2vl6Owz+Ob0KUd7Dr+6sR1pdxZULoo803aucgAY7R1jK7psH4WChwhpNgzGGD9IKbJjm7OmVPa13GMOzOjMDlrC5TDSGXz3k39h3x+1xVFgHPsnrRrf9cyJ6EVtlIH1jmElecTFuio+QcUJ2dC9Jx6wsxNH3349KiiX4EypRriZ+gu0QSXuC10juvemxhodT2SnD+G4G4ciSRk1+D7cHAtHJl8oeHHg21kN2M+ZvGXpbL83IkTJVryi2r7oDKLbfntZoioiczD36ANukF8RyHsq9iDx0idw08OO+LCtq2OOILxVI2FLpEuVJ5hwcSrtVZ6bGBvjjb87NbPrtfi05cYSPpDZPP2mpXvREyENo1mR+suJYX41CbcEZ5bX2TLnLO1s2qrWagyIw1TWoHGlM09pJqPKsrR5vl4yOaNIc/vX+KiaqPC+kSxuUl8TzEjqAKobdnzMOFxgxKZfediOrXrS/5fuzt+WL2V3cnhtrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 12:19:43PM -0400, Sidhartha Kumar wrote: >Users of mas_store_prealloc() enter this function with nodes already >preallocated. This means the store type must be already set. We can then >remove the call to mas_wr_store_type() and initialize the write state to >continue the partial walk that was done when determining the store type. > May I ask what is the partial walk here means? It is the mas_wr_walk() in mas_wr_store_type() which is stopped because of it is spanning write? I may lost some background, so the assumption here is mas_wr_store_type() has already been invoked and the store type has been decided, right? >Reviewed-by: Liam R. Howlett >Signed-off-by: Sidhartha Kumar >--- > lib/maple_tree.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > >diff --git a/lib/maple_tree.c b/lib/maple_tree.c >index 8c1a1a483395..73ce63d9c3a0 100644 >--- a/lib/maple_tree.c >+++ b/lib/maple_tree.c >@@ -3979,9 +3979,6 @@ static inline void mas_wr_end_piv(struct ma_wr_state *wr_mas) > wr_mas->end_piv = wr_mas->pivots[wr_mas->offset_end]; > else > wr_mas->end_piv = wr_mas->mas->max; >- >- if (!wr_mas->entry) >- mas_wr_extend_null(wr_mas); > } > > static inline unsigned char mas_wr_new_end(struct ma_wr_state *wr_mas) >@@ -5532,8 +5529,19 @@ void mas_store_prealloc(struct ma_state *mas, void *entry) > { > MA_WR_STATE(wr_mas, mas, entry); > >- mas_wr_prealloc_setup(&wr_mas); >- mas_wr_store_type(&wr_mas); >+ if (mas->store_type == wr_store_root) { >+ mas_wr_prealloc_setup(&wr_mas); >+ goto store; >+ } >+ >+ mas_wr_walk_descend(&wr_mas); This one does not descend the tree, just locate the offset in a node and adjust min/max. So not look like to continue the partial walk to me. >+ if (mas->store_type != wr_spanning_store) { >+ /* set wr_mas->content to current slot */ >+ wr_mas.content = mas_slot_locked(mas, wr_mas.slots, mas->offset); >+ mas_wr_end_piv(&wr_mas); If not a spanning write, the previous walk should reach a leaf node, right? I am not sure why we don't need to check extend null here. Because we have already done it? >+ } >+ >+store: > trace_ma_write(__func__, mas, 0, entry); > mas_wr_store_entry(&wr_mas); > MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas)); >-- >2.46.0 > -- Wei Yang Help you, Help me