Re: [PATCH v3 1/1] mm/migrate: Add migrate_device_pfns

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 24 Oct 2024 01:50:34 +0000 Matthew Brost <matthew.brost@intel.com> wrote:

> > On Wed, 23 Oct 2024 16:39:44 -0700 Matthew Brost <matthew.brost@intel.com> wrote:
> > 
> > > Implement migrate_device_pfns to prepare an array of PFNs for migration.
> > > Handles non-contiguous ranges of device pages that require migration.
> > 
> > OK, that's "what".  We're more interested in "why".
> > 
> 
> Sure can add. The 'why' is:
> 
> A non-contiguous allocation of device pages can occur if a device is
> under memory pressure within a single driver allocation of device
> memory. Additionally, a driver allocation of memory can also be evicted
> under memory pressure. Therefore, an interface for migrating a set of
> non-contiguous device pages is required.

OK, thanks.  But when merging a new interface such as this we like to
see the code which will actually use the interface.  Along with reasons
to believe that the calling code will actually be merged, so we don't
end up with a new interface which has no callers.

Apart from that, I suspect that it makes more sense to merge this via
the DRM tree, alongside the code which uses it.