From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3576D0BB4B for ; Thu, 24 Oct 2024 01:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31C256B0083; Wed, 23 Oct 2024 21:22:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CC336B0088; Wed, 23 Oct 2024 21:22:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BB466B0089; Wed, 23 Oct 2024 21:22:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 011F86B0083 for ; Wed, 23 Oct 2024 21:22:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6300AC900 for ; Thu, 24 Oct 2024 01:21:45 +0000 (UTC) X-FDA: 82706744610.06.07C14EA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id C7B0C4000E for ; Thu, 24 Oct 2024 01:22:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FIZYV72Q; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729732888; a=rsa-sha256; cv=none; b=dDyyAd7NPvhpI7Ozc48l49o+6mNYdIY1PpEDrh6KANjWVAsBnSGHRY7EdvR3IPKOi+jtvE tHIPuKNN6Xf1UXgTCCTZou/Roio6FhgxNOFrrVnqZKbAk01LPqXOHOwJgZFgZIoTRgW3zl mnakGZc2JcIx+dU4nxGUmqq2RcxqZFU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FIZYV72Q; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729732888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eHKJx0086MGeF3Gxo1dlVCcWEvJ6t6cpj3sh8aSFBXo=; b=xPmn3d1hJr/MkiiRlAmE1cJY+YTVbe3nLLLXUCoGE2QEKSZqzI3WJ4ZKgP88fFxZuZGH78 04PRs7KI4tvDzftJfqOhlWAmWMaD6rDTE0m5qEZIDQk5QytY9Sx8hA1FaRvjDsDNl/fq/2 MKm4T4ZyWTyJRxOR5Vpz3+SkmbXlqBc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F229B5C58FB; Thu, 24 Oct 2024 01:22:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7F86C4CEC6; Thu, 24 Oct 2024 01:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729732938; bh=oCdhpVoh/SNCNsR3EypH5LjarVuXAX+BjqQknwkXXxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FIZYV72Qor/TzhluoP6m8ZPtQTci4oXMo9aqaHe9N+7RZtEmo7/UFi41TSKi+eqXY lqOuuDO3VjsDI0q96CgcwxPZGpw2dRT7PQoAyTLTvf68sg3+c2TiCyOPGz4FJeMRB7 LgyfY9NmdWTyY7okPWVZR/KGcU3jM5uJyv9Fa2Z8= Date: Wed, 23 Oct 2024 18:22:17 -0700 From: Andrew Morton To: Matthew Brost Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, simona.vetter@ffwll.ch, felix.kuehling@amd.com, apopple@nvidia.com Subject: Re: [PATCH v3 1/1] mm/migrate: Add migrate_device_pfns Message-Id: <20241023182217.147ee87197b53d47057a4c06@linux-foundation.org> In-Reply-To: <20241023233944.1798835-2-matthew.brost@intel.com> References: <20241023233944.1798835-1-matthew.brost@intel.com> <20241023233944.1798835-2-matthew.brost@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C7B0C4000E X-Rspamd-Server: rspam01 X-Stat-Signature: rbowrcghxicr639ykzy3m3p4jppu56at X-HE-Tag: 1729732925-974893 X-HE-Meta: U2FsdGVkX19mKowXoySDmtg5rSWdqudaATbTOSGLXbXkTRsx+RigFdPH+6rozE38wRRxqRsFw54MmrpRsBcpwVrYmUnkq+vgueohoWMgDouNknvyZ9EAxmGRgbEU5PTcfPc9RO+/jjL/hGhJzWPjktBxMXJibRjOlqwpY680v8bls9rS2mSj7exvBaAHNCpSEo//TaFSX32kCnNLySfiqDUMVL3PoUaJ/kan4OB9fFPGGW4OE3mInDEkQZiTMVaWscod7ghQh3SGSIL7KZP8VRYiuMJFmITUnSwSGqZrLI8qgxN9dlw7c04cnusnBRyaE3NIQAASD/VnKST8JaVT1iBvahZfZ830eg2RA/3DVt2odEwzILvufrGzVOgLlnqYAn4jUUBuqk/1aSHUjMu6qD6ZgPtD9NMxqbJEAmSVxuWaTn+eEJAQK9NsOROnf4BRzM2riaXZ975bBx8OdSrn+2/nyRjpU3ioYWcvHEAWMZZVg0/x5lmiwE0oIbgFRangwe1ey2u5k8HKYF0iHYIDBjcC0eZ/ON3ntppttZceMkqRmTrtluBzIH3wgeqOqyFCQ03+wn2rbR1/LxIVlrMSFglUraEDAptE0ZjeQP2JVhhhmRYMNxdL7uvxLXjGQkjdp9LlPCi0tYh9EXWdTDFOywOVpZdTHyVmTx58uDBLXWalshyoUSeGjqLCQ9EjI3PlCMN93uc38CpjrLSqMPygPvV8oa1+FvXiA7PUDME98FG4iVoU40IQLz1dVZ2pdocEcI2+5Gaz+IWOLigmMtUihRNtXgsQWuDqxDD9Tgxt6q2okvIGG2J3n74qm7h6ad/SjcAy4PudamOabByGpJPoslG5/48ij9ZiRq+Czre9nI7QGxMHh26ipTgeekhf6fkdZkdg1lbXZ6QviFCHMTP1986/5qDLIrHxGGJpN/pYHXD85HzNtw12yft+/ukNmbIsX8cguUYg6Vji+yHop3D XOMv1G0W hb3OuJYB4ty3wHmxV4oed7i4LFf7au2EyphksvvyuwRnoVaUUXShHDvzADtL49d8lXAdHeRs3D+1z6JorMOMBfifKU5Ub4AWzNVh9cO4yOGK2oARp6XmIKihuEk1vzzFxhqiXkoOOO0vzLVaeczhv1oIVrC71BUoxK1xFw6mqqPPooeHC6zfWrf4sMsKaI5mCR+CHuo2MeieRzlN1vVbrYDxf2LIb/yRWqpaR1u6xf84cSEod6gW2vBFvWp+drWeF6Vx2lz8uUSf0qNf6NG+yXhp/7cSm1g+PxuMavnSTcSN8E+isv7aWqh1ELPqIZqczNLoR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024 16:39:43 -0700 Matthew Brost wrote: > Part of series [1]. Sending as individual patch ahead of that series as > this is a prerequisite for merging. That's news to me - singleton patches are perfectly OK? On Wed, 23 Oct 2024 16:39:44 -0700 Matthew Brost wrote: > Implement migrate_device_pfns to prepare an array of PFNs for migration. > Handles non-contiguous ranges of device pages that require migration. OK, that's "what". We're more interested in "why". > +EXPORT_SYMBOL(migrate_device_pfns); And it's exported to modules, which adds to the significance. Please fully describe the reasons for proposing this change.