linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de,
	 mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org,
	thuth@redhat.com,  tglx@linutronix.de, bp@alien8.de,
	xiongwei.song@windriver.com,  ardb@kernel.org, david@redhat.com,
	vbabka@suse.cz, mhocko@suse.com,  hannes@cmpxchg.org,
	roman.gushchin@linux.dev, dave@stgolabs.net,
	 willy@infradead.org, liam.howlett@oracle.com,
	pasha.tatashin@soleen.com,  souravpanda@google.com,
	keescook@chromium.org, dennis@kernel.org,  jhubbard@nvidia.com,
	urezki@gmail.com, hch@infradead.org, petr.pavlu@suse.com,
	 samitolvanen@google.com, da.gomez@samsung.com,
	yuzhao@google.com,  vvvvvv@google.com, rostedt@goodmis.org,
	iamjoonsoo.kim@lge.com,  rientjes@google.com, minchan@google.com,
	kaleshsingh@google.com,  linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-arch@vger.kernel.org,
	linux-mm@kvack.org,  maple-tree@lists.infradead.org,
	linux-modules@vger.kernel.org,  kernel-team@android.com,
	surenb@google.com
Subject: [PATCH v4 2/6] alloc_tag: introduce shutdown_mem_profiling helper function
Date: Wed, 23 Oct 2024 10:07:55 -0700	[thread overview]
Message-ID: <20241023170759.999909-3-surenb@google.com> (raw)
In-Reply-To: <20241023170759.999909-1-surenb@google.com>

Implement a helper function to disable memory allocation profiling and
use it when creation of /proc/allocinfo fails.
Ensure /proc/allocinfo does not get created when memory allocation
profiling is disabled.

Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 lib/alloc_tag.c | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
index 81e5f9a70f22..435aa837e550 100644
--- a/lib/alloc_tag.c
+++ b/lib/alloc_tag.c
@@ -8,6 +8,14 @@
 #include <linux/seq_buf.h>
 #include <linux/seq_file.h>
 
+#define ALLOCINFO_FILE_NAME		"allocinfo"
+
+#ifdef CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT
+static bool mem_profiling_support __meminitdata = true;
+#else
+static bool mem_profiling_support __meminitdata;
+#endif
+
 static struct codetag_type *alloc_tag_cttype;
 
 DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
@@ -144,9 +152,26 @@ size_t alloc_tag_top_users(struct codetag_bytes *tags, size_t count, bool can_sl
 	return nr;
 }
 
+static void __init shutdown_mem_profiling(void)
+{
+	if (mem_alloc_profiling_enabled())
+		static_branch_disable(&mem_alloc_profiling_key);
+
+	if (!mem_profiling_support)
+		return;
+
+	mem_profiling_support = false;
+}
+
 static void __init procfs_init(void)
 {
-	proc_create_seq("allocinfo", 0400, NULL, &allocinfo_seq_op);
+	if (!mem_profiling_support)
+		return;
+
+	if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &allocinfo_seq_op)) {
+		pr_err("Failed to create %s file\n", ALLOCINFO_FILE_NAME);
+		shutdown_mem_profiling();
+	}
 }
 
 static bool alloc_tag_module_unload(struct codetag_type *cttype,
@@ -174,12 +199,6 @@ static bool alloc_tag_module_unload(struct codetag_type *cttype,
 	return module_unused;
 }
 
-#ifdef CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT
-static bool mem_profiling_support __meminitdata = true;
-#else
-static bool mem_profiling_support __meminitdata;
-#endif
-
 static int __init setup_early_mem_profiling(char *str)
 {
 	bool enable;
-- 
2.47.0.105.g07ac214952-goog



  parent reply	other threads:[~2024-10-23 17:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 17:07 [PATCH v4 0/6] page allocation tag compression Suren Baghdasaryan
2024-10-23 17:07 ` [PATCH v4 1/6] maple_tree: add mas_for_each_rev() helper Suren Baghdasaryan
2024-10-23 17:24   ` Pasha Tatashin
2024-10-23 17:07 ` Suren Baghdasaryan [this message]
2024-10-23 17:26   ` [PATCH v4 2/6] alloc_tag: introduce shutdown_mem_profiling helper function Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 3/6] alloc_tag: load module tags into separate contiguous memory Suren Baghdasaryan
2024-10-23 18:05   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 4/6] alloc_tag: populate memory for module tags as needed Suren Baghdasaryan
2024-10-23 18:28   ` Pasha Tatashin
2024-10-23 17:07 ` [PATCH v4 5/6] alloc_tag: introduce pgtag_ref_handle to abstract page tag references Suren Baghdasaryan
2024-10-23 17:35   ` Pasha Tatashin
2024-10-23 21:00   ` Andrew Morton
2024-10-23 21:09     ` Suren Baghdasaryan
2024-10-24 16:25       ` Suren Baghdasaryan
2024-10-23 17:07 ` [PATCH v4 6/6] alloc_tag: support for page allocation tag compression Suren Baghdasaryan
2024-10-23 18:29   ` Pasha Tatashin
2024-10-24  3:48     ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023170759.999909-3-surenb@google.com \
    --to=surenb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=da.gomez@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=dennis@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jhubbard@nvidia.com \
    --cc=kaleshsingh@google.com \
    --cc=keescook@chromium.org \
    --cc=kent.overstreet@linux.dev \
    --cc=kernel-team@android.com \
    --cc=liam.howlett@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=mhocko@suse.com \
    --cc=minchan@google.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulmck@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=souravpanda@google.com \
    --cc=tglx@linutronix.de \
    --cc=thuth@redhat.com \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=vvvvvv@google.com \
    --cc=willy@infradead.org \
    --cc=xiongwei.song@windriver.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox