From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBE5D0BB46 for ; Wed, 23 Oct 2024 23:51:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA2386B0099; Wed, 23 Oct 2024 19:51:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDB1C6B009B; Wed, 23 Oct 2024 19:51:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06626B009D; Wed, 23 Oct 2024 19:51:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9F7D46B0099 for ; Wed, 23 Oct 2024 19:51:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33F7B120C25 for ; Wed, 23 Oct 2024 23:51:02 +0000 (UTC) X-FDA: 82706514954.01.5802118 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 0C68080008 for ; Wed, 23 Oct 2024 23:50:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ejMTJVlb; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729727399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aWZEyeMaVZSPyo6S+zLA0h4P+LwnQAYCYo+9YpwVnyw=; b=mV7L62lbVjsdpUuZUIQOt9tbcUtAyEP4Sser4jsNC9iRVDWELhCtqz3F156L/7yvqR9kL1 ukpHhvJAjj0p8ZXNZSWY1AkDT+C+VYmuVKlJGgeyWwefvCUOv3/mOYLXh9svo8DzwHbD1v P5LSgACyu6Rfw2iL+K6Gzo2196dU1K8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ejMTJVlb; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729727399; a=rsa-sha256; cv=none; b=nGJzQlFEQlyVLeKEJLajx24NNPKr6yOTBkQ/ab92YM4HM9XA9E0shvTdCUyEBwWqA77DwQ bKzkp56i0waKpuF7HzOXL/cNFuQQzIVfLJzRDkFM5V3D925eC/ySUJ7p+y+FCGHAiD/eq3 g0e60aeBGUXd7nFPoGYY52koSVEsds4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DDE98A448C4; Wed, 23 Oct 2024 23:51:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E5A6C4CEC6; Wed, 23 Oct 2024 23:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729727475; bh=tOZhLRxidymKCjRrKhnrUX/ok8moZodUQb17kcBnaM4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ejMTJVlbeGGXuvrnkU8BuiyXJWHHcG7iK0SYGd1wJEGPzDdZdIgtMBSPWAsOiXhT4 mFThJC8JNnjh5yxB53ovx5G/+yRQkv8u/bPmcjKb1E6kR2zBzypwc3R/JEKphHUsKy Xx6YZ1RViDA3vz+B7loVdZhTOowmbY6qKfsa2fz8= Date: Wed, 23 Oct 2024 16:51:15 -0700 From: Andrew Morton To: Wladislav Wiebe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka Subject: Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo Message-Id: <20241023165115.b524c51e80c36e120edabb36@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0C68080008 X-Stat-Signature: w7fj88a7oabjau313qwhzkrpx6ebynym X-HE-Tag: 1729727442-685002 X-HE-Meta: U2FsdGVkX1/fe+loIKim+7mb3gsbNQjTN9UAFzHz45xOfdR2UbRFH4i+6KPIaBkO4SJjVbqh6jIVvGpGmLkZwBd1SQ64mBIexiRebGonyCq4ISByKPpATxCnqAHC7SWrhYeOfkklOK8XC0borFYqV/fMChCrHvOsi4G5aS7ACN1CP1bs4YL8NtdUG9Dwcrx8OY+Pq+KZV7pgrp3gQuNTZFmnBAbINhTKjuctfvL0CnnywIgV/oMlaMBwSoxaqeA4Gvg4YIdzbNtk/OPfPccvh+Dso7s/+85Lr0nrUd1enooYA065u+IEM/mWLDZcnfECh+yP/KoXXcf3F9yR40z2J1+rZnyLDN5ERSBu3cb+1hrwI1cumYO53ztJocfOYavk/jYnUV8YhBukk6K89wyXQrBtEHCVStSrpSitIx+H1CpnJoIcJbs7mzmSBa43LOU+WimyJcTeehMDk9snyy37nDr4TOVUla6mRp4PKfnKn9odHpx/xbB/sEVZEryE31K9pqTneEvnD0pMqdIF+0f7cduqgKoSAjP4wvP4W+simUhSZLBux5/M5vBy9T1wzeO7hZGR6meEAsEihEVec5t9Xvas0ozIS1xuUZMAZpYxpe6Xf8PpQJDwWcVa/zZK7AtDq92ytjqrRU4OaCpcHpaB2ei2xF2EPHQ61IQLXvDqdyYl+B6jvVqF74NIyboFsTyTK23f6iWDVEhe3WVzL4DLrpXXlxonA1/U21ZNtCFH9D0JZwJoB1pOOlwQdkYBZQIKu2QOBOz+rEKxEf2P8hySw81e+jHLUcEE3T+oPK+u+AK6a2SgFGrOBXFGUi5Jr/dqTPu2xtZdmhL+rI4WcVxiWgki/w3JobMkDDPqmBfkT2w4qvqyY4QnrKqg9ikC1R67BI/BWtUJ5gQudreGF0ASOsuPfGtKqGJjJUOUULRbqOgT+eqHMWzlhrvTxgCI0y6+IsqCyiEr5exxzDCmCfy 4m/NMrgB VDbzmpmq4DibpDWri7saW0rHEJAzw73+kLx1FvJTEEisEScrsa/VldkolpGezl3XdUzFZcDqd+9tGGVRKVNuEcYAeNyWU8oJIhw3TlpctrSh5hdm9apORqL+jjbMcP2BUdZFohj1Fa+LKiHcl1kO60liK4qJLYv+qDUfAjPlgphyfPxiZge9I0ilHbM1n0cGqMPt6CwQyEIBGCmms77Q2UhLYWqYFOlO1ejqSKxfaGmzfBr8EXaPXmdd/gkcl9KESFZfw8yRsFUdz2xElvwU9I2ADG3KD4414gj9SGli8ZRfnPpqon2BWwZOi7hLKFhJ9FmdA3h0GbfJZePCMxr+ontoY5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 22 Oct 2024 19:21:13 +0200 Wladislav Wiebe = wrote: > Commit e6d2c436ff693 ("tools/mm: allow users to provide > additional cflags/ldflags") passes now CFLAGS to Makefile. > With this, build systems with default -Werror enabled found: >=20 > slabinfo.c:1300:25: error: ignoring return value of 'chdir' > declared with attribute 'warn_unused_result' [-Werror=3Dunused-result] > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 = chdir(".."); > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 = ^~~~~~~~~~~ > page-types.c:397:35: error: format '%lu' expects argument of type > 'long unsigned int', but argument 2 has type 'uint64_t' > {aka 'long long unsigned int'} [-Werror=3Dformat=3D] > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 = printf("%lu\t", mapcnt0); > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 ~~^=A0=A0=A0=A0 ~~~~~~~ > .. >=20 > Fix page-types by using PRIu64 for uint64_t prints and check > in slabinfo for return code on chdir(".."). >=20 Thanks. Your email client messed this up in strange ways, so I basically typed it in again. I added the Fixes: target and a cc:stable.