From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF33CFA472 for ; Wed, 23 Oct 2024 21:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 218596B00A5; Wed, 23 Oct 2024 17:00:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C8A96B00A6; Wed, 23 Oct 2024 17:00:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01ACC6B00AB; Wed, 23 Oct 2024 17:00:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3FD86B00A6 for ; Wed, 23 Oct 2024 17:00:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2EFBC1C4B74 for ; Wed, 23 Oct 2024 21:00:07 +0000 (UTC) X-FDA: 82706084958.11.53E475D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id 73B9020009 for ; Wed, 23 Oct 2024 21:00:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r2uxN5Qd; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729717148; a=rsa-sha256; cv=none; b=saP1Li/VtWK/sgtByarKrSvtCIdXFcEUJXSg1hpb5M/4yvOxFkdCHu9JKr/4TLqXQpoLSl /qkUIGwC1siQVL/dHYVMAoVh+8oomw4RkTGCTd1Ajk5jfg436isCEPcFnKRqirDrv1OD7E YMkxAduhIU9mf8f4XM9pUtBe1mp10Bc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r2uxN5Qd; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729717148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uffpE4487xQC0UJn4b/Sz9QsUYZzoEH4WeN+D7FqdIU=; b=ZbS+IC9wP1SmC9LhTmTeJzULvRELo+g84kNs1Ca5uYuuhnEsgXaZTD228/4yzZ9pXfoQkc w1yNqo0FoGTZdoNKJTAb/npCSjL9gErKDNNWXEcGAI7ZftICbNfEgGMcmIW0J6RZo76u0p oLCRPUbksTaDt0AFXC5/LKebqU7R0d4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2A95DA444CA; Wed, 23 Oct 2024 21:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 665E7C4CEC6; Wed, 23 Oct 2024 21:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729717224; bh=4eSmCo6i0if5D6CdJVmAQN9GUXvTbEx1TW8GzU+3oWo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r2uxN5Qd5gm76NxG+Qlhr9lMttgqy65AazTAi8k5+n4TtXJdd1yL5LhAGuhhgk0xi Un7unedgoFxkTyTeFCt4VXqOoSSgnu5sM3TwS7VxhOc4WG2sVBqY7a9QsA1wzJ1je2 kb9ElqWHIX9krkoGE3oF1hiLvbjrQkZwifaqy1mg= Date: Wed, 23 Oct 2024 14:00:17 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, jhubbard@nvidia.com, urezki@gmail.com, hch@infradead.org, petr.pavlu@suse.com, samitolvanen@google.com, da.gomez@samsung.com, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, linux-modules@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 5/6] alloc_tag: introduce pgtag_ref_handle to abstract page tag references Message-Id: <20241023140017.e165544bf20bcb0c79bfee57@linux-foundation.org> In-Reply-To: <20241023170759.999909-6-surenb@google.com> References: <20241023170759.999909-1-surenb@google.com> <20241023170759.999909-6-surenb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: iucg83e6d3zc5bsgkiy68b7n6xnjmwgd X-Rspamd-Queue-Id: 73B9020009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729717217-976805 X-HE-Meta: U2FsdGVkX19VRIr5m3aWvqgEpc5araeLcS12KUVHaARTmBqOp2+VFFz1xGPy3VFkwQe/iqnPf3dvqZR0tEx6Jry9wjYIsgR5asvW4phoK+k+DPYTVafhJVaqAtVOmIe1Oz7LJ80JuSC/4oV3md0SqOeAzpogVt2l9PLlkgY715DhUtAR0RMvwH1ysBkMVl7B/Gnh/qQyK/iz/q9ZZ0nM1LKCT9DWrCZ+9rVN7Cdn6jSskG4a9/WXXRst5DQR3RSzqF2sYz35NX0S4KhcGUq5TJpc7IupngZk3PcvmrCLdD0doGu7aq8K0xZRv5GhM0SU8ehTLEI/OW+VFUIVyW16Zpfzk6Da6Y+HFTa29KbUTzyqhIx9YIuVcXZZPUAlE3mmJ2fQGqvy/dq63tqVFS/xfcn3TXLK/KhXOGZKVwhqaJ3yze7NFet8lfha7XvXMZfxHWaqptsbzfdb766wPoFIVSLGWRyadCz3e/miOnD8Fm6Qu6s0ZPgVlN0XXOzC5nxj8bRGjU4tyBGVVFgPvqs2cGhlNYeHF62z2VzvQ/Ml2l1ovk41N280AcOhXQN1xxEB0392/CTFwWL3plEMQDIlUZJGRV2bXc2kQ8AwzymZImSJIdDF9cKcClyeutGn1ZzWDFyEnnemTVmvJYcPoRliYb8EIn+OLaqMsK6eRSO+AAB7N3ZwI1j6cypEyp5O/XrtluNmaSsWIdgZfyHu6rDDZvVQcxFfGmvuusEJnt1EerWOGvDvxLskr/7wo1280dp3KL18HrIHqekw3kOLdQxVHjDOA9JE0hcVEjVBJUJgUWyE6rVQCQ8CQeaDCAzpTXFzoAXtCUFzpcpDdXduUrECQEKGcPhs313ghCmX8Yu4UMsTPHuFSkHaJmyR+yHB37hW+t91ihg13SyAlredmnWqIWPPKLNqylUvYnRvfuop00fyXMCP4Ru/3FkytAmc8kQEDnzxRW4jJBwX47qmzDv aj41g/m5 MoVjmK+OzEsZIKa8Sda8XMBa+IrUl6jZUtYPOz+HzFRc60tB+yZr41XK/FstWv/UQsmgJzIjkL4fr7XYTMQvjJjbmI4R4JKLo/mSOUj/yMGONMZSR8VL3rNIh/tLSly/L6YcstTDEjsZwfyehiPVBfPbI0X0doYRbHdJSXrxKPLVpHBrEyoAkmo9XUkiFrNZ4MW2tpoajc94O5SQIdtzH5/rf7xOwNAzp/5XEydtA3JqpZm9nX8vZXFWKFHIoGiStJeoBhI9SnMkz0fKYrqbxCyGZYrGjefEQoiNebnewtFeuixHr8HzNSy0tFK/u3lD3FyJs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024 10:07:58 -0700 Suren Baghdasaryan wrote: > To simplify later changes to page tag references, introduce new > pgtag_ref_handle type. This allows easy replacement of page_ext > as a storage of page allocation tags. > > ... > > static inline void pgalloc_tag_copy(struct folio *new, struct folio *old) > { > + union pgtag_ref_handle handle; > + union codetag_ref ref; > struct alloc_tag *tag; > - union codetag_ref *ref; > > tag = pgalloc_tag_get(&old->page); > if (!tag) > return; > > - ref = get_page_tag_ref(&new->page); > - if (!ref) > + if (!get_page_tag_ref(&new->page, &ref, &handle)) > return; > > /* Clear the old ref to the original allocation tag. */ > clear_page_tag_ref(&old->page); > /* Decrement the counters of the tag on get_new_folio. */ > - alloc_tag_sub(ref, folio_nr_pages(new)); > - > - __alloc_tag_ref_set(ref, tag); > - > - put_page_tag_ref(ref); > + alloc_tag_sub(&ref, folio_nr_pages(new)); mm-stable has folio_size(new) here, fixed up. I think we aleady discussed this, but there's a crazy amount of inlining here. pgalloc_tag_split() is huge, and has four callsites.