From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D87CDDE5D for ; Wed, 23 Oct 2024 10:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 040366B008A; Wed, 23 Oct 2024 06:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F32826B008C; Wed, 23 Oct 2024 06:27:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFA7B6B0092; Wed, 23 Oct 2024 06:27:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BFB686B008A for ; Wed, 23 Oct 2024 06:27:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9619C0894 for ; Wed, 23 Oct 2024 10:27:29 +0000 (UTC) X-FDA: 82704490512.23.DC8832F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 682FA140006 for ; Wed, 23 Oct 2024 10:27:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KYZFKdtE; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729679215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1DaEMan3+5PLUOmcFbTK3yrj/OOQcmt/brHj9/EtjN8=; b=V6beJFMIjp1PeL+eMSnYLKf6C8Ttd8HLQ9kbNMfAPQS+F64y07bRqwV3fumdK8HogMLNJe 9ctomK40+9wS11ru8Xkq+AjmIQulcEZmFBEpLBDPG/AszjqbGURi66qZhlOkfh1iS6SB39 HeIXZmBeafrn7HS0i7fkdM+T6lsxNXs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KYZFKdtE; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729679215; a=rsa-sha256; cv=none; b=1m1k9VH2MBc2ggtB2piP8YoQcUTaXavgsOuJalXet7qKaXHdETJnv8h2SxulNi7SJFrvfs c0qCuYgG0oqwxl58+f+SVzXV1xgkBc5cC73CNrUAv19Q+hpYFsAeyqBx4UydlW3dDPSn7J b6F4dvBtWdwlyDzcYhOrITkTZiUy+gQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 273365C58FC; Wed, 23 Oct 2024 10:27:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0ABA7C4CEC6; Wed, 23 Oct 2024 10:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729679265; bh=+a2THu3k5g0s7vgeFB0G4UC22zi05HNxEYaMBCxse0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KYZFKdtEBKZdLVzJq71uEWbaA9sb5ynU8TiUmzammXaISDadlOc2r92Ppxi/JAD8m z0fYUi8v8ajy1yw54tzLeFELQ527m6kGryNk8i8zY9c8yH4IS+QgSBLKgBYmcaO4uh oHwRYd3bh5KmC05qo6td2vmFDMk3b5cQZPNpBIm8= Date: Wed, 23 Oct 2024 03:27:44 -0700 From: Andrew Morton To: Kairui Song Cc: Kairui Song , linux-mm@kvack.org, Chris Li , Barry Song , Ryan Roberts , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Tim Chen , Nhat Pham , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] mm, swap: rework of swap allocator locks Message-Id: <20241023032744.84a6a9f6f5f1e3aa1fe5f0d9@linux-foundation.org> In-Reply-To: <20241022192451.38138-1-ryncsn@gmail.com> References: <20241022192451.38138-1-ryncsn@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8q9qsm36x5n8opzbt8ynsdqmbtp6igq3 X-Rspamd-Queue-Id: 682FA140006 X-Rspamd-Server: rspam11 X-HE-Tag: 1729679254-658731 X-HE-Meta: U2FsdGVkX1/Nqx+6SIUcwm8Dxuvu3WrNVvpGhIwxmn1Fc2Oa7bZRvVAkNQocmC5grMQ81WflyXJ0CrSgiFjjGtONm/ds7+4UzVPiWEV1t859q5H5q9a7OOUMy312DQ9p6ZyLmiVnRoSNX3KdMX1OL3qQTqllh2NgPOsewxDpf0SBYa8Z9f7nG/nrP3o/KoDmlQYSQWVPkkuAMHhRMKnXAVGay3/kVD6qyxl3ZV1ReMliCtf838MAE59MghIj9eBHryZIzoJs8tHPaMRQtT6PGVzUkL5vBG6iZP5YgjcAUIJrOjCG6GrDbyxkcIfg4sP0TM4dEfV1BNlQl6Vyes1uJIosN5YBV1rIf3mUCxJv46HTmc6kWLEYfm9g1f8e+TZUKWjHqFphE+e5+6YgWiXGjSUag5VZqMu1mpqmNLO3pZvELk4jOW/XoSf0QgH7xNUn6np4C5BhRX8u2whI15eQ+/+LqNy2iPq7LsbKE1y5KEqJfUdSdaOHFBebH4d5/zNoUm4ZQzbiF49Cq49rrtg2OmSGO3fEKIxA1k72vupWROUrktwNCipnTmSse4lV5fdtMmDkiKNjeDAyNK8J2z8a701TChNxFtLKHvETD6kQ+aCBYxL+wkcCsirymwa6OY8a6gyKYOSoyr+GDcl9+mS+jXxQAnKYqNbe/fxnFeHcM8Se2j7ch5axovVGqsiY/Y7cCnGE7VSsGenvd5jLRRXao0EL3RivhIU8C9qtQR+lSMmG8/omBUkoaVJE29V0tcuaPKVAP4kx5hrXI06D17dLwQFEkLZWL/HyYQf0p3z/6G40xx5xiBxImx+GCIf4+cvDvr2bAyiDs8AvuC5EWjQ/IWiXTnlZZQu9Trax1AmYr27hvYFOJbCIVFTrLM1/iokOL9nFYPDfO3O5NHUuHXPdP3wN4WWrPnY+pdcWIEdfv6z3Z4E5+6HhZIOv2XvQ6RYjTovIdiAU+a1Dg3cZMDv ReyziNfy xwQyaCgqonmuGRIOPJF1uZ2fDxmxn0VXNe78/Q1lmHi7mueJjIsJmbk4d5bh58VD9QqSazh08weiIi9eiZ2cLRPxPIE2VIq0z21N6XEj5GY1aKcCPt9xz+4cso9zY/fYRLZtxDH7XdVahBIXWPI1GTCXqFZHH4qug+yCVAiGP07gaFUK7nusJF8o0DpfCcipKbcVzL0VTRxilE2S/HLCB0Cbo0nyPktqeH0FpQXluubEKltzuwPXFDI2+ktmUrNJayxm6CLz5gRhQ5JPPCaQsRnJ4eg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024 03:24:38 +0800 Kairui Song wrote: > After this series, lock contention on si->lock is nearly unobservable > with `perf lock` with the same test above : > > contended total wait max wait avg wait type caller > ... snip ... > 91 204.62 us 4.51 us 2.25 us spinlock cluster_move+0x2e > ... snip ... > 47 125.62 us 4.47 us 2.67 us spinlock cluster_move+0x2e > ... snip ... > 23 63.15 us 3.95 us 2.74 us spinlock cluster_move+0x2e > ... snip ... > 17 41.26 us 4.58 us 2.43 us spinlock cluster_isolate_lock+0x1d > ... snip ... Were any overall runtime benefits observed?