From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10955D1CDA1 for ; Tue, 22 Oct 2024 05:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 684B86B0083; Tue, 22 Oct 2024 01:18:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 635E16B0085; Tue, 22 Oct 2024 01:18:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 524006B0088; Tue, 22 Oct 2024 01:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 328536B0083 for ; Tue, 22 Oct 2024 01:18:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84785C1CBF for ; Tue, 22 Oct 2024 05:18:40 +0000 (UTC) X-FDA: 82700083788.29.898ECEB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id 13D3740004 for ; Tue, 22 Oct 2024 05:18:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=x6kjNyBk; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729574260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q/lPrkghL4uwjoVAKinViQX8th8AgjUkhdOZp58K1bY=; b=R+KoQx/fAvU0zwSV3kVLTcd4sgiPohs/HdgEGGQAH7m3mQhsXQpzU1X/wnS3nP+CTf11Ac ffr7gaVgWwF6h/Ma6cwEKWJsaW7j/qryz3gs8wHL0r0+d2yeau02WLP1Je8y1iOvpy9TYN E5rxY+p3HxeMPjh3DTsIfWSRk2nHvqE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=x6kjNyBk; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729574260; a=rsa-sha256; cv=none; b=55GhQnhxFX3p77kodHQnsDiG6glfwJzyFii6PvffY33/gvA84bjhVT1KBi+jBAtERRz1k3 mT7SgG0iIYMyYTSgUBwtekFAUntQAQEhikZfTO0SzueuPeZwH2uhSBbXDMRU+A0NhzDUi5 eJ60Z7frxwQ+NEF0o7vmIpvOkjNkOCQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E4635A43D8A; Tue, 22 Oct 2024 05:18:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ACB3C4CEC3; Tue, 22 Oct 2024 05:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1729574334; bh=RAhRQrMU/Jtdv6RJGp290Zy6A86u4CQL3hSzqxzV+MY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x6kjNyBkmkyAsInHuER1P5sOUfn+u2m10/9gK4m8d0gjLRYI0B569eNzxqqDLFSuZ pUfFJpsgSJ2G9YmDhNrIDygUG7uP0l5x9MSTtMZSObE8d5OqUDH21GSvG4ITKTYzet 0V4KEORQl6P5yJIaZ5AjGaw9qLNF56gk30pCwzOE= Date: Tue, 22 Oct 2024 07:18:44 +0200 From: Greg Kroah-Hartman To: Yuanchu Xie Cc: Wei Liu , Rob Bradford , Theodore Ts'o , Pasha Tatashin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev, dev@lists.cloudhypervisor.org Subject: Re: [PATCH v4 1/2] virt: pvmemcontrol: control guest physical memory properties Message-ID: <2024102220-creed-darkening-aac0@gregkh> References: <20241021204849.1580384-1-yuanchu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241021204849.1580384-1-yuanchu@google.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 13D3740004 X-Stat-Signature: begn77xzwmftnsk8if77dtthb9uhc4r4 X-HE-Tag: 1729574315-643290 X-HE-Meta: U2FsdGVkX184gTg8wE9VO6XniJYYym5a6xVr3q65x1rpTOlxsYSQE38BWjIM6cLnoKWYyAXBo3Iwh7M6Jpk81izQ9P5CMMO28nUk1UsFqeLzrH4e/iWbWvKL23kcWAucOzu43zCkg8lSRFByJ9gzCVrDtAbWsp8C/r7JwSiQIbdNYUpSdV07ad7hA1tlLa3a7gNHkZQ7J3Ndw4uWp8uc9TrhPOAoxg38G0myJcborKuf1UXz/S7X43znISsOwG8eIiNnwqydLwlXuDbGlhatxRl1zL9r1SOS6Kvtao5HaG4W7jwx3wecpCg2Ba8ebmIXFvYXvXjktMBHlQb8A/h4V1znxdPyLDxvmax4Aeql1AkP1IRdOmQj9oA0bicZKTsiYG9ruLsz8NtAeU2cL6a4zcYXz7sLjqh+wQwdU0GcHhYPVQGtkX2a38UVYuLu72s3KTeXlN4+EaND4IZ1ccjj/sRHmCxF2HPlGmR1D+GB4/OW5RpXyG1W1LxqBY226T1hT+/5boujNMMSEtNsWsdpGdYj6PQd8Q8AakZRmgidlpog1Die9vgtQSrbLYEh1a6/w/zFuJLIskD42oVTQzYFf2NByN1U6nMXgTRi4SgqMNdVwyIDzjMnhscy4SCruSADhnAPQiP2amn2C4OyupsOryC+cBXw/nPjGsl3I1w7EoMasLcKUoUhmsLw5Phaw01WbogeMCnzs+WTh1vJsWO0FfpDSFHDb3I3JWHbXKjjG3fE2HjNZsl+GPzQ7lA4GJH4fJvwujv5DCdj0Syd2y/2gQm3xLG+y5dWzv1qQPQHdZba9RZcX89i4qdfRcyqTst0Y1u2coleRTsEGdICOmHKOf9nAFGcWK7+p5XcwgJcLGSllR4Ar0fvllxyzHtabzcrunmQcQYzJRKaa/064YeKuyXvdLgTmM1muDdNh0aqV1s1BJTx5tLoXL+osRg8dptP4clgP49MFsem2Eg80EX PQUjrp8s I2jZd68stx4DXoMJQC4RCnb6AFc7lKdLTeRtOq9/3afxhOWJs+wS+YZeI6z7lMUmAhCzkmVr2X2uDpVm7Un2jNZlPJPK6N/IJ1auBqsJ2w/SJdtBbqCeptkfzeiZXS9AK53UmmMt3eQEYLXgmKE/hkIwl7J98YYJbXlUTwRM0azUyYbVY7wbheys3N67EirB/w+TOEt8S5imN+GhK5yX4nupPv3ySIEGhnaGn67mRxo0ILCqMxuNTPZbTZF/LWizG31TcrF32UJRfGIq6dyvk2UvRSdvknicR3V3R7ZXcAZ0yObpZHSduAcgKcvoS6MsBSijD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 01:48:48PM -0700, Yuanchu Xie wrote: > +static DEFINE_RWLOCK(pvmemcontrol_lock); What does this lock control? > +static struct pvmemcontrol *pvmemcontrol __read_mostly; Having a single static device should not be needed, please tie this properly to the pci device that the driver core gives you. With this design, you have limited yourself to a fixed number of devices in the system at once (i.e. 1). This isn't the 1990's anymore, drivers should be able to handle any number of devices at once. thanks, greg k-h