From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yuanchu Xie <yuanchu@google.com>
Cc: Wei Liu <liuwe@microsoft.com>,
Rob Bradford <rbradford@rivosinc.com>,
Theodore Ts'o <tytso@mit.edu>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtualization@lists.linux.dev, dev@lists.cloudhypervisor.org
Subject: Re: [PATCH v4 1/2] virt: pvmemcontrol: control guest physical memory properties
Date: Tue, 22 Oct 2024 07:18:44 +0200 [thread overview]
Message-ID: <2024102220-creed-darkening-aac0@gregkh> (raw)
In-Reply-To: <20241021204849.1580384-1-yuanchu@google.com>
On Mon, Oct 21, 2024 at 01:48:48PM -0700, Yuanchu Xie wrote:
> +static DEFINE_RWLOCK(pvmemcontrol_lock);
What does this lock control?
> +static struct pvmemcontrol *pvmemcontrol __read_mostly;
Having a single static device should not be needed, please tie this
properly to the pci device that the driver core gives you. With this
design, you have limited yourself to a fixed number of devices in the
system at once (i.e. 1). This isn't the 1990's anymore, drivers should
be able to handle any number of devices at once.
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-22 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 20:48 Yuanchu Xie
2024-10-21 20:48 ` [PATCH v4 2/2] virt: pvmemcontrol: add Yuanchu and Pasha as maintainers Yuanchu Xie
2024-10-22 5:18 ` Greg Kroah-Hartman [this message]
2024-10-23 12:09 ` [PATCH v4 1/2] virt: pvmemcontrol: control guest physical memory properties kernel test robot
2024-10-23 22:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102220-creed-darkening-aac0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dev@lists.cloudhypervisor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuwe@microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=rbradford@rivosinc.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux.dev \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox