From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6929FD2CE12 for ; Tue, 22 Oct 2024 18:05:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8446B0083; Tue, 22 Oct 2024 14:05:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B688E6B0089; Tue, 22 Oct 2024 14:05:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A56ED6B008A; Tue, 22 Oct 2024 14:05:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F8A66B0083 for ; Tue, 22 Oct 2024 14:05:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3F546A93B0 for ; Tue, 22 Oct 2024 18:05:11 +0000 (UTC) X-FDA: 82702015872.04.99E013D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 8C67C8000A for ; Tue, 22 Oct 2024 18:05:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CaD5Mj/3"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729620304; a=rsa-sha256; cv=none; b=pZh/AmP2wALCYLSvYEo6WCOXsKcBrGa+KPQ9A5H8QIFT9HXbAzXKlZHgEXMqRW7Xw9iEUo k7C/VTzZo7g4ENZ54HqZRogMxFKY3AbCLn2VJfb835nCq2nkq8CMeF284VlYft5pQrt6ab kjqwIe291D60Wkzze0QbAZSWSnnGN8A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CaD5Mj/3"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729620304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G5tC0zR1GiOTgTG5BuDeqqnu0gWMhArAvnzpTsF7bj8=; b=pGmO3U4/qEoTYjfU67ASt04TqViB62opNPrxZrATeOI/U/0NJACICfW0bcLINfisS9Ibio vYG+fabu7K3TUkKMvsY7m0jdtnUpRINFq3by8WtpaKma6364trLSrOIWrXt18zx/96Jisn CtWVw4Z+1RV9xJuOQ1INqm4iyVykACY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0B7205C109D; Tue, 22 Oct 2024 18:05:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4E94C4CEC3; Tue, 22 Oct 2024 18:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729620341; bh=zUehIrhS/pCqKKuVZAbMSVBSECx9aP/5QCzvk/YzXBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CaD5Mj/3IDFq3Mqt/DTH4DEjONNSr6DIekjqWeouGJxj1lPgGogJB366pnjEFY4PT Ph5BViCvFEWPyzybHOsMLUQBQzAvgvMK2z0uj6WI+QKXsqulE0n9jOhZxRCvzRY15n a6nDyAoOenixW4u7V6vlygXeTNfaZLZMPQKKZDCcZK/jamVcu0cRQkXb7Qnx2hEANJ L1yaulqEBQkz2C+PEg1nO7EjXX7LOliTGGRYXvJMjFXyFIWK6kESBBA5m2VPO1+V8i CxvUxG+X+tGO25KPccbo+rXFVf4OaRTNtBJg92H1Wbnjvcg8h7WIpvhYAqVT/8iKt+ vIKZp36KX+5FA== From: SeongJae Park To: Zheng Yejian Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, foersleo@amazon.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, shakeel.butt@linux.dev, sieberf@amazon.com, yeweihua4@huawei.com Subject: Re: [PATCH v2 0/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region() Date: Tue, 22 Oct 2024 11:05:37 -0700 Message-Id: <20241022180537.42492-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241022083927.3592237-1-zhengyejian@huaweicloud.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 16yxet5pdujcyc7ts3z8homfpk5ewdhy X-Rspamd-Queue-Id: 8C67C8000A X-Rspamd-Server: rspam02 X-HE-Tag: 1729620311-5491 X-HE-Meta: U2FsdGVkX1/s4w9DPcMuwIEVCoeQ/6lhQ2HOwv5kslzhgybxjTwVOspv54685oO2cVjVjpBjZRL6xQlmgN+Cp0/JNTPHufQy4Dp9QWwB+04UzdlgowvHXMy+sxOPC9f9pTVqgrx2wPINax6tU8uSLjB3imdTk/LohDtmGo9/Sv6z7KE7OKxOcsFjGFPj9B8rVrmQfDzTGAW7JM9fcTIiCcXfbtQqQHfD624ltFfrNoOVq7pEDX3igX4wdJGAECQY09iql/1xvwfoVZoEg7olVSdMotS8ug8Az+BcGQpYYyOVFeNl8Kh/fVodqGO31Xp48MrhkVCJYJNc77vgTrOgRFi7MM++7YFZXu4ueDWLbxssDfazI5QDA1QHI4smy2ptC4h+tXTmQcHswbxz8x9hRByO2K8PPzpIT/h9iC0R9euwHBB36hasF/MDN/PXzINpqDZOe/2f/ntJ5lmG1OuSCSkgd0pwUdSQJRMKlZKIdxsiX93yN19ukoFaOY7pcmExZuEhi80cth/Cz0yfvUbbyuxepkQLV2ILznRfjks0I8ALyTI5ytZl1BtQI/CQAzyndeUjxepLuu4yy2b3VBNuTQxyMvuntuFjBZyQdtwvbGJQ7AQemEEc6tSSqjppoEdu34ZebXMOh5toKtL6GUogW7uuLdgupHMtIQU4Uang1jUb93/wlEGaERZwrX90hPgwMAmfGHbV01ZBK5W2jdYZmamHxKJmgFMbqcp8WGcLrIEIjdqdG3mVWQZOgzwxCDl3nAcvSFNeZ9kX3RJbo7eQpmD/Q2F114QGGxPUUbGKK5rvqHggwW8qmwUIwyYC92xQF5CJutzNirPlm7jTd4Ye2NslPNAoO9C+Md2gFL5IMMoziRqVYH/+WjTvMVdWsmWZFpXf7/7L+XFqf7GCu58ZJzLgTVEYGIpGC+zYEWKuTCTnwslokJd33SuhbJMnQ5HHFEoQ2u4FC4ohwxN2T+r hnbrD6Kr xOkAISgA0mg5PbAmr0ZTd2/jCRVfoLZsS7tTY0H4phI+6FFd/rXQf8tBqdtnWyl0T4czRe5wIRDl5NouBjDi9N1zff4j4iIIKflAKun36q8sEaREcEGfBULvJvN2QO6hQUqdC8Px6B1rkZCvqAnwKswYd4MP2lQDPgyXDqyoxmyqNt2V4JTmHRCz8XydqtxlOZT2gTXPz9P3vkgyjAa8G6HocmXEhh299nN6bJxfpaTxxTqJN5KKdQPQhEleo8Z8JMZQYgQiLmwiH+wt9ymBrOAqOsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Zheng, On Tue, 22 Oct 2024 16:39:25 +0800 Zheng Yejian wrote: [...] > To fix it, count for each piece split and make sure no more than > 'nr_pieces'. In addition, add above case into damon_test_split_evenly(). > > And add 'nr_piece == 1' check in damon_va_evenly_split_region() > for better code readability and add a corresponding kunit testcase. > > Zheng Yejian (2): > mm/damon/vaddr: Fix issue in damon_va_evenly_split_region() > mm/damon/vaddr: Check 'nr_piece == 1' case in > damon_va_evenly_split_region() > > mm/damon/tests/vaddr-kunit.h | 2 ++ > mm/damon/vaddr.c | 7 +++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) Thank you for addressing my comments and posting this new patch series. I added my Reviewed-by: tags with some trivial comments to the patches. Btw, at least on DAMON mailing list, we usually post new revisions as new threads, rather than as a reply to the previous revision. If you want to make sure involved people aware of the new series, you can send the lore link for the new series as a reply to the previous revision. Thanks, SJ