From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E890D2CE12 for ; Tue, 22 Oct 2024 17:57:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98DA36B008A; Tue, 22 Oct 2024 13:57:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93DEF6B0092; Tue, 22 Oct 2024 13:57:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 805EE6B0095; Tue, 22 Oct 2024 13:57:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F45D6B008A for ; Tue, 22 Oct 2024 13:57:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 634DF1A0368 for ; Tue, 22 Oct 2024 17:56:54 +0000 (UTC) X-FDA: 82701994746.24.ED29B11 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id E1D4240010 for ; Tue, 22 Oct 2024 17:57:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="n/IO+82w"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729619641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5wc1jqqM/vLMrP/yZONbNistnP32ekKwjuQLkuInyWs=; b=ZZscOLlMbsvz13ckuILglIMkw7OMg0LbVdtZVkUoF610fXIJPf6+E4YO8yBJeJKkqMLVFC +6+IvoFx8OebbhJqqxMjrPOgRayNgI6rtzwd9j/zAjZP8iqNU0p1w2CulUxGWflhsvqmV/ pgHcRZkePxvBypK+A2B9Zg/0nfTggRs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="n/IO+82w"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729619641; a=rsa-sha256; cv=none; b=y9jjX5n2LTZZ6IIMqEQr9FEE/9CGqCml7KIL50fa3rb0Kvu7mfmF6GmjQiG1BME0HwLajV cJ6bsK4nlnkvlYL50UpaXIGvKm01dgST9UqFPRelBKSRiFMSdKjueuM5HORJlBqlOcyGvO 2EeyRrAl+wDXm342Wpq55PBmbUd7Oi4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 01DB35C5DBF; Tue, 22 Oct 2024 17:57:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B3B3C4CEE4; Tue, 22 Oct 2024 17:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729619841; bh=fVSacvrMFuJP0Mfs887XpqYZFDZCM7QwCNWKBhVKDyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n/IO+82wcF+7WjQjZo43qz6iQuJ7/l7lssH3ngnLRAbM16XmFLGwgAJbX2fwyR5et Aypp50txByq15SbbQ3tWpLQlCgWVdjJn+2/8+qkEPQBKXPCRukiX73hLRhRV0Hgnwe BzUeU5X1aXXUzrXRcSZXRFtYY+JVgDnriW/a0Ep1xCadvJ1n14X3spH4+f65YygJJt SnTzdNqGUqmwpkhGqaaXFgnZypasiJFSZOgJ17hQ4hdfacTUhKv0G2cNOFRsmmfINd Fkhmkarf1tHFtaTmZb4x/W7UKTkClRB/O99To1fW77d2i4gbtY70lCQKuZ7d/qTAjF WqW2T2KZAzZ8w== From: SeongJae Park To: Zheng Yejian Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, foersleo@amazon.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, shakeel.butt@linux.dev, sieberf@amazon.com, yeweihua4@huawei.com, brendanhiggins@google.com, davidgow@google.com, rmoar@google.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check in damon_va_evenly_split_region() Date: Tue, 22 Oct 2024 10:57:10 -0700 Message-Id: <20241022175710.42308-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241022083927.3592237-3-zhengyejian@huaweicloud.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E1D4240010 X-Stat-Signature: e61oxbds3ywofrbfxd1gi3x8obwbcnbd X-Rspam-User: X-HE-Tag: 1729619834-742592 X-HE-Meta: U2FsdGVkX19+coAVlLk4rjwg+7L6KBx/RM5uMhIUzx/22C7YVzJwSEgZTdwVsea0kTGn9ejRxS/hYOrL05edyhz4I3Scs7pVuRfz6LasuktvRegntnQjpdP+jLOCGq/wYFG7MXG3yQn8LQR7ttjr38tasiHMH6EwD0boWlDwZXNL/AP/C9ZWbPiJYzkJkClC+7XPCrT6xnvjWErEHKBlHgqf/55n72Hdmj4+/uIt8slQdbwLqW0TvJOmQPpQwyXYHmKN+X4vgIU+eSrVc3t9zMQ0GfnvHwijuRTo3tVuYEpTUVsPT7YqaQWt2dwOWdleQWq8XuDkRDPoWDQFwJgswVeFwqOvuqssX4vvmmGc/MYDdwrKCbU898ZxwBweXq0mtw+bAuB5CNP8gjJNqMiWV9BAqQ1bk7Wq31kccArBAcwM+2aRfQyyKrblh9t0aR7w4iiSvkqxWWsM9C5wNDTATNXsKuI3xVpmyB+rVC71Mb0oaAbSnhc8AeB+NvhMVQA81QHDQs2yhungnJnXK4lYlEX/XnB2KmRuzNFiBRH0u7v5rhQ0f1NKT6wI3EVC5cbqtcX0/2MX0IN7BNosRt6wOhDAO37vxrhKZcA8ZYt5V29p3GZ7WPoiYZAe+826tR4kdeSzTuOCIlhCNZqQNavcXF+nV3ZPV0HLPpguErFAaVO7EejsX88J+qc9p52hSoldCZ5WW14UCyfx+pE9h4Uei4F1HtdBUTWoBJAaBiaYeoEQrlNXv/1fbYEIKu8BUq5TkfxlHApxPKkTJh8AdD05nOSPb0ln/kpCH+J95LVsQlUnBvrRDV8v1BnRyDIpm3Ya+EIXivQGcCfPpHpXKovG7LUR5Nh6QPngVWETQwKyXWXREoe/joouIqHKaw6M9RG2cFOy/UzdlzFgNnDx1/yZ88InkxL6DLwfTLxEJUtKXrqKholGY79Hs7qtzjtGPlLOcTFCrnK8J1GkAo/DzlH gxJB4OWX n7DYVeeiIUAbZbTYmm9JYGvPxphuGiELGQ5pK/hPelzifenMAL/WcS/WT5D0HVHsEqFiAUIbJTOCBh3Q1nysxDMebKLtFppclicEV+y3MXRLkpd3XbdxseK2CXISb3+Bo+wASawN1DnYLCc864+hm071fIcJRKq7p+RzuF7E3s6YoeSK83VM1CSz9AQCM/jlIbDLWPUetgek0a5MTxiAGxe5qJmymtTmkBLOlER77aH8GJgO1ATxuYrXe5RzO+6umyIhZDpKC7U+nN9gvpoiq+Y/CowMix1tFE6TYvVDx94BwuINLOnMMRbHcaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Zheng, Cc-ed kunit folks, as we usually do for DAMON kunit test changes. On Tue, 22 Oct 2024 16:39:27 +0800 Zheng Yejian wrote: > As discussed in [1], damon_va_evenly_split_region() is called to > size-evenly split a region into 'nr_pieces' small regions, > when nr_pieces == 1, no actual split is required. Check that case > for better code readability and add a simple kunit testcase. > > [1] https://lore.kernel.org/all/20241021163316.12443-1-sj@kernel.org/ > > Signed-off-by: Zheng Yejian Reviewed-by: SeongJae Park Thanks, SJ [...]