From: Zheng Yejian <zhengyejian@huaweicloud.com>
To: sj@kernel.org
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
foersleo@amazon.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, shakeel.butt@linux.dev, sieberf@amazon.com,
yeweihua4@huawei.com, zhengyejian@huaweicloud.com
Subject: [PATCH v2 0/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()
Date: Tue, 22 Oct 2024 16:39:25 +0800 [thread overview]
Message-ID: <20241022083927.3592237-1-zhengyejian@huaweicloud.com> (raw)
In-Reply-To: <20241021163316.12443-1-sj@kernel.org>
According to the logic of damon_va_evenly_split_region(), currently
following split case would not meet the expectation:
Suppose DAMON_MIN_REGION=0x1000,
Case: Split [0x0, 0x3000) into 2 pieces, then the result would be
acutually 3 regions:
[0x0, 0x1000), [0x1000, 0x2000), [0x2000, 0x3000)
but NOT the expected 2 regions:
[0x0, 0x1000), [0x1000, 0x3000) !!!
The root cause is that when calculating size of each split piece in
damon_va_evenly_split_region():
`sz_piece = ALIGN_DOWN(sz_orig / nr_pieces, DAMON_MIN_REGION);`
both the dividing and the ALIGN_DOWN may cause loss of precision,
then each time split one piece of size 'sz_piece' from origin 'start' to
'end' would cause more pieces are split out than expected!!!
To fix it, count for each piece split and make sure no more than
'nr_pieces'. In addition, add above case into damon_test_split_evenly().
And add 'nr_piece == 1' check in damon_va_evenly_split_region()
for better code readability and add a corresponding kunit testcase.
Zheng Yejian (2):
mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()
mm/damon/vaddr: Check 'nr_piece == 1' case in
damon_va_evenly_split_region()
mm/damon/tests/vaddr-kunit.h | 2 ++
mm/damon/vaddr.c | 7 +++++--
2 files changed, 7 insertions(+), 2 deletions(-)
--
2.25.1
next prev parent reply other threads:[~2024-10-22 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 3:53 [PATCH] " Zheng Yejian
2024-10-18 18:33 ` SeongJae Park
2024-10-21 3:56 ` Zheng Yejian
2024-10-21 16:33 ` SeongJae Park
2024-10-22 8:39 ` Zheng Yejian [this message]
2024-10-22 8:39 ` [PATCH v2 1/2] " Zheng Yejian
2024-10-22 17:54 ` SeongJae Park
2024-10-22 18:00 ` SeongJae Park
2024-10-22 8:39 ` [PATCH v2 2/2] mm/damon/vaddr: Add 'nr_piece == 1' check " Zheng Yejian
2024-10-22 17:57 ` SeongJae Park
2024-10-22 18:05 ` [PATCH v2 0/2] mm/damon/vaddr: Fix issue " SeongJae Park
2024-10-23 1:27 ` Zheng Yejian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022083927.3592237-1-zhengyejian@huaweicloud.com \
--to=zhengyejian@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=foersleo@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
--cc=sieberf@amazon.com \
--cc=sj@kernel.org \
--cc=yeweihua4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox