From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BD8D3C934 for ; Mon, 21 Oct 2024 01:30:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 111EA6B007B; Sun, 20 Oct 2024 21:30:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2B26B0082; Sun, 20 Oct 2024 21:30:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA4456B0083; Sun, 20 Oct 2024 21:30:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C5F7B6B007B for ; Sun, 20 Oct 2024 21:30:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1F299AC9EC for ; Mon, 21 Oct 2024 01:30:24 +0000 (UTC) X-FDA: 82695879966.30.EF4E047 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf16.hostedemail.com (Postfix) with ESMTP id 58B8618000D for ; Mon, 21 Oct 2024 01:30:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PhxPE2b6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729474215; a=rsa-sha256; cv=none; b=3o3RRpS5ZX3Cll9wtp4506RsEceKkqD//7+UBtz+CwGhTn7UTZZ1TATPorX/yoCcvW3J00 Dfvv/iNpYTBbQVvTwjFNf7yaPmvM2J9gjcvdsrWudbZcqrvS55Jh/5EciaQBZOQddHPglS tDXWKXWN+DLVyI4Ezf19vNeEObdwfuE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PhxPE2b6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729474215; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EiI8qtD7K/KJBh2i8o7Jx408hHKoX8T5aynYQ/22lNA=; b=is9YRO+dBpqNal5gw2PZRsgi0BzTKRDrbbRG8vRgDXwSs+LpiH19kQOTbhQATBYc6KEPgU JWT5+cie6ZB7o7OBNeTpZ/IcYc7UP0kv9luovR/gFBOWIhOD32TazrE2Ad2JqfOZdnRGWb //qfJZT7mJVqshJj5pIctz+J/npm8yE= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a99e3b3a411so798092066b.0 for ; Sun, 20 Oct 2024 18:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729474250; x=1730079050; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EiI8qtD7K/KJBh2i8o7Jx408hHKoX8T5aynYQ/22lNA=; b=PhxPE2b6gRLVFxnb8HRXBFxotoSZLb0ogCbFTsGOZN5l9Ne0InYiZIt+RYiBpSTHwg p7+isgGVur9qwuYJUU3Egko8gbahU7i68cV7BMbIP0ShZVwiCP/xiTh/a82KWheMjvGy q/bFL/juORq7aPTgPc3enz67m7HU3IDq0NMO0Gi4yHXbQcftH4ScquUb9cpzsUi9rCiI Z5/VPb4rpb+qyieIYnsoS3Kl9d/sXEVZa5dG6g/hmQkO4wRmDJIFD01TTf7YzYjEZmVr DPxfO77jvuqYKIQ3Zt2tUYZZ4j3X9sGrmX/nT2TuSWAwwsqwdqdXwUnQ/Qb77vGxS1lk GRiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729474250; x=1730079050; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EiI8qtD7K/KJBh2i8o7Jx408hHKoX8T5aynYQ/22lNA=; b=Ffj0xC3jIcoCWmkmgqGrKEvbdgsyIwbDOF7TiOA99L970G5XZte2W19Uz7K7dd69UW zYIwnBL4vw4ofEQhP2D7FROPlw8Nqhu3XCgveDhrU78mKrTZFO7Bi4yRkqOcZpueuduy FQs0QW3D+X2hjbO9RbEHkRKS2LavFlaxqUqWijba/btlT0qHVOR0/cxz7Y42Vymob8wT Q46GqjPzy3SQPUlCTesmRfIFKCy2P5BqumJ1ndctlfWFjiarj2miCD8eL25WXOTDx2Jv zAKMa0BVAA9PqWABt7oE06HPel+/1fOL2N/7qzmRO49gFrQoWKiWgMzUs+dGu24sttmJ 0Buw== X-Forwarded-Encrypted: i=1; AJvYcCXlUZShXK9gmIjr6MUyG7TkibiX5mqr/BE/3Hrtj+vARr+yFQbYnk4bNWWeBI8xNHF7u7d6Yk1tpw==@kvack.org X-Gm-Message-State: AOJu0YzfDWObb4c9MxKnKlPiSKcaZhzK+vjt5hi1+z7TWdrqu9VFWL4Q XGZEeUE0zI+W2mx6AsvP1iXqbT0IoKEgQy0pUuc+/1xz4JvaWp74 X-Google-Smtp-Source: AGHT+IFXpEgKXAALe6hmF30nqQVEfGKoavupSupmdNR8oqLFIav8iY2uVj8QllhlUoXoRrV6NAWU2g== X-Received: by 2002:a17:907:6d22:b0:a9a:cf0:8fd4 with SMTP id a640c23a62f3a-a9a6a44c92emr1077638666b.18.1729474249489; Sun, 20 Oct 2024 18:30:49 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912d838csm145329966b.8.2024.10.20.18.30.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Oct 2024 18:30:48 -0700 (PDT) Date: Mon, 21 Oct 2024 01:30:47 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/4] maple_tree: current split may result in deficient node Message-ID: <20241021013047.hzup4wwifugrsn3g@master> Reply-To: Wei Yang References: <20241020024628.22469-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Stat-Signature: qay1s1tjd3wbdzpdr6jrnqks138zgo39 X-Rspamd-Queue-Id: 58B8618000D X-Rspamd-Server: rspam02 X-HE-Tag: 1729474237-859592 X-HE-Meta: U2FsdGVkX1/OuMpmEyZimmqFl2rdLvtX8zhopje/NUY7wOjyJdcP4B4TA0vEM79hlyb1Lz02WRCfTr5sFEIQfoXPUBICD0OkuAQx1oNzojBwiYO8fBxyEJXS0ZnzFVhAeT2z8BqQLfHOuq0IGgV1HAA9qR0We8eePJMHriZM2sGkSZ8HAuvA8I6nDnrolaOMa2pbxNU2yTeRdvlGLmDBZouhFCp3zupACO7omuCCYlkeVV8ZFIsGcDfxtg+0WAvwDZj4ANTUVXbRGAnOKKPK8YZiFkFFo8D43KvAyIlujk8B7LrN8r01bz6KHE/Anz8IqyP4Jv4JC9VUmoHl5DGIrUGJi543i9/Gvu2a+m68v6rW3aWJ+qBB876rSZvzCWf6rPDJTiimK2ULkIegge96ub9n6NE1LrIX5jiEGcBD0goWtJQsrwFEkYFA8SBpOWCqydaVgUcPxz55t2np/YsbpftqZ4G9pewBe/aghBDq1Rh6OEfrrCKdQRksZ+JMXBJScsaG7OzH8qKqa7R3AV/fB6zaazcsdrZpCY6c/pKmpl6+gxWSBB4HolhiPmuT2WR0lOcjkmyP/EPe9cX/+gXk7kJu++ZTRyCkotmQqkxTa7vAOYi7DYt058ICkkQjpTicJr+z7Zu4C+Es/ZKiq/j02fPQ2IoCMjWk1GLmRDYFwU/LlFkGH3fM/dsg4xfGxwG2IviOoRaTKbhXsxDstEkSEIOFKPzyjR291jq6eWSLyGn0D1lswdP0F+B6eFkBEaP0jIWyfIlmKnNZ6J+CR35TqTm2K5/GjwqpdaUTeSMeNWTxEr5MoOjvyTwBr9U/guiA1n4w8H/JJEU7Zr+Yh3KCPU0It7Vsi58cO6b6mREyHxTGjm3e16Rmk+RFM05JO94/mlHmxn4CDxTm8d+XOhtzm0aqEiglsE/jDiTYTflKGLbrHbjAjDF4Tsl6T5Nal+Rc6BGHoaYijstlVQ+Ryht mRmAIj3u YiUsM2J9zInGnMMBBUuB2tY1PIJmUnc50s/3+CfT/aKs9KQ/B9gDAWzxpZzmSC7OsT0k2ynSkvgXDMPO1anoEJNFMsv0ed9hKa4g2Y2YaNw9qqO7ATHu6b02+FFyTK5UUH8E7BZY10lQTo1F7n/dSS7Dhn+C2Yqo2r9wgTRFitVOGf1ULv5/f9cJcY6cybff8IqW94qTDkIxa5St3qvwjkpQZj0GrIlFDBL7fkeGlxuIp7HgpbN9t7chGsTk5uvKaei8SNzJIS0kOkcmORiAj0T9L4+TDCM7t50GhJ6d+WIsSE/gJFlsABU/gGMha7ttlId2PJO+FQ7YU30jb4tHR64afNmBt7xnJ4mY5DyxfryBoSGjRvLBZN1t2M74fPbFLtigCMnsgsIegCA4LgaA1rqNCWcCCnjc2YNp8ZxSU6nEDfXqt6dQYVxsn4MEeFK5jsO6Zu3kbZOKXDvurDntD6JIuuyYxjp7pfwVevVRDA9HpQxIfITSCFUyrxbDiYUej/Dq6cR0Diqyg7vy4HFgV/xxIFj26g+c7GWKpvq4rIdaSRH3NfVwSfz1xToPwYl57GUDhyMIKjaLi7r/LLyQ1QbpNW13UJhl16c2LPw6vgEzvIWry+JqqRBufatPgWo75pfh0hb/P70hfpkj2QKTlBx8dL8NzB9rTbegq2v9XV4Nf4etpWfkBjPEW7pcuQpTPtJML X-Bogosity: Ham, tests=bogofilter, spamicity=0.007077, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 20, 2024 at 04:34:03PM -0400, Liam R. Howlett wrote: >* Wei Yang [241019 22:46]: >> Here are 4 patches related to correctly split node. > >So I haven't worked through your last bunch of patches and I had not >fully responded to v3 before v4 came out. > Sorry, I thought you have finished v3. I will check with you in later work. >These things take time to go through because you are changing fiddly >things that may break things or cause regressions, but you keep sending >a new series while another is in flight. > Thanks for you time on reviewing these. This really took efforts. I will keep those in turn later. Is this what you preferred? >> >> Patch 1: adjust the calculation of split > >Split calculations exist with +/-1 to avoid jitter, but I will have to >look at this in minute detail. > >If you screw this up, then we may lose data. > >> Patch 2: add a test case to check deficient split >> Patch 3: the min value for mab_calc_split() seems not correct >> Patch 4: during validation, we skip right most node on each level >> >> Wei Yang (4): >> maple_tree: current split may result in deficient node >> maple_tree: add a test check deficient node >> maple_tree: use the correct min to calculate split >> maple_tree: only root node could be deficient >> >> lib/maple_tree.c | 8 ++++---- >> lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 32 insertions(+), 4 deletions(-) >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me