From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 220B3D3C92A for ; Sun, 20 Oct 2024 09:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C4646B0082; Sun, 20 Oct 2024 05:21:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94D0A6B0083; Sun, 20 Oct 2024 05:21:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ED8A6B0088; Sun, 20 Oct 2024 05:21:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5BB046B0082 for ; Sun, 20 Oct 2024 05:21:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 23DC9AC7E5 for ; Sun, 20 Oct 2024 09:21:15 +0000 (UTC) X-FDA: 82693437666.30.753E982 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf12.hostedemail.com (Postfix) with ESMTP id 8254840003 for ; Sun, 20 Oct 2024 09:21:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=enddFSO+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729415937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wtrLF+/AuIPa3HQbHlIvRoVxFltlw07b62yZbJyC3Sc=; b=o/4kYPqip7m/7dh9y3YByBk1jrckMVWABfkcPHGkZRSWzOKTIwLPYo6tSAcuK7jW0QpGx1 GIH/T5A5+ADqIf2W3c+++6AULqWgrJXKiBv9J+Obf5TKUjyqfFTO90LumWO7cI+QBldcng zAqjn+nnAuYJ6SlaAd9uXV6pI5mrB+c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729415937; a=rsa-sha256; cv=none; b=p2VpQzKLAiziJQMdEgAF86HuDLUtuwXtSP8GWHuAmZKkpssIkvAqZikskDtLp9fNXisnj3 E3i7wHKRHHTY+VJ5leGs4cpeFV9oSx+xlKo9RhCH/587whOGvxLpwmhe+hfO6S4SpYR9sp tbJgCkQ2lpcxo1wznrEAUNIhWD47plE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=enddFSO+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729416101; x=1760952101; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0FjaOJikJqwtGL+Y9iaV7osiQQ6qFUvD/z2eON8YtPE=; b=enddFSO+iDAKiYYJ1/Hd2IVeyRG2bpmUMqSKKnnm9iUHxR83aalLZI5H cspVYi2R/IEhpA1RaaVcWdeSf5MqNmxOXoy11qalTsv3hfAuvn8K3gfek tjtLO0wAZ9S5E8YPK4u67+o+XdmEUmuPKHH3mkqHCbhVN9SBOVMoavhG0 wiTbC9efSsHX5HSM8g1z2gK9Cq07/peRFQGZHbaRstXMqPLQFWX7CTaSL d4OsfXxejaXFufcRPpJf4FpMG9l73zJt/w4aIpmcThkMyrD5AGCZpN6Rw JWmgpBOjSp626BFoQkUnO+iRlbCm3jgwk3OR1UKWgIjDse0lb1RxNojJE Q==; X-CSE-ConnectionGUID: g6BE07yhRe62mxlp6kgqeQ== X-CSE-MsgGUID: y1CbUohOSdS9RZ5Pee8mcw== X-IronPort-AV: E=McAfee;i="6700,10204,11230"; a="39528709" X-IronPort-AV: E=Sophos;i="6.11,218,1725346800"; d="scan'208";a="39528709" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2024 02:21:36 -0700 X-CSE-ConnectionGUID: S96oavzKT2aa8bDdJHdbug== X-CSE-MsgGUID: ISIQzx7HTDKxdHRiAqcjcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,218,1725346800"; d="scan'208";a="79183515" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa009.jf.intel.com with ESMTP; 20 Oct 2024 02:21:30 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t2S7r-000Q9C-2Q; Sun, 20 Oct 2024 09:21:27 +0000 Date: Sun, 20 Oct 2024 17:20:40 +0800 From: kernel test robot To: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, sroettger@google.com, pedro.falcato@gmail.com, linux-hardening@vger.kernel.org, willy@infradead.org, gregkh@linuxfoundation.org, deraadt@openbsd.org, surenb@google.com, merimus@google.com, rdunlap@infradead.org, Jeff Xu , stable@vger.kernel.org Subject: Re: [PATCH v1 1/2] mseal: Two fixes for madvise(MADV_DONTNEED) when sealed Message-ID: <202410201724.kKCsANsw-lkp@intel.com> References: <20241017005105.3047458-2-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017005105.3047458-2-jeffxu@chromium.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8254840003 X-Stat-Signature: 5m1qbrtw3eobmtna5awhu9wd1uz797pz X-Rspam-User: X-HE-Tag: 1729416094-306677 X-HE-Meta: U2FsdGVkX18GFnbb448KlxC47JhOt1YsxBDP/sSgEIEeXDJhi7kIPb7C3SgJPHDHX9QYLbDeEqQ1q9TVdFC9K/8VtHTXAvf7AQBD6YtaHDHXJOjQwcXPOLF0xiAYlChdZ6eYTeA31v60VkAADTKhXNPiN+4Zr5ga0Oml1fqFTiBK3hPK4tuGwO5c/PUCKIfizsqsZZMxnvlp4aRQHXpIts2R5FSrZFfYsF2BvLNrlReLqBVefmhVjdK9418FXaGlmFFcn55xjRNWxZdRY2vmSk7FzlIscZeyUJ5e0cbd4cMyv274MZhmM2FYUET29fk5GrnRTyClitE3JdZgUeqsxl62iVKU5fWeEe/8PJXsFyHyS5Ura7u7mSkCCG7ZUzpcjSEhFW+Q6fPBV/mWG8t7OKOjoL5O9c/cq2FaF/fU0tA503pYVJ75qW0Ynhshe/QfgVbdhvb4jeaPv0ePacq/nd+xxfqbDENOoqfe6fSnqka15Qba99MViuxR4ux/HzRbQmjwx45MdXaJzBs+/FzPzLryn5One3UlMz3vb428eSGI/XgVfWwEleK8qIvYt7jR+06vuMJybA9PCV9NN2t8BvM8LCLiNkmp/IteTTt9Vkf3LWpa1TKu3dQv9iuqveqV9pq92vZ4Og2HK+2I4WqD1feNDxFe4SrkLKJdaKnZ0Jft1aNXXjMprJ5jPH1Vt1moCg/OwrMm1sMZvtZ4CJuIHhdiK/mP7etByxWOFo88xEbO/2asiS/j7hukcwM7fiHjJcjJu1hIPjJHnKBip3ZnPoBgRwDudGEq1u3bzxxENU0xmPEiaRSOJ6WKV33eKyUYV+SlfjMupGg8OXKfT8hn7ZoRbDvOid8rOUiGrC6RW4w/a7Ig/QDeO+rBCX97m6527S7/nug+HLLGLu5VIsFwGgyKEeJ0CW1yUh+ebMl0/9kHaQRRRnBzpRA8K2m6lqQj1fQvse6cS4gf5hgCTIx txKeSAbd oHlqp+EFbP/pcih4v6YJGY3is4buppJU8CYTaOFqaMfFUPqHzIhPWZD0MaVEJK7PfFuO3Ct9PL5ptP7IUFRedGdPA9Ge6H8CpbnSoukpw32yq3xl/+yeNJoVBozCrSzt3PxkG1Cl3zcf7AUgFfmZsR98MFMs7e8rFHN2LrgjWc9oNbLK8WQsXrdUAL+7uuiYax5IbLB7JPlRPPr86DTLgkOaXmElk7uHsF2BJVcf+7SwJaOqUiiiyC+phjb2iKH2whXghHBolBAIurcdiasM4jwaAQUHJQ+XZGi+Z1bVBQad7CoD1Fair4gqeNdnDkTaqT5FEttpFJDNUdC9jPKaa27by4kBt6Q9Az8GAgPP+VzDZYM8nOtk5dvZA0TqccYhZOSPfP1jCVOJxiI+AUuxLm/Pu9qCXP8N3jPFm6Mwm1Ywciq4h9+Y/RIeCEfrW7zTWQZkdVwRUINvraAT5xgYFhX014fxJnup7RxuToJ7yhfi5CmjeXtvWxoSIwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.12-rc3 next-20241018] [cannot apply to kees/for-next/pstore kees/for-next/kspp linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/jeffxu-chromium-org/mseal-Two-fixes-for-madvise-MADV_DONTNEED-when-sealed/20241017-085203 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20241017005105.3047458-2-jeffxu%40chromium.org patch subject: [PATCH v1 1/2] mseal: Two fixes for madvise(MADV_DONTNEED) when sealed config: i386-defconfig (https://download.01.org/0day-ci/archive/20241020/202410201724.kKCsANsw-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241020/202410201724.kKCsANsw-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410201724.kKCsANsw-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/mprotect.c:825:16: error: use of undeclared identifier 'VM_WASWRITE' 825 | newflags |= VM_WASWRITE; | ^ 1 error generated. vim +/VM_WASWRITE +825 mm/mprotect.c 705 706 /* 707 * pkey==-1 when doing a legacy mprotect() 708 */ 709 static int do_mprotect_pkey(unsigned long start, size_t len, 710 unsigned long prot, int pkey) 711 { 712 unsigned long nstart, end, tmp, reqprot; 713 struct vm_area_struct *vma, *prev; 714 int error; 715 const int grows = prot & (PROT_GROWSDOWN|PROT_GROWSUP); 716 const bool rier = (current->personality & READ_IMPLIES_EXEC) && 717 (prot & PROT_READ); 718 struct mmu_gather tlb; 719 struct vma_iterator vmi; 720 721 start = untagged_addr(start); 722 723 prot &= ~(PROT_GROWSDOWN|PROT_GROWSUP); 724 if (grows == (PROT_GROWSDOWN|PROT_GROWSUP)) /* can't be both */ 725 return -EINVAL; 726 727 if (start & ~PAGE_MASK) 728 return -EINVAL; 729 if (!len) 730 return 0; 731 len = PAGE_ALIGN(len); 732 end = start + len; 733 if (end <= start) 734 return -ENOMEM; 735 if (!arch_validate_prot(prot, start)) 736 return -EINVAL; 737 738 reqprot = prot; 739 740 if (mmap_write_lock_killable(current->mm)) 741 return -EINTR; 742 743 /* 744 * If userspace did not allocate the pkey, do not let 745 * them use it here. 746 */ 747 error = -EINVAL; 748 if ((pkey != -1) && !mm_pkey_is_allocated(current->mm, pkey)) 749 goto out; 750 751 vma_iter_init(&vmi, current->mm, start); 752 vma = vma_find(&vmi, end); 753 error = -ENOMEM; 754 if (!vma) 755 goto out; 756 757 if (unlikely(grows & PROT_GROWSDOWN)) { 758 if (vma->vm_start >= end) 759 goto out; 760 start = vma->vm_start; 761 error = -EINVAL; 762 if (!(vma->vm_flags & VM_GROWSDOWN)) 763 goto out; 764 } else { 765 if (vma->vm_start > start) 766 goto out; 767 if (unlikely(grows & PROT_GROWSUP)) { 768 end = vma->vm_end; 769 error = -EINVAL; 770 if (!(vma->vm_flags & VM_GROWSUP)) 771 goto out; 772 } 773 } 774 775 prev = vma_prev(&vmi); 776 if (start > vma->vm_start) 777 prev = vma; 778 779 tlb_gather_mmu(&tlb, current->mm); 780 nstart = start; 781 tmp = vma->vm_start; 782 for_each_vma_range(vmi, vma, end) { 783 unsigned long mask_off_old_flags; 784 unsigned long newflags; 785 int new_vma_pkey; 786 787 if (vma->vm_start != tmp) { 788 error = -ENOMEM; 789 break; 790 } 791 792 /* Does the application expect PROT_READ to imply PROT_EXEC */ 793 if (rier && (vma->vm_flags & VM_MAYEXEC)) 794 prot |= PROT_EXEC; 795 796 /* 797 * Each mprotect() call explicitly passes r/w/x permissions. 798 * If a permission is not passed to mprotect(), it must be 799 * cleared from the VMA. 800 */ 801 mask_off_old_flags = VM_ACCESS_FLAGS | VM_FLAGS_CLEAR; 802 803 new_vma_pkey = arch_override_mprotect_pkey(vma, prot, pkey); 804 newflags = calc_vm_prot_bits(prot, new_vma_pkey); 805 newflags |= (vma->vm_flags & ~mask_off_old_flags); 806 807 /* newflags >> 4 shift VM_MAY% in place of VM_% */ 808 if ((newflags & ~(newflags >> 4)) & VM_ACCESS_FLAGS) { 809 error = -EACCES; 810 break; 811 } 812 813 if (map_deny_write_exec(vma, newflags)) { 814 error = -EACCES; 815 break; 816 } 817 818 /* Allow architectures to sanity-check the new flags */ 819 if (!arch_validate_flags(newflags)) { 820 error = -EINVAL; 821 break; 822 } 823 824 if ((vma->vm_flags & VM_WRITE) && !(newflags & VM_WRITE)) > 825 newflags |= VM_WASWRITE; 826 827 error = security_file_mprotect(vma, reqprot, prot); 828 if (error) 829 break; 830 831 tmp = vma->vm_end; 832 if (tmp > end) 833 tmp = end; 834 835 if (vma->vm_ops && vma->vm_ops->mprotect) { 836 error = vma->vm_ops->mprotect(vma, nstart, tmp, newflags); 837 if (error) 838 break; 839 } 840 841 error = mprotect_fixup(&vmi, &tlb, vma, &prev, nstart, tmp, newflags); 842 if (error) 843 break; 844 845 tmp = vma_iter_end(&vmi); 846 nstart = tmp; 847 prot = reqprot; 848 } 849 tlb_finish_mmu(&tlb); 850 851 if (!error && tmp < end) 852 error = -ENOMEM; 853 854 out: 855 mmap_write_unlock(current->mm); 856 return error; 857 } 858 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki