From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846A8D3E1AC for ; Sat, 19 Oct 2024 02:42:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 026286B00AC; Fri, 18 Oct 2024 22:42:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F174A6B00AD; Fri, 18 Oct 2024 22:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB7C36B00AE; Fri, 18 Oct 2024 22:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B3B726B00AC for ; Fri, 18 Oct 2024 22:42:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 68597AB645 for ; Sat, 19 Oct 2024 02:41:46 +0000 (UTC) X-FDA: 82688802252.18.E3B9673 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf12.hostedemail.com (Postfix) with ESMTP id EC00F4000E for ; Sat, 19 Oct 2024 02:42:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NHlz4iK8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729305621; a=rsa-sha256; cv=none; b=ER6S2oPU0fCPUb3PY+GCD1ksDBxI7cLm3mjj7nXj4H1YibDkw3Je1Rvuev7fh1f86lHQau VsmAoU+ldn2RL13EhyzSPjBSgq6kjwalYRc8emCGyHnv10IoWE9Oy77rGVxMUEWoq/tA3z YJPWPq4RkRkJQUIJlItUTbKa9JSAxwQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NHlz4iK8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729305621; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=djUAEaXzLv5zGMYl4UYhQ2521SQReszstG9N/VSb7nA=; b=E1RQifDdtuJ6YNbvxIYyfQnlkYi580ivN1duM5C9Pln8uCCO8bWl9xpNjEIhH4JBR9Wv+9 yc2hV5SVHdUDtO4nda97jgZi1A7zVxdc2JXwKKRSzjppLbyQQ84IdN/VswaQCT84670dKt ftZJFCsiDGnIibtGtOhiHhRU3P+vx10= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9a68480164so157061666b.3 for ; Fri, 18 Oct 2024 19:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729305728; x=1729910528; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=djUAEaXzLv5zGMYl4UYhQ2521SQReszstG9N/VSb7nA=; b=NHlz4iK8RoiY+8d1TzcWtH8CV/lLm74xBUCidcYGL1pWysTiziE6+pkU8YHvwZbnpp TsvSZTR9fkZOaN6AYO8o3XVhbn7RFHbODWXMRPkMGczZ3jmRh455zqTA+B9H0nPhRN06 ySHp5LXcx2PZGpMiTtw8r4GSjDaqPjKKJbiuG/tK7PG8oYMthqHu2BPYyY7NyIRqghC5 XIBKD5w43maH3OF6ciJMpDAL06dn9bQGJrZwC0JwCx2OcTsQo2E7DImXRWAt5SqhYVXr 8lDQRr3ni7uyI5RpeoQ4aNwaj1aPp3FUVah+QwE56IJf6aUJDXZh3/2H8sQytzUrPjJL W1Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729305728; x=1729910528; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=djUAEaXzLv5zGMYl4UYhQ2521SQReszstG9N/VSb7nA=; b=pi/lbrphsYwvmppgB6lni84CkNDahbSkLqsp8N6EVQMmvvjiw+5FraShh4+FCC0lMG OF3s0LOLEAC7WUipymKcQe4pc8RkkRSOMHFPN2TkZYRVQxrE0IOnPIzCX/apvw4KMWeX YfMp6QEiW8fk1u/z7qTzvMl0zBqJEq5umH9Pq93Cwr9d1tgmYXTsKX/qtE+mE6cDgbIn iQWTEfzh9w5y2bJJPNpLfjZBmf1sG8x3w6JVwl3L/c8snW07mRhCvCvZP2RWjacan69C 4O6bKlEqVZlVcjXMqD0RFDY10rUYjNNgyQI08oExlhTNBIbZfFRa1DHRilROSsPcrL2P xUaQ== X-Forwarded-Encrypted: i=1; AJvYcCX4rn1iNzs0ariNkUCrinTBHN250gKeen+inmczJ28sSNHMDZcCRetRBeyViouEZUh9IjRN7mmPwA==@kvack.org X-Gm-Message-State: AOJu0Yz1teCqoN2hk4Fo9NCTHF4x8XWzVIVXchjNMGLjg+jdqN7w9hcF so08HR9kwNEFMmlIZbwlNTb0B46yV477IIPbn25LpZVSDm6OL7xfXgKRm5FQ X-Google-Smtp-Source: AGHT+IGK9GYxiCD/SqxwHHysXuk6s4NoiJp1IOwUgsXRsxAW1/cWbYFlnINEjnmcek8F5NgmOnSCJw== X-Received: by 2002:a17:907:7284:b0:a9a:1160:993 with SMTP id a640c23a62f3a-a9a69a64777mr452917766b.8.1729305727845; Fri, 18 Oct 2024 19:42:07 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a68a92159sm161954266b.25.2024.10.18.19.42.05 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Oct 2024 19:42:06 -0700 (PDT) Date: Sat, 19 Oct 2024 02:42:05 +0000 From: Wei Yang To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v4 0/5] refine storing NULL Message-ID: <20241019024205.bc5hxkowpsebijew@master> Reply-To: Wei Yang References: <20241019023716.4516-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241019023716.4516-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: EC00F4000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8d1ui4dt5nqkgnzz7uyxpuutkqt9j4nb X-HE-Tag: 1729305723-773076 X-HE-Meta: U2FsdGVkX18P7rihnz4gFOKEY2fe2CHB6iMaaECamJRfAlk1FpXdLfRnYvalDe/h+gU9GeLolA7AOaSoMvWU0ucWXqJ+x4wJyktijEk6t/7GvkQjGrrw6gz/nlZpB/UdvYia0E+vuUz4ESZzNcVB/99t5B/UAyPYK0Ul708nyqyeVIKEEgzB4Wc4sqxDslC6kt+15hI8k3mEdBBZ3LxSdZ1UoQ9sGeOPdR1R8gKKYJthRPD9HLxhWoUXzXUDjW6/pXCgZcAA+d/JIV5eYvC15PPHYEDr1KM9XdKNl9cC4GUFAnvYEg0M/zCOjWfEOy6ByXXtthz97Z7aE3v8X2wdOEUnneHG5izp+x9MoFuqLqCINNW9Yr8NHcl+ImnrxjlfB24Bn2AciUcYEAPxzD4xUxvjhk0OUsK60oCSoLfBQzkUFAMr93lLWorLRBihWbCFh8bFDdkQZnvs/hun0/8Wkg7qDz3Ge3Z4QiTirw7O1I3qbn5Dw4PTqmV94pTnpKgdci0f1UC3slySp+0TKYbO6OVMO2NfnXxX+fisVE23UAJNbfAPlWoxn0+OM1Wv0rwyU+zPpCPRIpvOogTnLkg8MMFzmAFNppJx3mCDFpORWtxsNuXTpp5v3PUf/OvJcxVqObKzsQKwyXGIKSuYxwj6PHpAAlI7LvzN8aYKZnq9V311eIV8pDlhqB9EbkB+NOBMX/pQ3o2a8L7hno7Uu3W9AMTri48sUZ3va7Su669wk5KRHeuxouMpWtrXRdIcolu1VXIhBLc+qkRBNShOdH8PwcLBOW64Rf3wfvB1DtKddkHSZWcMU/egKnS8Bl4Nw5BViQaSQBoQjyBsk7P+pvagyyeb6gl1ppfBljrdpGB5/xAFAD7nOISBQUlz40iKTf0T+YEZw6l0MY+ZBPng2nyaYQ1r3T6s0TSvobDeqCYCCT3ZMfZcNcaJ9XoflGu1DwwArFrbjlnbmsHXGb9SRO6 jDV506sw tLGOkANoP95i1/Ca3R1mroufjEzq3ydoOUY0YT/iqyn9fZ9pUz0lfdsUtZj3WIjgpFpcGBZkX6Xzf/So9HDEvizf1ipYDQCrQtzdoUNDoADpZZob/q30pSt3I2DKiX3FZuCb3DpT4pautXUZ3b1Y5BsxPO8pMsARmdZLgIBy7g6e62B4xGyb7fsoffI/O/FGyzjUOWBl3l5fC/I0KnodJAgWzBisXcCTk22Vup8VsIS0iW/Dps2NKFFQRK1sEw0AiN53FK/jLWg/Evywi7lpkNVK8Frd40aBv86Yb/lhxt3wjQqeVEMVEhSGhLQ7jBMMNhD1HUN5NenZlDuBY9ve998rAAPO+3TjqrhSfiAfGtozR6cKz+jE70U+jkDcljaZmAgwUQBYJX8DnUjjwjkq9pgU7HBg/QGEbV5JY7fZ4n+zKXXjFh4sBDyklW2pgzjKiV0/14cY12cjj4hIAJI59EHZHbcxhfVOi6QcOZXQDPlktFs2PZNGfl2PGEmsfdqAy9cHPqwcws1PO9biPSkIxXGNmE2hzoe2MqAUgf3OM2sPKHU+H/EK6I6bZsvK2ioEFnrittp4gslaSnEhpaGmEEAgdRt3JAAfTOdrbZ+leKimap8j9M8zgscX4UvKPaNhEG73Vye5gOtYHqaTiQ7HfFNTqT/5z7kfnU5c5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 19, 2024 at 02:37:11AM +0000, Wei Yang wrote: >The original thread[1] thoughts it is a problem in mas_new_root(). But after >discussion, this should be an improvement on storing NULL. > >Patch 1/2 preparation for refine. > >Patch 3 remove redundant check in mas_new_root(). > >Patch 4 refine mas_store_root() to improve memory efficiency and remove >possible consecutive NULL slot. > >Patch 5 adds a test for storing NULL. Forget to say, this is still based on yesterday's master. 4d939780b705 2024-10-17 Merge tag 'mm-hotfixes-stable-2024-10-17-16-08' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > >[1]: https://lkml.kernel.org/r/20241015233909.23592-1-richard.weiyang@gmail.com > >v4: > patch 3 add a WARN_ON_ONCE() > patch 4 add a comment and simplify the logic a little > >v3: > patch 4 move the change into mas_store_root() > patch 5 move test into lib/test_maple_tree.c > >Wei Yang (5): > maple_tree: print empty for an empty tree on mt_dump() > maple_tree: the return value of mas_root_expand() is not used > maple_tree: not necessary to check index/last again > maple_tree: refine mas_store_root() on storing NULL > maple_tree: add a test checking storing null > > lib/maple_tree.c | 29 ++++++++++---- > lib/test_maple_tree.c | 90 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 112 insertions(+), 7 deletions(-) > >-- >2.34.1 -- Wei Yang Help you, Help me