From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC41D3E19A for ; Sat, 19 Oct 2024 01:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E98C6B00A1; Fri, 18 Oct 2024 21:57:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072096B00A2; Fri, 18 Oct 2024 21:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E550C6B00A4; Fri, 18 Oct 2024 21:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C3FB96B00A1 for ; Fri, 18 Oct 2024 21:57:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07451140564 for ; Sat, 19 Oct 2024 01:57:32 +0000 (UTC) X-FDA: 82688690364.29.B160210 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf06.hostedemail.com (Postfix) with ESMTP id 9F1F818000D for ; Sat, 19 Oct 2024 01:57:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j33Z3dvz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729303014; a=rsa-sha256; cv=none; b=63LBeb45MNzmEV/dz9SQ8LgZBQctYbTC7DJicyUk0OMtoL5T9MNHVLxYHlsK8AtbIqhXNW p9cvxLiGigJGwXSlS6N/I5sxUNDUF3cDxwymT8dv6RhMpYbDaU9TS4O7H/5cjQcX77Pi24 9wBN0iv71kChlPx7n7JL5bVCTeovEu8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j33Z3dvz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729303014; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EsGhrsXB+GEbAkiYIA6Lsvq2VDZw4frkC3ls3LwMZRU=; b=67YdwTyoxQVVQ3dXLtCki89jLQdln9BHpl/ZkxGZLJOrHGHB6mntTR/iLlTNwiz163pE6n W8pdX1NSbwTS8TzX0J+1hcUDhzPkbifQxbmOqH8R3nM27dGUhUzgUw17ri0EqvaOv1IJER 2sKl5ee3zmyVqaTCKW10wU5YZmpI3kU= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a9a3dc089d8so343126766b.3 for ; Fri, 18 Oct 2024 18:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729303061; x=1729907861; darn=kvack.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EsGhrsXB+GEbAkiYIA6Lsvq2VDZw4frkC3ls3LwMZRU=; b=j33Z3dvzEZZwY9gMVrlt/qhwUaYwc8jER9gST4aApiEROXmJBdzf1RAMg18Pi+F2Gk XglFjNbH94iA8VY2mAmwEKdcwazxyC8lW0+3J8BVTZjHxkMUVFARhbHKk5FumL0/kCoU DWJ04u4JwxYeg4YUnAc7ImXByhzu/i5trqgJL0M1C7sATwu2/jvZx609b6de6pEdK9gu 1cxl2QP+joGjr0eTm5GzNJdihrtIHWNjVRmtCNfEu5GVOkPL281q6PE/AUtIAajc0x6p tGDpEhOHWuft1TFEkiWt4GwdmDw538+cMr//hOtZSj0m8giRKnyO+OMQzayknELKnHzb iVYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729303061; x=1729907861; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EsGhrsXB+GEbAkiYIA6Lsvq2VDZw4frkC3ls3LwMZRU=; b=SyRBKLGQvTiq8xrKXsU/ESPCWjYx/u8rKOeOiimVtJf2Ax85jfKNlAaIRC9uFIarPu YvKPD8642OtPRuO88njkhdU3q+jR/1PS+kGP2J+WLHq9Iby4zTb+jK8BxYrdX6pnYOVV wyBYw02BGxvtW70iYBNXlPS7CwnyN6+4AEmvIHujSLo31j7RD1SsPJdZkzZmc/lHWdK1 2lFillx7cSHhXgCxskz03RfDHZX/jfaIEqDlVHpetWOsMB2tk4RYcP1XLzVvwpI1yRG6 RMlROd73PL547LV1/fW3MfmaO+rBcYuLoQQnb1aZEa4UED4hL2Zt3P56t6ZlHVOmt7sW 0rdQ== X-Forwarded-Encrypted: i=1; AJvYcCWfhuFksJbVheEgLdgYQ3wgCuLnRaCdejKrQ/WFE0MQnGcUsrgjjcIzyh6PrZiOhL8TREdmvWyH4w==@kvack.org X-Gm-Message-State: AOJu0Yz/eoosVvvPGqxJCiomPokPVx9ekPpVHSvmi7D6zCZuDvZ8SQv+ f7aJ8FuspcNgfYKN5dlKigHi+ZEQNoJTLttI3Z8cLUUcWXOvnNlb X-Google-Smtp-Source: AGHT+IGzN92B0YhZid6l/XPw1axH0jrfo8cRbNJwxi4WWYg/jDIZN0nTlcnXM93mtqlVGhTwhKg+nA== X-Received: by 2002:a17:907:cf8a:b0:a9a:835b:fc77 with SMTP id a640c23a62f3a-a9a835bff99mr21814866b.8.1729303061306; Fri, 18 Oct 2024 18:57:41 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a68bc46fcsm157715866b.111.2024.10.18.18.57.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Oct 2024 18:57:39 -0700 (PDT) Date: Sat, 19 Oct 2024 01:57:38 +0000 From: Wei Yang To: suhua Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suhua Subject: Re: [PATCH] memblock: Uniform initialization all reserved pages to MIGRATE_MOVABLE Message-ID: <20241019015738.5oy7l6fzbmpeixgk@master> Reply-To: Wei Yang References: <20241017064449.5235-1-suhua1@kingsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241017064449.5235-1-suhua1@kingsoft.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: 9F1F818000D X-Rspamd-Server: rspam01 X-Stat-Signature: rcsh6bep87ijcrprght1tw9g85fsrna6 X-HE-Tag: 1729303054-77324 X-HE-Meta: U2FsdGVkX186GXuOzxQHn55kGujQrzEuy2zswrv129+NKftEb01kmfnTS6uGGl2MA1PPGdtfzErjAw/aTuYtsE9szzmkoeVbE3uEnxjZXkywvYSTGL0WEG4dOyXGgiNo6dNT++FKsTrEG8FK1z8s3h6/b4IFK8HPxKbU2enAa43aeD6xTMa4Nf1iCoApvABNyentWGh1xY/O9BPT9UQB2Mi4vI3ebB1wxA82TyJKGwaHn17jye0SclwcXPVkpMdBuYapbHdv6H8pi/V21OsP7xPF+7K2+CcR0J+ayEydfMBqcMpqKuUq5xMkl/A5OpnmGq9GQd896QLn+bj3IvR/uyy1rSH20dyNLvazuZqGMCyesupNVO2vT8mQ0GCpbMbxWYSOvSMfrv0mB+Jc0uo/vinv/KL4X/ecJ58t6OQMfLbkvL3vvD3zUWAswD4nrgs79p7w1oCccMKqz5eZ6MEM5tpeWQpxUqVn5TzDUJ4I5o9rtLHyOBvYXLadTAISbXO3nqxZP+nuLVMeQUKflm9H2T5pZFPbD0DpylGz3/OmWPuysOhsagfrECbinyHeuGGALNB0d72pW0NRx5PBLU+AhT7mDvwPPj+apEMr6LIU5JpBdF5SIpMN60NpX9vtYm+INrxdkSxQaew5JZ47cDHQK5BS8J6fL0sstr7sw0gf70PqdQf9xoS6v7NLPHjJauq35fqevJQFgPRBcuNby+uWwFSd326Bd5ytTeWmmbC2p/Y6nq8XIPbYOLP9rkr4GrRAzLDjASBv8JMDce6p5SU4ylIBUNQzZ19NXQcz2VT3nNgDALHXt4vLb9Yxxd2WoJjWVdFLOqB/s6GDisqrIamxsyHZW2pqljjHhiBPolCYJFd+NYZgdlOWj4yp14ysw/NJglacBu1gXneN3blteeToydfI6NRAn/F/z2LJHhBDWkggaXet3dPBuDW9M+Vv4PPXftaRdxk5iRJzC+wLKkI wmXihuih +9rFjXSMSqWVSL3xCOW8DYuhMnD8ofN3r21wbo8pg0OfCBK5WrhuBSudjOglvteQxQ+w+MCZvRHIG8vOJ8lJUiATVvtwIaNnG9x1Ll1ykMliv9ysecfQNoh6ALmY6R+GTBY4fv5skhNueuN+8gQWj3VqkY7c1KBjooWEOxd0FNqI6h/RxVaUlYeq5hMtQtyYYfdOT0s/EPLkdHphrewnkQpUuVyQG4DQBxMh+dY49mkU5GZYVe/YYuRVe354A3JMmgy4HAhEfWqnj7x3Wv0wKe8tqIISdQyEdzeT8qCHOmVkhI7LM9r7AiA7zjqLb/3gYVUQxGXzeO/IF5vwyXxSgxIIbdD6daDuHIFNOlNM+rMFpUzNo7rHZdWpQon/Z7I3KH0HtjdUuc1ZQn6v4LRJjX4VUF0PDq8G6r32lXfpCI2s+yafA0tUYr7cKDyPJLp840wqfpFhdPEFBmVuvExBgYu1rF230m/L4alKKNU596xBHx6I9Qe47E9DkIgrGY5NA1CkG2AbvU5nQjTgdh1ZSye82ImuoxQJgsN7eh+7ntobcG4fbGiTUJyWh0ZrU+IHUem/OKU8GGDBjJBVos5+GnhRkjuKfz55TwIgT8swKLzfn8kLuAVa5v4PekBZ3+5IcojFS6uY090R/ICyY9sWQieTa0eOAFtXKJp36p5ngABSNcdDA10V8mk3XnrEbeGYCFcoVK4FUmSEPQWk7nBRjoSQ1r5JzmYpBZNgj9VSUt07GL3Bg/6zP2J4QzX2jMdXmodAtWElob/b4xJ05UyDfBolIhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.011668, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 02:44:49PM +0800, suhua wrote: >Currently when CONFIG_DEFERRED_STRUCT_PAGE_INIT is not set, the reserved >pages are initialized to MIGRATE_MOVABLE by default in memmap_init. > >Reserved memory mainly stores the metadata of struct page. When >HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON=Y and hugepages are allocated, >the memory occupied by the struct page metadata will be freed. > >Before this patch: >when CONFIG_DEFERRED_STRUCT_PAGE_INIT is not set, the freed memory was >placed on the Movable list; >When CONFIG_DEFERRED_STRUCT_PAGE_INIT=Y, the freed memory was placed on >the Unmovable list. > >After this patch, the freed memory is placed on the Movable list >regardless of whether CONFIG_DEFERRED_STRUCT_PAGE_INIT is set. > >Eg: >echo 500000 > /proc/sys/vm/nr_hugepages >cat /proc/pagetypeinfo > >before： >Free pages count per migrate type at order 0 1 2 3 4 5 6 7 8 9 10 >… >Node 0, zone Normal, type Unmovable 51 2 1 28 53 35 35 43 40 69 3852 >Node 0, zone Normal, type Movable 6485 4610 666 202 200 185 208 87 54 2 240 >Node 0, zone Normal, type Reclaimable 2 2 1 23 13 1 2 1 0 1 0 >Node 0, zone Normal, type HighAtomic 0 0 0 0 0 0 0 0 0 0 0 >Node 0, zone Normal, type Isolate 0 0 0 0 0 0 0 0 0 0 0 >Unmovable ≈ 15GB > >after： >Free pages count per migrate type at order 0 1 2 3 4 5 6 7 8 9 10 >… >Node 0, zone Normal, type Unmovable 0 1 1 0 0 0 0 1 1 1 0 >Node 0, zone Normal, type Movable 1563 4107 1119 189 256 368 286 132 109 4 3841 >Node 0, zone Normal, type Reclaimable 2 2 1 23 13 1 2 1 0 1 0 >Node 0, zone Normal, type HighAtomic 0 0 0 0 0 0 0 0 0 0 0 >Node 0, zone Normal, type Isolate 0 0 0 0 0 0 0 0 0 0 0 > >Signed-off-by: suhua Looks good to me. Reviewed-by: Wei Yang >--- > mm/mm_init.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/mm/mm_init.c b/mm/mm_init.c >index 4ba5607aaf19..6dbf2df23eee 100644 >--- a/mm/mm_init.c >+++ b/mm/mm_init.c >@@ -722,6 +722,10 @@ static void __meminit init_reserved_page(unsigned long pfn, int nid) > if (zone_spans_pfn(zone, pfn)) > break; > } >+ >+ if (pageblock_aligned(pfn)) >+ set_pageblock_migratetype(pfn_to_page(pfn), MIGRATE_MOVABLE); >+ > __init_single_page(pfn_to_page(pfn), pfn, zid, nid); > } > #else >-- >2.34.1 > -- Wei Yang Help you, Help me