From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E399D3DEA8 for ; Sat, 19 Oct 2024 00:28:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD3486B0085; Fri, 18 Oct 2024 20:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B83796B009A; Fri, 18 Oct 2024 20:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A24EE6B00AA; Fri, 18 Oct 2024 20:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 828456B0085 for ; Fri, 18 Oct 2024 20:28:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5522AAB800 for ; Sat, 19 Oct 2024 00:28:23 +0000 (UTC) X-FDA: 82688465874.27.ED06157 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 55AB41C0006 for ; Sat, 19 Oct 2024 00:28:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OURewQzC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729297677; a=rsa-sha256; cv=none; b=Vc7XltNDQktDc8uLHCHO+vAl4Y40feuopOEIsSm+ad/XVztCZvRuRZyADAIcOviDTBK+E6 JfmuhEhcqcP6i+qFWvwaFSpulWBO0HhJ2NNfv5ijCLCyV9dantpxtYGL5eUbVGLMZixSAv zRtzeMA+1C8lb3OZqUYXkGKsoIMIFCk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OURewQzC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729297677; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=buHXJHrRUlQhg+ENZLS6Y5eQrvAOpMd8zurAuvYE4oU=; b=eJXrnsXMHhPcm3161FcTrdyJAlReyAilgCn0aU3+Q2rTY3P+GV6RVXxp79ArWQ8ov2d3Vi oj125zpjBUwnzMnCUTbk9F6s+XSsrzUm5f6Ax8NjWPOO+EkVbGTpO+IP07pnGAGpK1cG4e zbp0GEXh/wJ9cjJH3+nhTek5whSXBQU= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a99f629a7aaso458445666b.1 for ; Fri, 18 Oct 2024 17:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729297725; x=1729902525; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=buHXJHrRUlQhg+ENZLS6Y5eQrvAOpMd8zurAuvYE4oU=; b=OURewQzCfa/QYl3DQnx9mkX4oxeg7YiWA4DU8JhNkQc0bqFHLiqWvCcyTrJH6f20ZT /3OL077JolDsz065duwU1jHyfF8FekEyFMQk9LYni4TvyTiUqlg8DNOlxleNkgVDlsXP FND7leio8eKhOCYMAAoa7nAfLscvkfA6rKqNdbpv+AiVmFUl67LD4qqiAvYxOhYXhnPK npcTpHHwzRhVuPwDD8tFg8MNcBkkF69i4lMZbuM25DHHLu9oxwOg3t7bYToZ/5gBFUlr BGHd1XqOyr5UO6zJf5xk/BBT6hvM70UO6nnMdWsWXnJbtoIPvkMgYsL3x645++wU3Fv4 5+wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729297725; x=1729902525; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=buHXJHrRUlQhg+ENZLS6Y5eQrvAOpMd8zurAuvYE4oU=; b=r9bJw+gz0fHM2m3Lomqdc67LFRYw6q49t2r1++Wq6B4w0vzjI2HGBOw88yIb8BehiJ eDkb87UpeCywIDIk9Wt2hCO1ogMKQASnApyiuX8kuI+RijmDCCu6iqCiRftKnNaJJ3EQ PguNayZftNdRKVxzM7R6Z5GklvrbPGhdj93Z/8hzyEBokcQxGY+TIab4nUB3z70PKX9F 36VUXAREJbGbWwuY78KfPfwEgukuxzAy+0Jdvst2khWa+xY3CBJmUIX9IDeM/J/rx1sz L40RGZfCUIAFDkPDo0G7dafTlJ0loMzXv0H7egrAlAPo/1F77cLDFG2CESKQio5MvkVY uK3A== X-Forwarded-Encrypted: i=1; AJvYcCWwAsB2t0fBuGcWJ/pWzHoiy6xTF7pYriawzdRh2FXGe2YfN2n3rRtln4YQLXEg4vujcDMAhxBBKA==@kvack.org X-Gm-Message-State: AOJu0Yw3IEKehmaiRGxN30CQaSGV0c7NeMnBTymHqdmEF0KMTccPbZ85 kxj2TWsx35yADM+WFdUHzhhkJK5bQ2amH7pMZWEN2NUunQ0Emr8J X-Google-Smtp-Source: AGHT+IGBxnbv11Lpqxj4ZQLtvPwyVsM+q0JwSc5hSE//Ly8PQC//o3HEaRcDVzehmlVngRVsIxYU5w== X-Received: by 2002:a17:906:478a:b0:a99:f94b:f92e with SMTP id a640c23a62f3a-a9a4cc58ef8mr907974766b.27.1729297724678; Fri, 18 Oct 2024 17:28:44 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a68bc4cc4sm150605066b.113.2024.10.18.17.28.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Oct 2024 17:28:42 -0700 (PDT) Date: Sat, 19 Oct 2024 00:28:41 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v3 3/5] maple_tree: not necessary to check index/last again Message-ID: <20241019002841.d5c6o6onvawcga3y@master> Reply-To: Wei Yang References: <20241018023943.13860-1-richard.weiyang@gmail.com> <20241018023943.13860-4-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: 55AB41C0006 X-Rspamd-Server: rspam01 X-Stat-Signature: x558na8614uixeiojsjbdgzht881ajqf X-HE-Tag: 1729297721-840260 X-HE-Meta: U2FsdGVkX1+9Ooaig4xEJApljYItx5EcXMyMqPVIu0Ah9KWgkCJK1QP9A+2fVwHjeNsj+lFw3TZtOPSbZX5OlL3KW3hr/quhX3X2G7h6UrBP2t7Fs7KXVTnUGyBkwfZ3A7d3nH1BHkOuXPguA3nuL/NVHYIsi2ZD2HgLc+T+2TD1XmqNnjBaLGKg+6u5iONeBbJIiTj6xTIWrBdkk70giq9GsocC8Adg0h6y7hLNyorUua0Jkfhf7iWxfXGpuFFtO8JPUn6H0KelDjjRxrBQxbx4CY9BmNOlUR5reX/vBibfr/vP3BBIlLGhw4iza0AncWAtd6CwrtHZSTzX98Y8XX78lnO93ZKpwNNU9UyBMxdVGo47SrKROHTg2iHZpVUxRWSfBdwU0WAh5QXFp2Wmw2rCrzQ1YC7fy7lCPBEVpqw6pUTxZ6iaaSvIrwRnOoDCpmqIkVIPF8sxJXF7OAHVUp5xWc5jepqGIabiN7tNcGi9OK/+XVc5tdnMerIejrYoeVfaWO6yfxSr5ruaSGn1ml8TGMJGpbci+80cgQL82t5lUBMsWZ3fkd2xIKvMi0D/FuZLAF0FoiMGm6Xaj4h3zlIODlivfzuH8XiSzkALYtMBBc+4halO095Fc8nhtvYF8aED3CJYamkxzqVmhLBnqupFtJIBymtB1GmuV4XfS9qNJCXlfIf1jDij4LthA00ziFPDvFO9DlQ8Cp4DXXQSQ9cFwyBWCvF5cu1gJ6fmOY+IMk4ssz1hqtYDI/0CqoetpDRIiowOnwXwx7l1ePpq5Agv7GsE3wWNsV410toB553opUm9m+G9jUfHpuQ4vwTh6T/eFswk6J1DVIBvu8iKUOB68NldFHhsQpfPB47i5azdqvbB0TSHnnl4H74jEsGJbaIOrt8tHIDQ8F+nx2FqBRlzvMp+KhSXmJpY3jUr2SzPxD8N+iWM2vuZHXqzMSnjJBww0f21Vx4US4yQGJ4 iTuq+TFN JiqFn/Kin/xypfpzLZjbX16VHxtSh0JUQaX4MOBJwvs+sk/n5nyG1iD5sQEVVysesk97GOdMqKS5YWapXF4bdOogUyHcVq/SywLYInT3DyHBd4vzH30ONI1TmhKqGd+54avmeOQS12zNhnIbLqG5QxdEO1Afqkc3nfQutvMsOwIZsk0OBxLIzTp5JJbODSNHWccTPF7WXzcNuAsqHwPdNcGvvp1fzCbB2lSY1XidVZENH00YGSOQTgO8jTw451wjp00kbI6rMQf1tD4FJ3/+1TGSqXUeqenrj9hqb57F5fWq7htGQ1H6rCB2TGRYNc1cRqg4ON/qXDWCtG0/0UB6HZ/jh7p1yZrF+gQymVEL9B+actJVaZnAs39GywHKkDXscgnaqj7NlxPNM/jLlIuH1+5Ye+kK5VOuWCNuE5cy0V9Z9djC6Nj3i8RW3zyK0Xe/vv1JOqvrAdVUl4EswkmfZ63JCkbn2Itxs8yo5CNPqtA6HxiCjRZEhbcZCZpGHS7pt9v2dA89YwhW5gcFunJeSdTmWsXHfE23N4IWYL5wdUCRYLLA8Cp7Hp70NsmzACYitXEmud/f9EsNYvDi0QEjMiKQauMeDfo4H7/fdHZfy2QQo4Ck1vbwnrfjQEpkN84NroSFWeUsMOowtGSwvvE9xkDeFelQH0X46G24EzyZaOSjRR6aayX1pMRQxvgq2QPKSVt40ngfNuxoxx6AZZxk2qL6HFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 01:43:18PM -0400, Liam R. Howlett wrote: >* Wei Yang [241017 22:40]: >> Before calling mas_new_root(), the range has been checked. >> >> Signed-off-by: Wei Yang >> CC: Liam R. Howlett >> CC: Sidhartha Kumar >> CC: Lorenzo Stoakes >> --- >> lib/maple_tree.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index cbbaaf60efa9..db8b89487c98 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -3662,7 +3662,7 @@ static inline void mas_new_root(struct ma_state *mas, void *entry) >> void __rcu **slots; >> unsigned long *pivots; >> >> - if (!entry && !mas->index && mas->last == ULONG_MAX) { >> + if (!entry) { > >Probably good to catch anyone using this wrong with a WARN_ON_ONCE()? >It also has the effect of documenting what is going on, which is always >nice. > Sure, will add a WARN_ON_ONCE(). >Sorry for not realising this earlier. > >> mas->depth = 0; >> mas_set_height(mas); >> rcu_assign_pointer(mas->tree->ma_root, entry); >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me