From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B905BD3E195 for ; Sat, 19 Oct 2024 00:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E7106B00A0; Fri, 18 Oct 2024 20:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 171B16B00A8; Fri, 18 Oct 2024 20:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2B996B00AA; Fri, 18 Oct 2024 20:27:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D3C0F6B00A0 for ; Fri, 18 Oct 2024 20:27:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00490120409 for ; Sat, 19 Oct 2024 00:26:56 +0000 (UTC) X-FDA: 82688461380.17.9BEF282 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 3FBC61C000B for ; Sat, 19 Oct 2024 00:26:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KT22PSH0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729297464; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2wVjZM4p5JPi6w7Re+42Jm5p9q+9tV8j27Jx5fAHZEY=; b=EURiXOScNzG7EXrmzfsLGoBc9veSZJ3hcaaMGNZRZoXVKsH/6HIRqqHBNnNmkMZ+nQReZ+ 72X4OLwvM/IGPH7Hxu7Gek2h1HV7RzaF6sc/+MvCMS86NOyb9cl5EC6dvaF10HCFRdBzvq seNoh7FLrh8Ob3CbvpJ20jlIDjpTHpQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729297464; a=rsa-sha256; cv=none; b=uLFXRHgBftvzFv9npNjci+G62+WQkeZuWZmHbRm9x61hPzee+qG20E4lJYbEdACPhRWixP QxzBPOhN4CF1sXj1ATRa6z5brb1JmidQxT1Ax73kUaFlNp5/0yvOX8JEJMG1dNJAoSSuC7 /adJRj2UUrXu8ZY3BQX09FZ78AuF9w4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KT22PSH0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso351806766b.1 for ; Fri, 18 Oct 2024 17:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729297625; x=1729902425; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2wVjZM4p5JPi6w7Re+42Jm5p9q+9tV8j27Jx5fAHZEY=; b=KT22PSH0jTEIRXaD5CW3ua33n3csBbQ67wIOAx8BSZcQ0Uh0WafspyfQEIlM2kU4Gr nGLkYy9wWe7+/jX2bvth564mz3fRNDA0VLADNgyp4o2QEwEtqVIdotLEzi3yxHRqIAn7 qhNw9QtIO8OiqSm8y9JOp65gaqzSM8xbEXnozvAihY77b3bkYdFNTflKXncXkXMmd7po X61UoRMjDv1h0QwjiF7TrfDvTf8o2ylLzPw+z8W0R7KRr0BnToJcwqFHrqDYu2k/N1v4 DYFYM+pG9xzE6/lnpVHSQmgzxK1+9sVrAGBb/eiVnXQyw9MQRJdPavtbE+SasrZF3TIA wtFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729297625; x=1729902425; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2wVjZM4p5JPi6w7Re+42Jm5p9q+9tV8j27Jx5fAHZEY=; b=HFC3162kHBsotoVPTPvVoKVkzdw7Z5coulEORvGLP+dyWvytUYClSwk1N1Az1NQ076 dqnKrXg2FuiR3ACudNGRQiGELIDbDcSKtd/WuW3Pip+sJoYD+9b31xg7q2W2qeT+fycR CYumZOQ0asqL47LPOB+89y924eWeG0vn1ZglfsFoZXEldbjRX1dgsYwn209P9goSW2ML 3yFrRdJH7aB4FE4XkqVwA6oE3GCQJn1El4cErBCMeuYeQYGu7hx61pKharyez8BSrlZH gUXh5B1dTYmblyjuEh/3VSgvAQX9bY/OCyALnnZCP42AO3SazhJR6QxOIsa+T2tBVsnF wLCg== X-Forwarded-Encrypted: i=1; AJvYcCViQJ2nTld4jd0cxNKLxbihw6tdRmqK6uvplXKlYnFqo5ss11EHHwbe1kHri0rv9NOgcCfCnn9rDQ==@kvack.org X-Gm-Message-State: AOJu0YyGbV4rRywbeh8VADFcDC7+9VVA4VKYHz5+e9a3SAPP6ds1Nn9Q 0yvjgRD06qvABLbG352BAKgp/fkN+qGzZmJRaPNB1ntgiTvfwBSu X-Google-Smtp-Source: AGHT+IGnMYJ0CDgVVPAQ/O7Tv9i5UlivARf9cOvQYB8zcC9siq1E14Xowom2iO8beTvN4wW90pSznA== X-Received: by 2002:a17:906:f58a:b0:a9a:67a9:dc45 with SMTP id a640c23a62f3a-a9a6995d6bfmr312167766b.3.1729297624523; Fri, 18 Oct 2024 17:27:04 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a68bc498esm151969966b.136.2024.10.18.17.27.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Oct 2024 17:27:02 -0700 (PDT) Date: Sat, 19 Oct 2024 00:27:01 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/5] refine storing NULL Message-ID: <20241019002701.ueibqsivtzrfiazv@master> Reply-To: Wei Yang References: <20241018023943.13860-1-richard.weiyang@gmail.com> <545umwrjzzv72qoulnba77ov2ktbxoqx7youq5b3e5arjgh7tx@5yhv63pnypow> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <545umwrjzzv72qoulnba77ov2ktbxoqx7youq5b3e5arjgh7tx@5yhv63pnypow> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3FBC61C000B X-Stat-Signature: 3ygn8cy8dj8e1y8xb3e5q7oqcxkr3n6f X-Rspam-User: X-HE-Tag: 1729297612-962321 X-HE-Meta: U2FsdGVkX19MLeJIBaqBeUagzIVwd/v7C0W00s5L6KHiyhyGynHAvByryIMkCtsJEAXO+pN9yITwKEK6bbNSRRXIccz/jr9UpQOQ8KqdKSwwhTCcXXl2tHr8IEyKinNmbGaVyy2s2zHYkB/LfeQuNFIDjAUr6scOtjf8FM84TEolmfDMessedEyFxMQ4VEm76F6dtJ53KQ0nxItioEtkWXm/pajaxjVaRHZA8Mcz17dHwPsoF9wjJ1GPK4yENM0x6zUJ60O61TiVfDZRQzBo5RcqqShNUa5p4l0dkE1lffsmTV7U75y9pWw+LLEQI6Hctiy6t00cf+AjxVsN3vcQU48uTZ1eacQqwllmgFavvg0v2cP8qdsvSnL1jbaC3KsUI1fVUvuB1sqOmre7ioOfGm5DHFQ+g5i7eUN5MDr8J9WwMBV19kJk8NzfSf35vKmfc0xlBT6ggQNNDj8PWM/ilS+h+Q9GqNnlv0tQuhlqo1s1Uq/ff7GcA+0lg0682ruGLeqMC18LFf5oT+rqmtPBCadh/J/73k9ZDyQG/RIeEsAYLmCRl9UdjZtd8l57ARrJ81FDqtcMUKr79YT7M6x6j8ZTrb2ZzRRwBzZbs8hr4v1SSV8u/4Vt2wtUBF0ByrKKCWezTrYy/XAgQmzoBDbLEjTzJSiGDEA2YQ5rQBaUe8XxmOFudjGJyQZs/5NEKCNkjKA3Y8WkVJ5kRAMkXwPKpsdEvHzovyOV6qK8AmYxRU9zFDOZjNXdpajE+TdgOsx1LobzAZZOEZ+IR94hnD8AIjhrkbTq9Lv71zKrtxRcLbq+16IwvJdc+nuV/eAV3K9RahKc709Hy5g2cy3CtSw84TCJTT7BsUvYI/TSzc1Wd9jhRg3vkD/mKBp7VRFIZphA/svqJyd+hgUauR9/xUCMqWcP3Kqf4qY6N3lL/gK9Lvwq/TXQNBo4KPrS0JQkwK70QVHLkRSU3nTmjUGxelC NEF6wP9U sKqlKAc3YYnLIVmFneWtcSILd6ldrciTWfi7NoDLOBtWptZJrytqpexwOXe4mO+90GB/AC9Aj/kMu35g9jKdwN2VW7MzyqH81nkH+YFiQcyffTWRgGQ+SMNjTZb0doZlO2Xum6N+35DYlon0Gy+/ewRNlOzXZ54IZiMiIi/fLoQ+ontJEKh7Q81nmadarPkJQbr3PwykPgOV7EI6DdogWfl6g8Y4XAVXlGl0U9Lh9OiSJ4MUm8RHTAdzyypuxc5BxIsEG+9HBIGR/dB7ER2BmeQEEBo197Wlsikz78RDi2ZCoYF1wvCnTX6uIZza77GEK7Ntl933TUDMvxUxUvu6lNDKgKdcuKZgMSZl867rl78pr7c5pL7v9AJThqzq69pp3enpJlIMNerOtLM3mSM5y+7cDQaIxL/L/IhLQnpeKoz3dmQHdmIpFubX5N+aFiIK9JbzzX3Wy/cwMJfGzTYhSNSV8CnIM4a3vQJO+Dm7q9QeCxEjovmp+HpYam3vlf1megLmAmwQZAgbewf0Ecxm6X9xhj87knWwrp2YrMW9e3DCNQdcBXbM0W9LRLCb05skZNCu9BoXpjZf27W7s/8XRnoq2Xx3a4+cTMXt4+Z+xJbaJdKyVyJkUvTupKPCH1ZwkxBYH1midTukSW84zGcXSuV9CEwBkFGCiFbm4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 02:03:55PM -0400, Liam R. Howlett wrote: >* Wei Yang [241017 22:40]: >> The original thread[1] thoughts it is a problem in mas_new_root(). But after >> discussion, this should be an improvement on storing NULL. >> >> Patch 1/2 preparation for refine. >> >> Patch 3 remove redundant check in mas_new_root(). >> >> Patch 4 refine mas_store_root() to improve memory efficiency and remove >> possible consecutive NULL slot. >> >> Patch 5 adds a test for storing NULL. > >This series fails to apply to akpm/mm-unstable today. > >What are you based off? > I based on yesterday's master 4d939780b705 2024-10-17 Merge tag 'mm-hotfixes-stable-2024-10-17-16-08' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Do you prefer to based on latest akpm/mm-unstable in the following spin? >> >> [1]: https://lkml.kernel.org/r/20241015233909.23592-1-richard.weiyang@gmail.com >> >> v3: >> patch 4 move the change into mas_store_root() >> patch 5 move test into lib/test_maple_tree.c >> >> Wei Yang (5): >> maple_tree: print empty for an empty tree on mt_dump() >> maple_tree: the return value of mas_root_expand() is not used >> maple_tree: not necessary to check index/last again >> maple_tree: refine mas_store_root() on storing NULL >> maple_tree: add a test checking storing null >> >> lib/maple_tree.c | 20 ++++++---- >> lib/test_maple_tree.c | 90 +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 103 insertions(+), 7 deletions(-) >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me