From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655BDD30011 for ; Fri, 18 Oct 2024 14:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAAF16B007B; Fri, 18 Oct 2024 10:41:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5B026B0082; Fri, 18 Oct 2024 10:41:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFBE26B0083; Fri, 18 Oct 2024 10:41:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 925876B007B for ; Fri, 18 Oct 2024 10:41:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5B37C120893 for ; Fri, 18 Oct 2024 14:41:00 +0000 (UTC) X-FDA: 82686985332.04.B74B803 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf27.hostedemail.com (Postfix) with ESMTP id 1D0E740009 for ; Fri, 18 Oct 2024 14:40:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EkVR6cME; spf=pass (imf27.hostedemail.com: domain of ptesarik@suse.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=ptesarik@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729262322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/asqtaNIs/LQ8Ex93/kvLh/pnGYCRBo6rP+voj53b58=; b=0SSqW00Hqt74ukoU3GEzRG5RL54fL2swtYf+lzgvDgAyn1ZuWYcwXSlOXbYPquivzYhXRa d6Q5rpdHTq3Q+4ZYyrnpFxGf9B5AJ/v8CzK4WjiI8Nzwl8tgo1IATBtridMshVaVw6FUU1 UpHH55Uqma+8uCQgbGqVkKuzc7o9v4Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729262322; a=rsa-sha256; cv=none; b=fIKttFhVCnxw0ZXzDUi9CLe6oTFtEs4VGWbQ3Qw+NMHHx7rB52C1OAFb3KskDlANBOH/m0 nvDBjnzCjf+/4+FfTwxlDTFd6tPAcqrDMzfrSKH1U0BXzerOgtRk/TDCEWWY0paWR+5dI0 m7Atd5Fix7OhTYXv0cSNYbUrttsMNhY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EkVR6cME; spf=pass (imf27.hostedemail.com: domain of ptesarik@suse.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=ptesarik@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-37ece998fe6so85553f8f.1 for ; Fri, 18 Oct 2024 07:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729262468; x=1729867268; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/asqtaNIs/LQ8Ex93/kvLh/pnGYCRBo6rP+voj53b58=; b=EkVR6cME4wLF9jBJzZuXQzyXoKq7bplAoj/4RX/kA2DfXo1x32O5lRCHp0kOG/egQQ 1vx5kHFYyQmFqR6wl9tmtg6V0g+nhuVCAD6BzKAwLXRjbB7Q3y6yAtq9oPuMBi4yr+Id uGrfp7GVHgFqi2siUtbtsC+w2durs6+hns4KqVUaI/gEZFpzorg5B5XZ1WqfPTL/eh2T x+qc7XdwdZveQd3/gIv6s9O7VaXPAw8/nkkcQgp65sRPoYREuT3OCRi0MpZb1VoMmOR2 ZdhYj0RX9p3rWiwkUUfywebRcB8yj6t2nDhMsQaDU4CwXgSrBkojNmrWEMM5p1C+V8SP PAPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729262468; x=1729867268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/asqtaNIs/LQ8Ex93/kvLh/pnGYCRBo6rP+voj53b58=; b=k8bvChjWQ/DvX6ogszLGnLF7u+kT6p7doukIQjjMEo/E1Zur/0E8uOPrbBoZ9kDssu ABXm0JMG9Vk2nxiiGENA0TfmSjcfnxbIcDbIoEgVHbeW5XAeqKNmNP8OrFTIAN8GAG/E swAasdz4OD8ee9PLnfqLV3iBMV6JQrPT0CEyCHeK9s9co1nZWaX28VS6syYPdkqhCCnv tIJ2X1nrb1tlbQQF17Uxrg2L9kvb/HQPxUsI9oYWe4glR8+RL0SolLEazJ4oCN+Detx3 PuwvB8HoeY91/qbnN8NkHhM5Y2AmWL4tKgDHU1CM1Eq/ux44vICG7h9og30HPwTyg8pB ARzg== X-Forwarded-Encrypted: i=1; AJvYcCVpRU8sZmEfxqFLYTZn5B/Oz7fVbcdxb3L2YmpU2RMlx48q6toi1PEBYut4sBJ3jw5cCipPVoH0EQ==@kvack.org X-Gm-Message-State: AOJu0YyF7TbCmiCWne7C+31KOe5KX/y2sHSrqW6TjKDESpsKtv1IdqBA cIKyulYsBF1ksc1NU2cPHdx+5sqx2sfq8V55q0jQUklHCNi0ganmGKg71SDpF00= X-Google-Smtp-Source: AGHT+IH1qh5S7J6zFo4ncGg6+V60kyTvlAXKQJ+CLNOpfD5sSenXkDz6pcY/WbUhTw8Yl2xQ5APNLg== X-Received: by 2002:a5d:5f41:0:b0:37c:df55:c1a5 with SMTP id ffacd0b85a97d-37ea21c778dmr1041803f8f.6.1729262467626; Fri, 18 Oct 2024 07:41:07 -0700 (PDT) Received: from mordecai.tesarici.cz (dynamic-2a00-1028-83b8-1e7a-3010-3bd6-8521-caf1.ipv6.o2.cz. [2a00:1028:83b8:1e7a:3010:3bd6:8521:caf1]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ca0b08ad15sm832282a12.40.2024.10.18.07.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 07:41:07 -0700 (PDT) Date: Fri, 18 Oct 2024 16:41:05 +0200 From: Petr Tesarik To: Ryan Roberts , Michael Kelley Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 00/57] Boot-time page size selection for arm64 Message-ID: <20241018164105.0e5cc7a9@mordecai.tesarici.cz> In-Reply-To: <20241018145600.0473b1bd@mordecai.tesarici.cz> References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241017142752.17f2c816@mordecai.tesarici.cz> <20241018145600.0473b1bd@mordecai.tesarici.cz> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1D0E740009 X-Stat-Signature: a55njkzpttnsmzm8eawqoc7xm46wi5p5 X-HE-Tag: 1729262457-667874 X-HE-Meta: U2FsdGVkX19FrcZIvCbY33HBeb1ruF2U1Cn3+r0sqyN6J13fGMIw464xyui/rEoMftNd2bduLjJaYuiz/OTjmsLNI76NcQ47kbogPqN0e0ZIhRBtHqojTw65MzEZ0B0NsjiM9c5fpeskewFvwt9gKxXlND2xrcH50PpIYnHn3OpWo/X6w/bBKktprgp1qz6JzoJjUxwx/y58WsIeZh7tP47b1SKxc1jUl5RCcWECaTYTI7OtUQHvSQKjtzzv/zjNcmXavXOAyIsmaq4ZuYxKDJdTDRpWFXXcTvUIhMeFRGWirq+fvVXeVi/5FSMwUIjm55JzByAcbw9knBWgMgA4UMqLBVZdhD7VAwAi7QMr46bpkaTDqlD3RxkOijXXieK3WhIaeVTPOz5ml+10NeixroDSG+sEoNoQZNlXVlCVG73raX2nNuGxX3SXuY4p0ExFZFl03gczJASYQcsxNPsKxibFLg2fpLs7wH07ADk5NPCg64V0jsfyZKWuXLZaPb8dn3vvbpNGuHnQ3auZthzkQIhU08Ylv5OoNfTorQ1BQRpBxrKpsDOw9yVx31j1f4y3hscOzZWkOo4RkUkgMbgl+/6wh+dRo6q+XljwY48lKm1Yr36wLObXK8Q8tNw53p7j87+0FM4e6pzNvptPvBVxesnAKHSWkhvguTnyAW6AjGA/bRZIHwKMTLEOQgAbgnZCWzQZrFf3oPb4MwilEdnDCkRO5bFnSa8Xlr795g2NCAd/NiJU7spQ2/00Fs1yvQfd9SAwE4P+bw0QU8gMvFNjgTYRex9Dl4LPL1k7k9TL4DtMykem/hmybRwUAjt9HBPfrowPRQBvyhfMqWBh2SEkghrzkq5JokY2E7oWF7w29+2t3LxXB4amCKBIx26T2yVhoWm+Ziu4pJw5AKL8hSDEpfVvwvAKVQd0ylRLYhSQWAw0bg9wGnJrKSMS0+igDH3OisxaBv/TANOzoBKKA6u orWVg2eq SEvCV1Y+xrP2g2CdovQZN8a0NtM6CFLLi5jsoE1h5G9k2gvkfpAfj1n0azI5nKsCpHQwXYHecKr+8xQ2/BmzDKEmZVBXKdgR2syke+pNqtpTEa0ob54HwLO9BlMlkymlFy74nHaH8FhiB/7UMiXxahtVRyhdR2Ms2DLs3M4K/MAvp2hwbXzOMCynzBc3PMvWos5jB0ofYzV/aZ1b3TlHhiW/DTwwjAlzQ2mcPjiEA5l6xEgp52vQhxCEUH5DCwJWp3AcZBi0q62MCekptVJXKIOPacfsyejppLcwVFpEZPL6UQne7KZUT5iSDbTsjrxqrDNJRRKsYQS0TukKZGDpEw79Uiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 18 Oct 2024 14:56:00 +0200 Petr Tesarik wrote: > On Thu, 17 Oct 2024 13:32:43 +0100 > Ryan Roberts wrote: >=20 > > On 17/10/2024 13:27, Petr Tesarik wrote: =20 > > > On Mon, 14 Oct 2024 11:55:11 +0100 > > > Ryan Roberts wrote: > > > =20 > > >> [...] > > >> The series is arranged as follows: > > >> > > >> - patch 1: Add macros required for converting non-arch code to = support > > >> boot-time page size selection > > >> - patches 2-36: Remove PAGE_SIZE compile-time constant assumption= from all > > >> non-arch code =20 > > >=20 > > > I have just tried to recompile the openSUSE kernel with these patches > > > applied, and I'm running into this: > > >=20 > > > CC arch/arm64/hyperv/hv_core.o > > > In file included from ../arch/arm64/hyperv/hv_core.c:14:0: > > > ../include/linux/hyperv.h:158:5: error: variably modified =E2=80=98re= served2=E2=80=99 at file scope > > > u8 reserved2[PAGE_SIZE - 68]; > > > ^~~~~~~~~ > > >=20 > > > It looks like one more place which needs a patch, right? =20 > >=20 > > As mentioned in the cover letter, so far I've only converted enough to = get the > > defconfig *image* building (i.e. no modules). If you are compiling a di= fferent > > config or compiling the modules for defconfig, you will likely run into= these > > types of issues. > >=20 > > That said, I do have some patches to fix Hyper-V, which Michael Kelley = was kind > > enough to send me. > >=20 > > I understand that Suse might be able to help with wider performance tes= ting - if > > that's the reason you are trying to compile, you could send me your con= fig and > > I'll start working on fixing up other drivers? =20 >=20 > You're right, performance testing is my goal. >=20 > Heh, the openSUSE master config is cranked up to max. ;-) That would be > a lot of work, and we don't need all those options for running our test > suite. Let me disable the conflicting options instead. >[...] > I'll see if I can do something about btrfs. Then I can try to boot the > kernel... FWIW the kernel builds and _boots_ after applying this patch: fs/btrfs/compression.h | 2 +- fs/btrfs/defrag.c | 2 +- fs/btrfs/extent_io.h | 2 +- fs/btrfs/scrub.c | 2 +- include/linux/raid/pq.h | 4 ++-- lib/raid6/algos.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) --- a/fs/btrfs/compression.h +++ b/fs/btrfs/compression.h @@ -33,7 +33,7 @@ struct btrfs_bio; /* Maximum length of compressed data stored on disk */ #define BTRFS_MAX_COMPRESSED (SZ_128K) #define BTRFS_MAX_COMPRESSED_PAGES (BTRFS_MAX_COMPRESSED / PAGE_SIZE) -static_assert((BTRFS_MAX_COMPRESSED % PAGE_SIZE) =3D=3D 0); +static_assert((BTRFS_MAX_COMPRESSED % PAGE_SIZE_MAX) =3D=3D 0); =20 /* Maximum size of data before compression */ #define BTRFS_MAX_UNCOMPRESSED (SZ_128K) --- a/fs/btrfs/defrag.c +++ b/fs/btrfs/defrag.c @@ -1144,7 +1144,7 @@ next: } =20 #define CLUSTER_SIZE (SZ_256K) -static_assert(PAGE_ALIGNED(CLUSTER_SIZE)); +static_assert(IS_ALIGNED(CLUSTER_SIZE, PAGE_SIZE_MAX)); =20 /* * Defrag one contiguous target range. --- a/fs/btrfs/extent_io.h +++ b/fs/btrfs/extent_io.h @@ -89,7 +89,7 @@ enum { int __init extent_buffer_init_cachep(void); void __cold extent_buffer_free_cachep(void); =20 -#define INLINE_EXTENT_BUFFER_PAGES (BTRFS_MAX_METADATA_BLOCKSIZE / PAG= E_SIZE) +#define INLINE_EXTENT_BUFFER_PAGES (BTRFS_MAX_METADATA_BLOCKSIZE / PAG= E_SIZE_MIN) struct extent_buffer { u64 start; u32 len; --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -100,7 +100,7 @@ enum scrub_stripe_flags { SCRUB_STRIPE_FLAG_NO_REPORT, }; =20 -#define SCRUB_STRIPE_PAGES (BTRFS_STRIPE_LEN / PAGE_SIZE) +#define SCRUB_STRIPE_PAGES (BTRFS_STRIPE_LEN / PAGE_SIZE_MIN) =20 /* * Represent one contiguous range with a length of BTRFS_STRIPE_LEN. --- a/include/linux/raid/pq.h +++ b/include/linux/raid/pq.h @@ -12,7 +12,7 @@ =20 #include =20 -extern const char raid6_empty_zero_page[PAGE_SIZE]; +extern const char raid6_empty_zero_page[PAGE_SIZE_MAX]; =20 #else /* ! __KERNEL__ */ /* Used for testing in user space */ @@ -39,7 +39,7 @@ typedef uint64_t u64; #ifndef PAGE_SHIFT # define PAGE_SHIFT 12 #endif -extern const char raid6_empty_zero_page[PAGE_SIZE]; +extern const char raid6_empty_zero_page[PAGE_SIZE_MAX]; =20 #define __init #define __exit --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -19,7 +19,7 @@ #include #include /* In .bss so it's zeroed */ -const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256))); +const char raid6_empty_zero_page[PAGE_SIZE_MAX] __attribute__((aligned(256= ))); EXPORT_SYMBOL(raid6_empty_zero_page); #endif =20 Petr T