From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EBAD3C533 for ; Fri, 18 Oct 2024 00:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DAF76B0082; Thu, 17 Oct 2024 20:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38B096B0083; Thu, 17 Oct 2024 20:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2524C6B0085; Thu, 17 Oct 2024 20:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 06D226B0082 for ; Thu, 17 Oct 2024 20:00:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 42182C03AA for ; Fri, 18 Oct 2024 00:00:25 +0000 (UTC) X-FDA: 82684765884.20.50B1D3F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf13.hostedemail.com (Postfix) with ESMTP id 14F9C2000B for ; Fri, 18 Oct 2024 00:00:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bX2U+rWH; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729209491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cCtI2Ey1L4tTz6N4D86iYDy4fbRh7gswlqB9CyB19yI=; b=aGY5v7vQB5dpInqDiZBwpiOdI8xF0zBPX/xuLeLeuSXKg3Foe4SkZ4oWSQi2H17DYUL/ct Pt917qblPPIOvKHLc/9vFdf0ZpQkvWO26wg56xJmRW2/xPqUS2g1g9CQkXfdnT+IRrfNB0 8ZLi5akh0xOB5F5uvXpXe7nwIpakwCk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729209491; a=rsa-sha256; cv=none; b=MUGHOcNGgsolFyzB58ODM02Lrpgjw5FMPz013XASzDviQt+a/UcbrupQA04l+a5xE+e+fk CbpgLoK8hBVEMnenyK6Gj85BnoDtBGMINSI2K9UPO/WPtlMptHJhtGpzuXVf4bWQ0I6+Yc NfueGyCfO8oyDaXtMXaxuGjx9TaH1yU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bX2U+rWH; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1CE4FA41FA9; Fri, 18 Oct 2024 00:00:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E39C4CEC3; Fri, 18 Oct 2024 00:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729209634; bh=jEidQ8huvNa9jQ91Lz9Wd5W27GjtDkgEz2PDNCEUFaM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bX2U+rWHpPrtvU7/m9OOQsqcSOUNtubDWRj/B7F9ms2Mf/qmtdqFGFAaAhJZGRgvm 3DIah/y9Qwcz0OX+mJI5V9P8k51jzmIZQrklR5DgABaau4WZoI4QCX+x3EhyuwvzYp vIvhNeBrTIC2SMnXgTkhrGTQVfRJHf1B+LlJJz90= Date: Thu, 17 Oct 2024 17:00:33 -0700 From: Andrew Morton To: "Liam R. Howlett" Cc: Jeff Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Jann Horn , David Hildenbrand , Qi Zheng , Kefeng Wang , Pedro Falcato Subject: Re: [PATCH 1/2] mm/mremap: Clean up vma_to_resize() Message-Id: <20241017170033.6bac2c50f609f6c63c861783@linux-foundation.org> In-Reply-To: References: <20241016201719.2449143-1-Liam.Howlett@oracle.com> <20241016201719.2449143-2-Liam.Howlett@oracle.com> <4izjonpaqhkx6p3csfyxcjicgqahbmj2k6gupazehb3l7xhnvi@twlvpx2wc6ce> <20241017140813.fe555ec947b17dd035e4c0d7@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 14F9C2000B X-Stat-Signature: stk1r135qzfxn8qdfoh9f7nf5f59sy9q X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729209624-753557 X-HE-Meta: U2FsdGVkX1/NM5HVul02bjwE/mrYRBu0YKfeLE3MgcdVlqb0z8TjC5g0S//PjWqUXfgGbK2XB7oz+6YBrYkVnYuvnuxWDLp80V02Q4iIz2b7zhubjeW8/9537pK0fTVRDoO/u5ITymep+Ftqef/PiwwJGAeXh36FxJZhr5E3DqEC9E7IUIFoTzFrw+vCssh96FkGU1zAnrTZq7B2F4ZjSUfIFAqxKnZXq2viSjXtEntjzaNfdBxT284eAkfDAi/Dm6mChalllNJYqr5c8mkGUlrqgHEshdF01DfyKqT8uwBuDkts8NWqSN0bg+lSp0dyuqSxM/sEJTuPTmXVVSbADVpwCPcj00JomQ9ZoT5O10jaVOrsviRB5Jhq9GfxsQe6Zr03AqWtLs1qQCu7HslGQldS8epzSx/Haz/4lpL310oSlWfoeuemoqhLe8StYrqFzcbXcamlqTiUIELOW8thMPe9/nFkBDNs0dOucbgPQEiDa3qBkX2CRtU6M/nF0AJwJt0pK117qDcfSrQMpJW2dtf6n0uw+xdKGB/mJMWXCFJ4oaQWY5FiMMuL+A8RHBzlty/DDRPHxnS80lW+p6pB+Uez+r0cW/+8N9E4OxzOMjABFjs/1riyu0FL3W9BNbqaw7Lk62/D6qmtL/IyNNfmNGV1oU0jJeUDsPaEe0MU5bX6ODPJtQIJ+f2q4feFjdlbPWLnato2XEEgwkcCqc1+Y9QqNbN0QKIVLHSoq0XzluJOVulLphC/xfi2lAo1CriAKWjkD9aLA4/RhpgKkdoPpCQCqndqc6NB3PEGsIl3u6SbCWFPKo3Ydxxa0y7lnkSHvG0w+e0swTHedT2Vy9ipEJnyzaUSJuqzkbm4mGhrH+Xqf6X3724dMZhqW6KwH10d/yrzIb+Nz1DOF3I2HBv94y4+Zrh08f5s1aON45aVQAcGrIYVcP3Az+rF2a759pMvFP/ZCWKWkeX3IQwFt0u tmV14tu1 zH+1UAtu40QgylZcpFIx4Mx/buHYx2CzgHmscix9qjtBHvZSqD1RiWKWr802H3S+/EjK+e1O9aCezgCzb5tc/ohWVMGNOzVMvyj2dMSeetrmWZ5HqgHqCYLJMgzjD0jwYx8pNvoV9lULLEM4XHEvzgB68JJPYOKjP4JvDBNWQz4oZqIXi7zzebTZkuCQN4iQy+F7opyHbUiLHomvC6vU3HXY2v59kf6MD5oAFWzCCadh8RESrPEtEY363/UExpCtVchPYR2TXlsHZA86NykYK86LKHSfv/FVZBxGnEg3ENBXmPpbUhgirE1f0oAkfdU7Z3IAJiUt20Lh4iBxubBD08jQyYE0qgr2YXkFY63o3phO88RAY1MUssdjkWsIhYqZjJXdurjiTAPhgqtI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Oct 2024 19:53:10 -0400 "Liam R. Howlett" wrote: > > eg, "check_the_cheese()" versus "cheese_is_fresh()". The latter name > > tells you what is being checked and it tells you what a "true" return > > value means. > > Fair enough, how about resize_is_valid()? Sounds great. Although I do prefer cheese_is_fresh().