From: Andrew Morton <akpm@linux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Jeff Xu <jeffxu@chromium.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Jann Horn <jannh@google.com>,
David Hildenbrand <david@redhat.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Pedro Falcato <pedro.falcato@gmail.com>
Subject: Re: [PATCH 1/2] mm/mremap: Clean up vma_to_resize()
Date: Thu, 17 Oct 2024 17:00:33 -0700 [thread overview]
Message-ID: <20241017170033.6bac2c50f609f6c63c861783@linux-foundation.org> (raw)
In-Reply-To: <hwz7y3jqi7ynxwtqzisrlo3zrdkdwlfb45nb4nixjcontpiry6@mdtki5al2no5>
On Thu, 17 Oct 2024 19:53:10 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> > eg, "check_the_cheese()" versus "cheese_is_fresh()". The latter name
> > tells you what is being checked and it tells you what a "true" return
> > value means.
>
> Fair enough, how about resize_is_valid()?
Sounds great. Although I do prefer cheese_is_fresh().
next prev parent reply other threads:[~2024-10-18 0:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 20:17 [PATCH 0/2] mm/mremap: Remove extra vma tree walk Liam R. Howlett
2024-10-16 20:17 ` [PATCH 1/2] mm/mremap: Clean up vma_to_resize() Liam R. Howlett
2024-10-17 17:55 ` Jeff Xu
2024-10-17 18:07 ` Liam R. Howlett
2024-10-17 18:15 ` Jeff Xu
2024-10-17 21:08 ` Andrew Morton
2024-10-17 23:53 ` Liam R. Howlett
2024-10-18 0:00 ` Andrew Morton [this message]
2024-10-16 20:17 ` [PATCH 2/2] mm/mremap: Remove goto from mremap_to() Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017170033.6bac2c50f609f6c63c861783@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pedro.falcato@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox