linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>
Cc: David Hildenbrand <david@redhat.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Matthew Wilcox <willy@infradead.org>, <linux-mm@kvack.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH] mm: shmem: avoid repeated flush dcache in shmem_writepage()
Date: Thu, 17 Oct 2024 22:25:03 +0800	[thread overview]
Message-ID: <20241017142504.1170208-1-wangkefeng.wang@huawei.com> (raw)

The folio_zero_range() already flush dcache inside, so remove another
flush_dcache_folio() in shmem_writepage().

Fixes: f530ed0e2d01 ("shmem: convert shmem_writepage() to use a folio throughout")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/shmem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 163ca6107bbd..bd5ba016567d 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1533,7 +1533,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
 				goto redirty;
 		}
 		folio_zero_range(folio, 0, folio_size(folio));
-		flush_dcache_folio(folio);
 		folio_mark_uptodate(folio);
 	}
 
-- 
2.27.0



             reply	other threads:[~2024-10-17 14:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 14:25 Kefeng Wang [this message]
2024-10-17 14:25 ` [PATCH] mm: shmem: convert to use folio_zero_range() Kefeng Wang
2024-10-17 15:09   ` Matthew Wilcox
2024-10-18  5:20     ` Kefeng Wang
2024-10-18  5:23       ` Barry Song
2024-10-18  7:32         ` Kefeng Wang
2024-10-18  7:47           ` Kefeng Wang
2024-10-21  4:15             ` Barry Song
2024-10-21  5:16               ` Kefeng Wang
2024-10-21  5:38                 ` Barry Song
2024-10-21  6:09                   ` Kefeng Wang
2024-10-21  7:47                     ` Barry Song
2024-10-21  7:55                       ` Barry Song
2024-10-21  8:14                         ` Kefeng Wang
2024-10-21  9:17                           ` Barry Song
2024-10-21 15:33                             ` Kefeng Wang
2024-10-21 20:32                               ` Barry Song
2024-10-22 15:10                                 ` Kefeng Wang
2024-10-22 22:56                                   ` Barry Song
2024-10-24 10:10                                     ` Kefeng Wang
2024-10-25  2:59                                       ` Huang, Ying
2024-10-25  7:42                                         ` Kefeng Wang
2024-10-25  7:47                                           ` Huang, Ying
2024-10-25 10:21                                             ` Kefeng Wang
2024-10-25 12:21                                               ` Huang, Ying
2024-10-25 13:35                                                 ` Kefeng Wang
2024-10-28  2:39                                                   ` Huang, Ying
2024-10-28  6:37                                                     ` Kefeng Wang
2024-10-28 11:41                                                       ` Kefeng Wang
2024-10-30  1:26                                                         ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017142504.1170208-1-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox