From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE1BD3C533 for ; Thu, 17 Oct 2024 21:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC6286B008C; Thu, 17 Oct 2024 17:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D765A6B0095; Thu, 17 Oct 2024 17:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3DA26B0096; Thu, 17 Oct 2024 17:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5D896B008C for ; Thu, 17 Oct 2024 17:08:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 92DC7A0321 for ; Thu, 17 Oct 2024 21:07:56 +0000 (UTC) X-FDA: 82684331814.08.12B0006 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 93EFFC001C for ; Thu, 17 Oct 2024 21:08:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rlo0+Rhz; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729199221; a=rsa-sha256; cv=none; b=iI7MBe/oF60Di+Q2/dVoLUqTdZ3ZqdMWKvCKr+arTqDJwf6bI6kSUDSe/LyMAQoTkAjUh7 vwkoDStzi/El4Iw0EGGi1OGU3oVjjvXf2tzRg9flGtH3fznyY0J3GcKIjd69HumxdWAXdY b2Jj4Ywn39cFBoJibM2QNzQ2LRPWkms= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rlo0+Rhz; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729199221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uyGHr58itkPC7N+4QA0osERxcVg/qXp6WfmWSvzS5NU=; b=BumFQcDH84xvYwi4s9AdL3PU9b7YUfqrT0WZk1iM25PZKY7m/jLEBNx84MeHImLJf4beQv rsRracGNdlUQzzZtCo0d249CMyal5qZ2bTtE8GAoNQ7VR12+BHF91kNVXpvFU3KCxpluCh T3iRP+hEbqvvEWOqRMjFL9k3Nkfb8pQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 378825C4ADF; Thu, 17 Oct 2024 21:08:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DD27C4CEC3; Thu, 17 Oct 2024 21:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729199294; bh=ZuuN+2bvokfFHmLl4MuEabN0US1Th7GC0dpGBGVvyio=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rlo0+RhzRlEBqivcUdgCxS+YHhstPpDiza/dZOS+DHsDH9S6tml3AjfiTNapUT0LD dl8T7ugnXrduJzjjqHXncSkh03bKoxEpmxdFAH/V7mG4nNjLsfWDl+UzX6IYGUhfzl kadt9pG0ClTio+RuG4cf8vNNCcYVpDQhgy/SDfoM= Date: Thu, 17 Oct 2024 14:08:13 -0700 From: Andrew Morton To: Jeff Xu Cc: "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Jann Horn , David Hildenbrand , Qi Zheng , Kefeng Wang , Pedro Falcato Subject: Re: [PATCH 1/2] mm/mremap: Clean up vma_to_resize() Message-Id: <20241017140813.fe555ec947b17dd035e4c0d7@linux-foundation.org> In-Reply-To: References: <20241016201719.2449143-1-Liam.Howlett@oracle.com> <20241016201719.2449143-2-Liam.Howlett@oracle.com> <4izjonpaqhkx6p3csfyxcjicgqahbmj2k6gupazehb3l7xhnvi@twlvpx2wc6ce> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: snrjoudrgmbtfb19afjyyh8p7r56c8g9 X-Rspamd-Queue-Id: 93EFFC001C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729199285-3097 X-HE-Meta: U2FsdGVkX18fcvJu7H+UGKzBdmIgUEq8+be45wjDopvMOSy62QLaNq8rAi1tHh+AyUUEGPaSRYyr194Qn7HoMVzQubMqX0zCJC0iI+FRsmr7XqpbPMkiiak0BYHLx6/elBToHy3NLXFPmZNLEPWLY4Nca+zikBLQ5H3bPAlYHiiiS+/RmU74njfcDxbKDldNSOViH8AmoqPC46kg4aCpgd7Y8BXGTwHPo4RH4HvvIRD2SsqLjng6DH6aFE7A4xNj4WJHZ23wzSpBJ3RahFjZb47qumCrMmKO7jkmpG5WAzyat5Ehi75LOFKP1T7RRBv5iHrHZmot0JS9OwYnxw522t1+fRkyO2Uy89ge22WbLSZJ6Ayp1fbSLKo5/Vi9opmDu/MNpA1RGIsb2rwrztqTwPY3W6HOyKY1pxN36DJfeZ9bADXto3dASm7B+/csJaTW8bxcM0yNtDOUPcEjMfkPJHIs8C8kj9ehwMhIM3mvBBCO8Jxz6AGkV5grydwM3PF/ci5bwm1qvu5RhKxqET4BUoXhvu07WCljR11FLuZ29qRULwI36wRfzlurkJxgAUqPDm2ywWVPN4vwOTRVLuXyYCGHt7SWap2mWmlZa03aJjLXC2/MLhX7dfuXyxxjhulHMaLT1+XxHoH0/maxxi80HObhXul7FCuwZXRkkdpKkHf3NlXhascyWbFSgORxfn1DPOI7xROw3en/1c6RRKZBCr+onQMJfN3w1Pr36pTWOCdP2tokV4Ifc1ci/GpT/UM6qqtW0bG49grJOkIqcpxU6wmFJcul7FYk7M0q9ZvoVeM4W+ByJPvvdurJrw829i1vT8E48QIRv1FB6U4I+mH8S6gVnzWhlxufWQ59GfcMSNaU2TxBzvd+pQifI86FgcRyAUZBA5fBuOFsyh9OXfI4JBNOFOuLYHksC6ACM7aqMJf+UzgX4+tK6kPGQEkseby1u41tbCrO9DGUSlwGFMX 58Mvpjtg 4a2eIOUvXtdJnhMZWQxZZoCxcoOHLMBurzOgWdcUnhjafX7LuWN6/9nC00mWpQKAVnNrasuvNILOWTw5XWu7g7tL8wAcN30fNH/Xqf3dsOdiCHwkabCVuC98d9RrpKHf6a07cYokFGK+z8YrIh3s8puUPmatkHppB7KyGrizVsd3AwmeST7BUxNiNQ6taHLmXRFNXGjqp6iOj26u+RdjgzCPHfYpaflbjLfDuuh8MOht7gmPVZf3Cv2ZtJl090Qv7lg1GDXObpQxVgrOK0RAMy6sNe/MHGyZaDhfdeMvvvDMISTTSqtyFFKDX7hV8Rr3istPsYHLvG1GHgQ4tJQ+Xt78PZWPlCHIbPA0tD9kTElM+rD3QgvYfc79H9qro4zif/7vcf48jJfeKUFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Oct 2024 11:15:20 -0700 Jeff Xu wrote: > > > > -static struct vm_area_struct *vma_to_resize(unsigned long addr, > > > > +static int mremap_vma_check(struct vm_area_struct *vma, unsigned long addr, > > > The original function is vma_to_resize, and mremap_vma_check is > > > missing this context. > > > Maybe mremap_vma_check_resize is a better name ? > > > > Good point. That suggestion is long though. Perhaps > > vma_check_resize(), since this is a static function in the mremap.c > > file, it is fine to drop mremap from the name. > > > I'm ok with that. Any function with "check" in the name makes my teeth ache. "check" what? And the name doesn't carry any connotation of the return value's meaning. eg, "check_the_cheese()" versus "cheese_is_fresh()". The latter name tells you what is being checked and it tells you what a "true" return value means. Also, the dang function isn't documented. Also, why is mremap_to() calling mremap_vma_check() without testing its return value? mremap_vma_check() doesn't actually alter anything, does it? If it does then it's misnamed.