From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>,
"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH v2 4/5] maple_tree: refine mas_root_expand() on storing NULL
Date: Thu, 17 Oct 2024 13:46:06 +0000 [thread overview]
Message-ID: <20241017134607.30206-5-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241017134607.30206-1-richard.weiyang@gmail.com>
Currently, when storing NULL on mas_root_expand(), the behavior could be
improved.
For example possible cases are:
* store NULL at any range result a new node
* store NULL at range [m, n] where m > 0 to a single entry tree result
a new node with range [m, n] set to NULL
* store NULL at range [m, n] where m > 0 to an empty tree result
consecutive NULL slot
This patch tries to improve in:
* memory efficient by setting to empty tree instead of using a node
* remove the possibility of consecutive NULL slot which will prohibit
extended null in later operation
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
lib/maple_tree.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index a90c29156fe2..15d2124acc36 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3335,6 +3335,24 @@ static inline void mas_root_expand(struct ma_state *mas, void *entry)
unsigned long *pivots;
int slot = 0;
+ if (!entry) {
+ /*
+ * We come here in two cases:
+ * 1. This is an empty tree
+ * 2. This is a single entry tree with range [0, 0]
+ *
+ * If this is an empty tree, the result should still be an
+ * empty tree no matter what the range is.
+ *
+ * If this is a single entry tree, we should set it to an
+ * empty tree if the range cover [0, 0]. Otherwise, we don't
+ * need to change it.
+ */
+ if (!mas->index && contents)
+ rcu_assign_pointer(mas->tree->ma_root, NULL);
+ return;
+ }
+
node = mas_pop_node(mas);
pivots = ma_pivots(node, type);
slots = ma_slots(node, type);
--
2.34.1
next prev parent reply other threads:[~2024-10-17 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 13:46 [PATCH v2 0/5] refine " Wei Yang
2024-10-17 13:46 ` [PATCH v2 1/5] maple_tree: print empty for an empty tree on mt_dump() Wei Yang
2024-10-17 13:46 ` [PATCH v2 2/5] maple_tree: the return value of mas_root_expand() is not used Wei Yang
2024-10-17 13:46 ` [PATCH v2 3/5] maple_tree: not necessary to check index/last again Wei Yang
2024-10-17 13:46 ` Wei Yang [this message]
2024-10-17 14:10 ` [PATCH v2 4/5] maple_tree: refine mas_root_expand() on storing NULL Liam R. Howlett
2024-10-17 22:21 ` Wei Yang
2024-10-17 13:46 ` [PATCH v2 5/5] maple_tree: add a test checking storing null Wei Yang
2024-10-17 14:12 ` Liam R. Howlett
2024-10-17 22:24 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017134607.30206-5-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox