From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E21D37499 for ; Thu, 17 Oct 2024 15:34:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53346B007B; Thu, 17 Oct 2024 11:34:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02FD6B0082; Thu, 17 Oct 2024 11:34:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F18C6B0083; Thu, 17 Oct 2024 11:34:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 722656B007B for ; Thu, 17 Oct 2024 11:34:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 73B6681358 for ; Thu, 17 Oct 2024 15:34:39 +0000 (UTC) X-FDA: 82683491688.11.24567D0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id 913C740024 for ; Thu, 17 Oct 2024 15:34:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of "SRS0=o9TL=RN=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=o9TL=RN=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729179169; a=rsa-sha256; cv=none; b=5w0bVN0l6DzSaJM23oA84/xT2LzraoQQDrZ8WVv8AYVmDxZQs+nt6+DsfvFB8qsmwYhy0S C3w4cneG5gEu6mhu4bMfk+l+keIKPhZ2KeADAJty5vSHmhQFhhvBuzbNLl9DI6S5EikM67 tpnT/sPFTCMtCt5/IZY82746leEf00s= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of "SRS0=o9TL=RN=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=o9TL=RN=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729179169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8uvdJJtMhQM0BlLRDZIrk4gS9WA0Ztt7+5eIGzcjpA=; b=lWHt9i4EeWOVVlK23LLaIjFhjOOECqHJTNRt/PoL6LaWoeZP3yTFxOhyxz5vTfebk0vM22 qB1Oz3QB4hhxwjd+xBTnWqXUeO1Ex9KstndRqrL4nI612URcMARZcv0FaREueExxAX+Tmn MTAQXhw1wZezSbG8GBrBbWjVwK9O0pQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 492E1A4412A; Thu, 17 Oct 2024 15:34:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1027DC4CECD; Thu, 17 Oct 2024 15:34:38 +0000 (UTC) Date: Thu, 17 Oct 2024 11:35:02 -0400 From: Steven Rostedt To: Mike Rapoport Cc: Peter Zijlstra , Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 6/8] x86/module: prepare module loading for ROX allocations of text Message-ID: <20241017113453.685ba175@gandalf.local.home> In-Reply-To: References: <20241016122424.1655560-1-rppt@kernel.org> <20241016122424.1655560-7-rppt@kernel.org> <20241016170128.7afeb8b0@gandalf.local.home> <20241017093515.GU16066@noisy.programming.kicks-ass.net> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 913C740024 X-Stat-Signature: iuyf5i76sjeytgpfgpzi3ipd6ax45a45 X-Rspam-User: X-HE-Tag: 1729179275-696979 X-HE-Meta: U2FsdGVkX1+A0E3/5hwPzzQjk75T3ozxy1g8QO1HWIErlJey+5V/4aqQ+dufhuMrkbSFgQdl+3OHM/cdvuo44I+9Qqlx7M0WYg0MQ+jXFM/C38lGohiR9slFyCipE8CfxUN9ITj9GJ1HU1fD/9vl87C4Li0iOrvlmPEYpac7dUZjc0oOoDQMSDCl/oG7yK7N+v1NiG3lF1aQ8WW6gzmcL94W58bMJ8Hjau9vFY7/VJUhhrYnmYa6VUH92x6ThnA2V2jWoxOtdbxDSh+sGinjQvKF41C/f5bYrI4ubamaiv78rjxWGsWTgQN230LbM3nI+WZ8lsDfZ8E+o8x2hYS82ay4uxDrVPIFHws17CisECEwz0dsZ6n+dMSyNwWftCGUBoSJmN54e9/676hIOBFy3k8/Pd2fz4vFyOp8OQnDJV82tEV34gqC6JqxRy/MxynNN8p3RYdNJeqDQcbCO8ZlPzhwCxlTSQMKQkAILF7xyIbpUw+GVx9B+ODeANMedKanU23krOCrKjT5igU2vnwp5sYhCPO30/X1ZNfg2slJMirgLfQnxPNmSYY8bzlfvELLz32kCPXE/zQ3wSTL2/6p7pqrg/cPs+PYthsBR4CF6LtR/QTeyx4GLvfhdvLuA9YB7YELuG8bKQGVYiwTT0L+7/NBIW85Swv25jq2aq+Xcdtgy4tz5DfSY7shRDRp9iZHBamx1eUgbJgxZV/5b+Dk93SJS/MrdLHonzjUVfMhuQ/rc9fZfgrwow9HKTCRd89+mlwfier0Xu0JOzLg6MTQmQ+DCKhOs7d3cAyEi/jGV3+GiILzRiW9OPgVYLSfIHb39ZGU7M+sNHIhl1VaRXZJz4IzTOW+iGjxtODh44RK2e8tnFf67PGM+Co0Q9WYCWWU7orPxZW6YgE29Zfj3UeEWlH+5kEclTshTh36F75oUtNXdI3uPnIMTRUOz/QE6a7Liv/QXblqTUcVrqsggBR HZBsDzDs SS+dM3ucRsjqYptx3cXXwBZFEB46fo3BrTUAoU9ykCToRX9ItnTFjoGO5Y5eKtCVIWe151SldMdIPzP+5q4DyjF+lzePE7ibsUCjc3G8fPZT9LCDUTBBhEic2UngLwUd/o/S6kGFKW9OZ2K69Iaq2/yUvrT0qBcD9RIYWKQ/W8GjXVsUm/JM4d6nFqZAN+a1y0qZN/KQ4O4LR4h+pjwd8jZMnuRdfFlaVYqF79FInhJkKi7e2d7hdDQ68BXvgOVZeCrVTEiKAc9DR7a4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Oct 2024 14:25:05 +0300 Mike Rapoport wrote: > With this series the module text is allocated as ROX at the first place, so > the modifications ftrace does to module text have to either use text poking > even before complete_formation() or deal with a writable copy like I did > for relocations and alternatives. > > I've been carrying the ftrace changes from a very old prototype and > didn't pay enough attention to them them until Steve's complaint. > > I'll look into it. I just posted a patch where you can see the effects of these changes with respect to ftrace patching times. https://lore.kernel.org/all/20241017113105.1edfa943@gandalf.local.home/ I'll be adding this to the next merge window. -- Steve