From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DD3D2F7F0 for ; Thu, 17 Oct 2024 06:23:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9661D6B0088; Thu, 17 Oct 2024 02:23:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9CD6B008C; Thu, 17 Oct 2024 02:23:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615306B0089; Thu, 17 Oct 2024 02:23:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A7E96B0088 for ; Thu, 17 Oct 2024 02:23:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D7DF180E82 for ; Thu, 17 Oct 2024 06:23:44 +0000 (UTC) X-FDA: 82682103462.14.1383BE8 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf28.hostedemail.com (Postfix) with ESMTP id 97026C0009 for ; Thu, 17 Oct 2024 06:23:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kp0WP060; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729146184; a=rsa-sha256; cv=none; b=2/3DxaeZmn10E9s8OZqmm4AMWq3HUqZMxB/OfiucMLw4nsRHvyEPzv0eTpL6+UrXYb9guB vIhplAPSrlAgOePHSeSOm4RVW0dWgdnDKyH0BvlHNlvtkKHWImt0o42fG4bgg1dssnRWO4 KM9tQbLwKFqo3EZeBFfHnj/DecEq5f0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kp0WP060; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729146184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gv1gltbbDF/5j+IX9+hAlWmk56OtAem0dayAMHJ1ctQ=; b=3ygw1w/gnR/v86Vzlt8WnyWCpRpq6N70EYlR0cI2J0YhFYmPNIRuo4Anmu9vYSBFhtAXPt On2bIgabn+oKC1Onz9ZOhR2eudft+xBKbrSjrskMzXUgwFW8Yk3xFonfl2+u3JdpDC8D30 Aln049HPnN691L7xGnG4ib7g+bJGm2k= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71e6cec7227so484946b3a.0 for ; Wed, 16 Oct 2024 23:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1729146230; x=1729751030; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gv1gltbbDF/5j+IX9+hAlWmk56OtAem0dayAMHJ1ctQ=; b=kp0WP060ajXrxdDieleyTKLSnNF+7wPBkpWuFPJUL0C4VLqv3bLYC4A0VrEX2rckzf kos8ro0ViATi5L6iBC+IglAYhc/blJXw03ZZsC5O0kiftHt9b5800Xc5X72kYBn7t4cp ADR+pfsvmwKRXWoStQK6vPeLlLv1GuMfGxvIDxO0GXys3ixcgR9Tk0EwHaUUIaTgfzd7 E1x8RF1oLeqqWunDaEGx/ouw2k1HL1VeNhOfKeSeuSYlKgXRanukF+S6OOVMFYiE82wi 7dYASdM5EfKGBcPtWoHAskFZ50oeA6+W3D8357ULx4LcvMj2DKlEQsytJiwetLu9hXtv 6FSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729146230; x=1729751030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gv1gltbbDF/5j+IX9+hAlWmk56OtAem0dayAMHJ1ctQ=; b=JrnPlULuvFb9XgTAV/VALR9P+eP/f492DaHzWLZwEc5MrzuFlqveUGINKvA4et8ww2 2KTx3VSeXyv7cJlgpr8cLiFfzm2Kjaj/IVdaym6AF98W6hACo+r6gyetPhoVQQ8ACOQv k4Kq+SjA4ymkC4m/jfOah0SEbCsZXS2/FDHcauGtP/CtOOOVYdwQDIzFs5r5DOfjCMEb pMcxovrNyWu+hl4fD6K8FJ68m6iYVBH9magrh5EOJhYqb6qppFDhfaYipwKcD91SQj89 tb6TwOEbt2DPH/8pgVuoDjkU0APP+JDQ0+lnedewq/w2sE8aJfyMtHDwlGFmkAvW+6yl Vgog== X-Forwarded-Encrypted: i=1; AJvYcCUThEQsnpp03hOHEB+ROxBQvyMpDof7bmGbPcS+MeIeAx3vdCL5HPzpbcppJaqNo9ZNLYyswCeFEw==@kvack.org X-Gm-Message-State: AOJu0Ywzo7dxT2GqdJll6JknpKz2PrNDUg9uYO6A6a0gW00Kc8Ri0S2q t99/lxJ1o/Feckd8tiKivQi8IxOsruoFZbXZRVhPaSZT4d11o2UwQsPCkL6SdUE= X-Google-Smtp-Source: AGHT+IF5NhQ/b88MCiGtXpRGy2ZGg1UJAGucFvHdX9TN0OpriGsikVwPLjZ/EKzAJpvOMtpl5EEigw== X-Received: by 2002:aa7:8886:0:b0:71e:6728:72d5 with SMTP id d2e1a72fcca58-71e7da89997mr9027762b3a.15.1729146230504; Wed, 16 Oct 2024 23:23:50 -0700 (PDT) Received: from GQ6QX3JCW2.bytedance.net ([203.208.189.9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e774a2b37sm4042683b3a.112.2024.10.16.23.23.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 16 Oct 2024 23:23:50 -0700 (PDT) From: lizhe.67@bytedance.com To: willy@infradead.org Cc: akpm@linux-foundation.org, boqun.feng@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, longman@redhat.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Date: Thu, 17 Oct 2024 14:23:43 +0800 Message-ID: <20241017062343.81825-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 97026C0009 X-Rspamd-Server: rspam01 X-Stat-Signature: r587iqpee444b799pa4r4p7k6wiqmoaz X-HE-Tag: 1729146222-473565 X-HE-Meta: U2FsdGVkX19F5GiI8XWwNsuntDS68HjQXwlLUlVQe0Q2L9/73MibVr9ESJ/YQ6tZrThEVeKvV/gA8xg6uGaYU6+xBRH0E/PwulvGrAcEDSajqPE2GgLhtZgjOg3PNOxR9SyuvkS1ohe1o60pcZ/rXSSNO5S+JjWrUiHYCUE2sHSAu0ldRluik+MD96qRiHnShxDI1bQv5Aa7ynUeNGxGhn1WtHxsTZ14Cz/Yb8kBp9kPk2reOIIwyIvep87zeHxP9F3LDia+I4C3tI6QylEwc+EEFX0xGMbyx/uZBnFRpjy3/ylTflt37rq8zLfETQXm/HyVHlPkoOd710hEg9kL3nVudabZULKRBQqSZJrMdjVM1xdwkTnvasaSOAXgcVeOCet0l/8iyTlfC6rYf4gDAygiODfLNdtnW0+y5FvSmINqCC5P2OOc3qFTLWpNQo/PuvZh8qIHS2nQqhbgEk32+5BNBwboiymTeBwdd0gXD3xVj2W2+iQs5c7eDtijTLQ24Nq3TPb62Ov67pKHF7BgTJxFcq+3ujQHs5FuiTuGAaWlrVbz14YBTs0btBfDrmAvY1UltZJIhKnG8dq5NO/QJ4c0FKpw+SxEdbBjAoq9UxY4XhxHAgFg5OcOKJa5gT3k2WFmta3CB6rKjKoznjW1/q5T7u9dEtunTn46jRcciKrB5bZkLX0Uh4Sj3Cy7l2+EIMoTJGpbeatIMJ6xdD8+ExnibeyaebJ88kLJ6lgrG4E7RrXhTdQPj5o9ShXsY0AyGsmDyUGlXhbPLlCySZambBcHBgETch7upD6W9pQl6GNyzwU8H0bfTj/6HVt5ORN31ielw3fv5yD/ZVijiF/lDH/SA9sdgTsb3eHSk8RWehW900hq4HAeXar0ZFIiUxyUMOQI2Gwjo625XuCqacMw34FaY8pGuv3gISeUrhIChfVPMRVpkyNZBBNfcKVB5TV83uz/dIYJE2FloEuTv0w nslVoig8 OYb7F9OSphgvQjBnm6u6OkB0czfNkNiW/VRNPXojGnxMczSTvtRiDZf38AJYJz47VGYhZzepMmJjK1UZquJ7ItGMqi9PLg4db0AuNZUTQvQw7cGpeAFoCsImc7bvB/mOc4ar597NpYAmoRXs8wyINmMr3M0mfC7+zFzJzZ/HsHxahJrxvXOqtFcQfmtYJ9tkKMF6Vjl/5ujRrcr2NfVH+U6UkZkqw6Pjw0M2y1gtGBLKeFetU8HW7jbnv/hkzuww8bxqz7oMdNkcaCvS3DHaBg1gZS7lOcftMaU+7OUexISmcgqCk98Elg45UtUV4hwB/F2P2b1BlJFCfoMF/iDV1dBm7RODKt0SW07WAjWLtk5QD71XQEzjjxVYpTZUo8fbWZJVS3pED/8WOj4wBfIy4arVmkMHsfDdRmxje1+iN9pnU1Xh5Xdqm91l+2QAtJYzAq/ttQQDcUOt975Y+7SrZNY7PkH6Dj1pGgdTqA3Kt/cwxX1E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 12:49:44 +0100, willy@infradead.org wrote: >On Wed, Oct 16, 2024 at 12:35:59PM +0800, lizhe.67@bytedance.com wrote: >> +++ b/include/linux/rwsem.h >> @@ -249,6 +249,7 @@ DEFINE_GUARD_COND(rwsem_write, _try, down_write_trylock(_T)) >> * downgrade write lock to read lock >> */ >> extern void downgrade_write(struct rw_semaphore *sem); >> +extern int upgrade_read(struct rw_semaphore *sem); > >This needs __must_check, and I think this should be a bool, not an errno >return. I can't agree more. I will fix it in v2. Thanks!