From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CECDD2F7F5 for ; Thu, 17 Oct 2024 07:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DB4A6B007B; Thu, 17 Oct 2024 03:14:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1882E6B0082; Thu, 17 Oct 2024 03:14:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 050C46B0083; Thu, 17 Oct 2024 03:14:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC1906B007B for ; Thu, 17 Oct 2024 03:14:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1C94F410C1 for ; Thu, 17 Oct 2024 07:14:39 +0000 (UTC) X-FDA: 82682231646.14.4177478 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id A4774100012 for ; Thu, 17 Oct 2024 07:14:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zBrQfXoS; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729149165; a=rsa-sha256; cv=none; b=Q9wexaPgBpGt+0+9z1lXnX6Fp2F6xlm8xS8etV27R5S6e4KJiVjjs5S5Rp7UmChSdkJU4c +tCGwKvSDd+2mUra/Z4Nq45RebO5uwruxm1ZE60NA69B6tS/NJadA3akwNJgOF8y0uOt/w 7ceKKL32W/0IT4bHkPcmx/iWbNNROP4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zBrQfXoS; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729149165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DyHEce+PcX0ijXuXfsLIP5QNLRUXTmHx9NYy/RmvDLs=; b=2DS1ZBkazQ1Rk46fv5vGGbzPqyiz4QB2nAIqT5JNMtuyB2a1s/3HhQANNzSQpifv+2S0RX +PYZW/UJEblh+OKLRkk6W9oQTCehvDWxksASpoQMcG+maXZtmKlsrgSJMLIFasTpMfWySA nDPs+tMCVgxe/67/cP8ZkDGLo//IQNk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3B32A4361D; Thu, 17 Oct 2024 07:14:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 472C6C4CEC3; Thu, 17 Oct 2024 07:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729149282; bh=uNzEuamxD/Zyqn90TxU3o2uEqJ394EoOeZ9AkxHXUCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zBrQfXoSoGBX6d6N7gQ+Ft0j4XiJZIamj6wjYqMVAkaCPU5Wi3gBC6jjVrXmT4JLe 5lTh+S6jzS1oy9MUrzIlcFWji9HA99+YLOrKjIucbqfU7G43sLa4u/9mrEKFAMkaWx WvhvPu31Uy4Q8I2op8lUdse/Gqny7qLyWdshHvzk= Date: Thu, 17 Oct 2024 00:14:41 -0700 From: Andrew Morton To: Anshuman Khandual Cc: Nanyong Sun , shuah@kernel.org, zokeefe@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged Message-Id: <20241017001441.2db5adaaa63dc3faa0934204@linux-foundation.org> In-Reply-To: <37ce9dfa-3193-4e11-bfd1-d2c8b60b0090@arm.com> References: <20241015020257.139235-1-sunnanyong@huawei.com> <37ce9dfa-3193-4e11-bfd1-d2c8b60b0090@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A4774100012 X-Stat-Signature: g3nhg4noh43rbpmibfaocys9ng8ixsak X-Rspam-User: X-HE-Tag: 1729149265-662430 X-HE-Meta: U2FsdGVkX18sJ+RQpnR8O2hAt1xvI9PVx9tEEQQVXK9RVBQlrdkWbF20iFlZ/takzjeMLzvtE3YN2M0St0RrJRt8FqHyLVP8EyM+uvPuSKN68k1VZmyi9eHCuW/hKIY8Wvt6F9t5Hf1nl3g6jvqkp/fzttDRJDBezwXck/4r03pxQ8Qq8+op8IEAu1k39XL8JV9fskwuhcrlnUEm7duJkXePiN6ij/n1+IMDe6UE84wmI6Ig9kLceH0PB1jmsAM3D0+t8yRnCREds7MGlsAqDBp6CyhS5PwW0JobxllB5yGya9TmtCL9aqBtKBHGk6KGMvvJshWz+2vvmW7AdoO3tQPmHypiUE1oJ9yH+qyEPoERqXBsNcZrSb4ub8NMcHcWZ8J+JzIyVVsBcr51orH3ir5u4gLoaFBCxD364+J/PjFtCFVkAVYpgW2UMfONqwNsWKL5MSZ3H26QfJ8IOcuvDBVMe0cT4j64OH6RPUSPgHkBIRs9TQ1Bpmsp5D/YcqjQZWFN6fsWEFxdLMzlN2cSGW1JNCZTEnWCDPgpwo0TjSPX0KWRaHqdfVLx1zHxCM/L3KNoSlJhptfOOu8NwV1uEyiRKtzBJcD3W7bqlCTUdUZCbUF9c49orxwGpjQ3Gp6mdVFGvq+fZkZWkIkj+rIxnsx3M33jdqNeDZmZJF0yvLLVy23S0C7DME7XaZPXDHIcfVp550agYW+gVrqnBVgsud0r3vhgxCo0CZKWYSvMPSCztYkNBjhaVEzKrOkAdU6hwaUWz7mxF6JbelNN4wn+bKNbW6h+uGja+W5s8mIzVtEeUHzuBqWk87C18Pqn/uIrX6VjyaM3P+YBRhU1QxiJ4aLICMDnxnz18oiaWN4f6HDnibwLo5XITxAjZ2aeD4itCEvrXWSGRLu9I69wERjA7DwZkIaie8NdU77IWdwDWYlF5XMhLyfKwU0dwhnAFFJeAxmiZQZxE6Or2zDeboN Kn2OajsG hGc2qc2v/ivun00zOWn1B+K4heqgIMskVVd8jxxWHcinstSJHKiDYtaNOY0keqEDDaQXfpoKejE5SXMFjXx+EfwZIRDmBLcRN5j0WZVThmhyzscPsm1gfHNrVMUrT9oxG0QNPmMfBNp9PmCbKpXM5qBUUfimTgr+niWarlHJAG1AEpTf2dkc5T4wdHXLC4jgR/1Wk2sBhr5hhRe1tGwAQPOKFt7m4eeWPR5/ElnxmaYdqAVF16nMh9Xne9TD/je6HQgFDzF3scOJeGo9oDtto8EUHA8+u19y48137GJ6HR3h97MZMnyyQrHJJZUMZzCit36BUR6qmz+M8RJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual wrote: > On 10/15/24 07:32, Nanyong Sun wrote: > > The mount option of tmpfs should be huge=advise, not madvise > > which is not supported and may mislead the users. > > Agreed. > > > > > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") > > But nothing is really broken here. This just fixes usage information. The usage information is broken! > Please drop the "Fixes:". Fixes: is appropriate. It tells people which commit introduced the error. I don't think it's serious enough to add a cc:stable. Others might disagree. > > Signed-off-by: Nanyong Sun > > --- > > tools/testing/selftests/mm/khugepaged.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c > > index 56d4480e8d3c..8a4d34cce36b 100644 > > --- a/tools/testing/selftests/mm/khugepaged.c > > +++ b/tools/testing/selftests/mm/khugepaged.c > > @@ -1091,7 +1091,7 @@ static void usage(void) > > fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built with\n"); > > fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n"); > > fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs must be\n"); > > - fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to work\n"); > > + fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to work\n"); > > fprintf(stderr, "\n\tSupported Options:\n"); > > fprintf(stderr, "\t\t-h: This help message.\n"); > > fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n"); > > Without the above "Fixes:" tag, > > Reviewed-by: Anshuman Khandual Thanks.