From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4957D2F7D3 for ; Wed, 16 Oct 2024 22:55:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B1196B0083; Wed, 16 Oct 2024 18:55:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7602C6B0088; Wed, 16 Oct 2024 18:55:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F646B0089; Wed, 16 Oct 2024 18:55:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45D1B6B0083 for ; Wed, 16 Oct 2024 18:55:54 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 67EEE1A0C8A for ; Wed, 16 Oct 2024 22:55:35 +0000 (UTC) X-FDA: 82680974292.06.A521CEC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id CCECB100019 for ; Wed, 16 Oct 2024 22:55:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Iye5OD2K; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729119319; a=rsa-sha256; cv=none; b=AJT8wInecUHyS9GRgSPHn0p7CC/60wxf4E2ntu3RJyl+i6vjq/5yx/Vd0HXhej9uz/fqrl pTBoMOJp5g8KyrLiW8S93u9Vzz2N6oeoEXvYUUBRQEB5W2yn1jb+Da6iyE62LvBecQUj30 r3xAyYO9WvrSwmu6qv2z41Zou+yjFok= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Iye5OD2K; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729119319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/cSb5v9UfezHIgQSbQtd4tGeYRPw83F6lhufU/W1IwY=; b=j0CTh7Sn2XFN3dVXy/32ijVEMGWeXjRwbvt9akm51IAsIB10NalJDaiCUjg+JNHHEvjSyO kbucwboD8/8gYDGK5Qk/HPRnQ6JNA4N5nHp9x371oZdZLvxkAQjI2pao/gV4GJWhDi/Q2P MlqWz6FH8DlNN7y4qAruMw05vcyt8/Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D324B5C5C76; Wed, 16 Oct 2024 22:55:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1226C4CEC5; Wed, 16 Oct 2024 22:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729119351; bh=bT2JLjZZKc7+vXZL6LB9hRUEx0yRWfaUyoEzcklQZP4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Iye5OD2KhLQdb5t8pJDtrEhGRIJgUe6Ecoc0jeRc9weQzJ10pmoEILIRE5u+QgAl5 hln/UELTBxTf2++S5mrY6sZshB+hUHHTpDxojpA2smbi6uKn+AJyGz1GEmwYSIHYp4 iokrlb/FzZh1jCLJKI2udjGBCV7U6vNierV2j9KA= Date: Wed, 16 Oct 2024 15:55:50 -0700 From: Andrew Morton To: Yu Zhao Cc: Wei Xu , Brian Geffon , Jan Alexander Steffens , Suleiman Souhlal , Axel Rasmussen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/mglru: reset page lru tier bits when activating Message-Id: <20241016155550.9ff2ab4625c7f19b6be8b7e1@linux-foundation.org> In-Reply-To: References: <20241014221231.832959-1-weixugc@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: s18amn66wt5n7bfney4gcxgfowst5ra8 X-Rspamd-Queue-Id: CCECB100019 X-Rspamd-Server: rspam02 X-HE-Tag: 1729119341-287213 X-HE-Meta: U2FsdGVkX1/8yVQvBelTHIgSqMnCfHfyJuVp+uE0ZXJt7P/Yp+YvUw71/W23zaw9TKZJfF66btlQWhp7GzPm0JWN6Y+wnmlyFzSVDBDfBwSpU4YopP4pbpQKtIRuu1jlAsiVT1ISfTWeMPg82Afp6IJjNQi/XILMJmCJr6qDhoO7ZWAMIFIO/YgOrywtzGQR2+ntGi3VwGbWMHWq/Jkf3NyxEruCItlLSQmZvtFZfj/wNiCfujZxh2nrbFQqP/Y0urG1Dg72mXDC3hR0B+M0ANPSZGACdS5Nd/ms8tbpVxB1un4b9iaQKHeInwzWZ3kMY59/s/DDKYyWaLR5r3y6dusSuIXhTwu6bXjWWRObKirCzksl0CWEvOyVWIOKhi2W8zkGevraYVFBuZyD0PqsYG9Vo1H12ls+ckI5SzL7vH1DHA+vFQOQeezxYqfOs+wRPZRKckBimtFBMMUxlCSqRrn/7wOTflND+cMZCkU7nRWBQ1pAPazXQjVFTuqhbdQGycCEEOCSXEcqNHupzxn79zm1HJj/uQJD+fj0/kOaTJ+C4kn2lqPalPCwJBT0eLbimLQxyKVivqVTMbbpaaMSRncpYZ1AjsZB1ZKR9mAcNDEjBrspnxJuGErWspxr7RBV0moQvm1Pr5eQk0Ae4MzhwC29hPvT1LruPlwGgrQbMTzMJP4SjpmgHTjpUoJkPEJFNz5uibDPbnhwXYWETKYHrRU6ZgVuHSpJzOShBOqlfvcgjfF6Ef4/xyDeX9UIJekw1GDPD1fJyDXcIIuOfDkEKD/Hl6nyhGlPi6FN93Gpzp8womh7BC2lxNIH97ne3WhGpKLOPr2yyvyuXWNhnvYojw/Mm3YL0qVzlYc+iAo9E3sNix5XIu+WFP7X10VmWLwfebgmD+xejVIqtTE1EVVDaCdvLmJffI8/tpmq/5XER22iE2y4lplYQ09M9Xz1ZBFRHqBXYG0Jmkfgr76eeiw MIokJAs5 LtdjZNQqNsA+RdzmgbzckxkkPJEb0LtS7BBwQR8cP8iuZT9EmE/MY3Btbvdud30FZZ33Hv1MUnn7iUWAaxGcrYTsBBvLx7Ha06stC9dFoE83LVfNemgkV1Q7/73VAWMeTPRB0AUvTBqIwUUOS5dARsx+pkLTdWYb4MEeptQPX2DgQLTL+BMJ+y9gDWexNt2MJM5REn/kNsXHEXmSZ8FNBlM5Uintr2hsRzZwHLGTEoKzTMZ8FEqfL9NYGE1bMrIs10pmn6xnj/qq0RSpzB1HyHwyJkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 15 Oct 2024 22:55:23 -0600 Yu Zhao wrote: > > @@ -257,7 +258,9 @@ static inline bool lru_gen_add_folio(struct lruvec *lruvec, struct folio *folio, > > gen = lru_gen_from_seq(seq); > > flags = (gen + 1UL) << LRU_GEN_PGOFF; > > /* see the comment on MIN_NR_GENS about PG_active */ > > - set_mask_bits(&folio->flags, LRU_GEN_MASK | BIT(PG_active), flags); > > + mask = LRU_GEN_MASK | BIT(PG_active); > > + mask |= folio_test_active(folio) ? (LRU_REFS_MASK | LRU_REFS_FLAGS) : 0; > > We shouldn't clear PG_workingset here because it can affect PSI > accounting, if the activation is due to workingset refault. > > Also, nit: > mask = LRU_GEN_MASK; > if (folio_test_active(folio)) > mask |= LRU_REFS_MASK | BIT(PG_active) | BIT(PG_referenced); > Thanks, I'll drop this version of this patch. When resending, please include a full description of the userspace-visible effects of the original flaw, thanks.