From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA992D2F7D2 for ; Wed, 16 Oct 2024 22:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E8D46B0089; Wed, 16 Oct 2024 18:44:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 498136B008A; Wed, 16 Oct 2024 18:44:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AE4D6B008C; Wed, 16 Oct 2024 18:44:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CD466B0089 for ; Wed, 16 Oct 2024 18:44:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 88035405BC for ; Wed, 16 Oct 2024 22:44:24 +0000 (UTC) X-FDA: 82680945522.03.082CF52 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 4AE824000D for ; Wed, 16 Oct 2024 22:44:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wr1xkzLI; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729118636; a=rsa-sha256; cv=none; b=gBY7DoK/TB5k2ckFVmiNEVOQcKkqLV7ltl/5CISXVl3JykYgwPml8J+xTrOoSKxFTFYrmq rNvG/9tHFXdPwJJ3DMEe5C6lD6Ne8Aa0rTPwHWXoHYyc4LZnji1D7gEsa+twh0b7zrRsyB h+568SUp/Lwn9340WHj/5SdFBwpnVkc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wr1xkzLI; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729118636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BLSdDUXmAvvkg/ODHeQ0Us7T1GvzPnf6FLS3oIfzUaA=; b=wNknSoQoUSA93Wd4GNRUwQT2h0I908hb55orQ1/1zx4zd9yzIaA0IgCTg3e06ooKahl25u 9pXSZsXizshaI290s6i+jMgVgxg35uBfRMKFoHL9y09vo9YyXjp2R/mpmH4Rlps3YiqM85 gCwkuu0foL39yCZPJxbbHp//5T8diaA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 00F155C5B1E; Wed, 16 Oct 2024 22:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFABCC4CEC5; Wed, 16 Oct 2024 22:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729118668; bh=BLSdDUXmAvvkg/ODHeQ0Us7T1GvzPnf6FLS3oIfzUaA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wr1xkzLI/AASHJrsd4eVLYSG4xhWVUGeQrndEJSmbi7vZ0C5YnXbpeTX2FngsSV6f jVfp1t2p9JnLUZVFaqaFh7Y+eRM8UjlVq5ZanrDDx0jYiK6i4ygbwE/GpawnGDVJCU RH+fntL+SN2yTdKSynyQzNOafu4TEEPHierlByBU= Date: Wed, 16 Oct 2024 15:44:26 -0700 From: Andrew Morton To: David Hildenbrand Cc: Qi Zheng , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+7d917f67c05066cec295@syzkaller.appspotmail.com, Jann Horn Subject: Re: [PATCH v1] mm/pagewalk: fix usage of pmd_leaf()/pud_leaf() without present check Message-Id: <20241016154426.8d946e3e4f94914a860bd7db@linux-foundation.org> In-Reply-To: <0436c217-0afc-45e6-949b-2291ee1ebc6e@redhat.com> References: <20241015111236.1290921-1-david@redhat.com> <4898fdf4-7c88-4697-9df4-64fd8a900e95@redhat.com> <0436c217-0afc-45e6-949b-2291ee1ebc6e@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: dxn685m39iaanx4qan8hheh1t4gzhcrm X-Rspamd-Queue-Id: 4AE824000D X-Rspamd-Server: rspam02 X-HE-Tag: 1729118657-472745 X-HE-Meta: U2FsdGVkX19jzpu+YjXsu4w/MAKQZPK5NcYjIgU6giXeHoWOsZqOXPWLdeexuY9Kgowa/E4aCJQcVK0wS6BLgfcDqYa1olFTp5RFDgf7D8kzgJqUWU0Zmo007cfrDL+TluBEYoVM3Vwxh6dIqZcYEFMNjkkz+KePtRVtwMERNCgQfVq3dz0NT7MSynW+4oVc+n0S95WuBHwl3gR6GMdRtrgRbLtYjxBQasihmJMf05lT84q5MxsDvAay1NU2jZo0pswAH2d2fSgrpKJ6DtJAp8qeCaf0rjU3LmWExAxeSocV6UQ3LS6RZSiQGNQjkyirPdz1Pk12mvlZK3CeefuTyxL428EvxkSRGjqtPZeASFx4KEHnJUgEEv0YoxJYiXRHlHHtEzy0ppU86CU8rcqyr9kRuEfx3EQoyFyOAyF/3s91c2SuKGts4Pd82I1c3Rtx+DPXyv6ylv0QnEg+QifVm7ISxOjnXt8BTgPvmEuZLCi1HMiZL2gdCVD8qE8W++PhjPdKHC519SS6ItD83L7pppESceZ6tZVeiDHDGUz4lciYhOL3qc61VohLjuj2YE9r219aHz4n6UV0KE5nXUSdbz6t/KACPhyRh6oz5MWE7b1afWiP7x549J/ivdmakm2jraTYHNPtilQKsmsiOcWEiqWuHNMJuS6FNrE2CY67mHI3w6sNIwKMFgJRi+W9iMogrAJT3cift9YDXJfLv7ZVU0HAWmvQ3aLyxrSmSL5lHjqjfIC3q0Qn3nPbSSKlZuR2Pah1t1VnGwCyjrkM3fxByJdiOR6lLdMoS3StHKH6HggHZtZJpJSs1pQZyJ6KL81B416ZKmAJD8Sh58tteuGPBv9MPZ4ou9XbD2ejvCdb446uHxLvk08fB08Kz3nB9qwqVISZ911bS/P7h8saVvccH8Af64cGroFk6bHfZrxIEqUIIEqFlbgfZprXVJZfcO+bq4yJx6q0Rca6xqEWTDU hOv1OqxC wV0q6ef6d3BbzQcoBCsLX9DXPL6Mgg4mGUUjdjV9Zw8oi1KrSUxeZCMp0VTp/rBmEHNZ4Jvv/rkJ6ysxZZDnqrNCvC3t0KsTZn5YfMZ6VGMky+N0U/WomB7TUHqQBb6VDtDer8nt0ILouZphC4laU0GWLQG88QNIKcqJ3MVdCs1JYBmVAOF48OLCY6NTdcMCHzkd1b8hPQ1aUlEjrI8iIqpukQloAjhUiOPIUDu8+Td1Y3OOFRlmHoa5S0atdIvATpOerSuypzzX9GWyx1N7u8TQVadlw0PsSzY5yiStwQ02xv9Zs4LgT+mPllkA/x5FTobtW5kQumaGTu+euj37WDgjwT7YUh0cxAExScXKTJLSq4p7N/6ovm7lZo7L1OYlw0JwWssumwKPzGL8UAI0c7cdAINIAnXWxdsg+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 13:05:54 +0200 David Hildenbrand wro= te: > >> [=A0=A0 54.372227]=A0 do_pages_move+0x1c5/0x680 > >> [=A0=A0 54.372972]=A0 kernel_move_pages+0x1a1/0x2b0 > >> [=A0=A0 54.373804]=A0 __x64_sys_move_pages+0x25/0x30 > >=20 > > It would be better to add this call stack to the commit message, which > > can help people find this fix patch when they encounter same problem. ;) >=20 > The commit is not part of a released kernel, though, and a lore search=20 > would return the result until it's included. >=20 > Before it's included, the commit message won't really be helpful :) >=20 > But sure, @Andrew, can we include that in the commit? Done, thanks.