From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505D6D2F7D2 for ; Wed, 16 Oct 2024 22:41:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4386B0083; Wed, 16 Oct 2024 18:41:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B74576B0088; Wed, 16 Oct 2024 18:41:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3BC36B0089; Wed, 16 Oct 2024 18:41:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 833F86B0083 for ; Wed, 16 Oct 2024 18:41:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E55C84098E for ; Wed, 16 Oct 2024 22:41:24 +0000 (UTC) X-FDA: 82680937836.20.C4735EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 8CFCFC0011 for ; Wed, 16 Oct 2024 22:41:18 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RsQ2oaWC; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729118441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0awTVQbvkrdpjyxZ4IHa4TVp8LsEvrcJ36+8YsK5Wrg=; b=d7CqcS5giHB/xOuWTS4lq0NioBA3QJCslLc5k1l9nMeFSfds3G7q/84WLIQPXHVP0vsvfY Fh7UqxXx8OFalPM0+kZPRjpynnVcJGQrVyJU7w9mARgzEevhGBeHREweepf4M3rfT+pFMg lEDc6X82zwgGEvXnvIvCuBlJABVXZ6g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RsQ2oaWC; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729118441; a=rsa-sha256; cv=none; b=WwTDis8NLBeTDW2r9DP+IYr6Tu26EqvJYXYEGrUY2+0RwsrtRH1RaxmoojUq0t2gRutCjE XaC47XF9KGE4T5hrN+UM4a0CsxFyZNkbp3yZ2Hkl1m1NVIekylrxIPa2s+prLHMNYTIFtr S/he5502YSpeWXZXY6ChV/f61Kt2DJk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 22DDF5C5B8A; Wed, 16 Oct 2024 22:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2239C4CEC5; Wed, 16 Oct 2024 22:41:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1729118488; bh=Q5W0ZogIf37LVk2LLoADzxo0M3GONipCWt/BMiZHnoI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RsQ2oaWCOoTUPLdcsvbRvsd/julwO5aBAfMpXF+bp/T0jF1ycpZ/FGE6ibvFpVAyd aRkI60vHXx45gyZ+g32+/TDmtu2c4L9o09Caqh/iFAnF4EtcdSIA9aleWOhtCwkttn nlgKqsITd8zjRfdWtGoYSlA1Vi45Ueu8w9qJpD2I= Date: Wed, 16 Oct 2024 15:41:27 -0700 From: Andrew Morton To: John Hubbard Cc: LKML , linux-mm@kvack.org, Alistair Popple , Shigeru Yoshida , David Hildenbrand , Jason Gunthorpe , Minchan Kim , Pasha Tatashin Subject: Re: [PATCH] mm/gup: stop leaking pinned pages in low memory conditions Message-Id: <20241016154127.3e369be7398bd0c3db27e8e3@linux-foundation.org> In-Reply-To: <5e499b63-8b38-4ddc-82ab-848301fd8d2b@nvidia.com> References: <20241016202242.456953-1-jhubbard@nvidia.com> <20241016145739.770543d44313967f611f3810@linux-foundation.org> <5e499b63-8b38-4ddc-82ab-848301fd8d2b@nvidia.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ccu8nzdr956sabht1eu4aujwihgtrj9x X-Rspamd-Queue-Id: 8CFCFC0011 X-Rspamd-Server: rspam11 X-HE-Tag: 1729118478-18791 X-HE-Meta: U2FsdGVkX18BMFrSVNGEDrLb9fwclkQvAeTsHoubdtflVPPHudpssWWdXN/F/Yg4dST0QAQIBmjCcJZOPu3x3C3lPHvGzgvgQuDoxjXgT9BtRA01BOh2aq8xaDomwXyUohF3u+3O78j/UxHiAoultIHrxb6m3Yv0Ax2Zt2+jTlGsJvgpuVrVbwCkN1MvmBAjQxRwYak0ZyWEXoGXtgtY8rCtoyPjUd6RxwcJkAsZc+Jk0PWmtakEHBboIJHE9nFO4/bdeK4bslqG5t+GvccxM4A7FyPIXnhNWvsY7AofYIDiop5cvSwJOxB7oPTWMl0G/v9UKXIXBlYg/QORLg+8r8QhFP3fw8HtOh6ilbgu5UFPD9gjDE+lCg1vGn/i458V994jESwIwBBUjoxb8XxCV1wvX1+4A7mhnogMo1enApuMHZrWsF4STRTtDi53A/tc3QAZVdav1IXO1ojU6/8ZkRCn4VD01kjY83/G0cYz+hLCt2jc5H8FfBSeh0ClTt2XqXDTz099O2vhK6fuengJaulz3MrhpSHzqWsiez/P7qfg5OazR9zQW35ObMUYTUMRWZKru+Hrq1bCnnKFnytYbN1NnJC3cJyUgttrtugNNF1UQudZxFMr95OWlva9nDr5s8xCovqKdaGDg4uspFZLILwpAeOTtmQ5Y1f2yuURQhOzBd4ek0C3JOyNVCQXnNzH65ZceHTfW1j1/xdhf7AE2QfKAviVghN6euvRGn9KLLN9s0QfwmYnB9C8ogO1W+G8kXqs+20xah5lVLimlRyLe3SdCCqpuhLipH3WeAdtcnEcFrvSLQch55e3IkgL/qshGbJyuyDy2JDv7d6sszZz30RH1GuMtByDpXYoQFWfIJHGvm2a/cuJ6fTTYXSXjeuFaLKXVYdUzB5a7Z9iIL7siCuv7LhyBevgfwBI529MVf4NL0A8xAvl4wxQjmOegEU85OQnkpLVN5xpJaVrJNL KmarDW1X HhEH7x2EsFtaR86TLdGyaI/nMMawK0uB1nf3he3kUGcZghWgIxzxeTLvGRdT+WALnc048vgHHtOQvzJ6s6r6oWsYnrxMmQCpF1xgLSNgLQnBVcVp9LhrU8jE7s2G8oJKjhWaazVG6lzXBdEZn3YQWflltx6MJ+GLuWQgkPSIRvs3rBNhpxHFAbM2EjuwiC5xxIMRYLqH5Yn17OSDstpXnN+2k+lUdmHL0TiE7YTRf2/ZuIHbC3SFwf0YDeWD4xEldFOOm9m95osP6OPWiPMrRCJJDsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 15:05:28 -0700 John Hubbard wrote: > On 10/16/24 2:57 PM, Andrew Morton wrote: > > On Wed, 16 Oct 2024 13:22:42 -0700 John Hubbard wrote: > ... > >> Fix this by unpinning the pages that __get_user_pages_locked() has > >> pinned, in such error cases. > > > > Thanks. > > > >> Fixes: 24a95998e9ba ("mm/gup.c: simplify and fix check_and_migrate_movable_pages() return codes") > > > > I'll add this to the -stable backport pile, although this seems a bit > > marginal? > > I'm on the fence about that. It is marginal: you have to > exhaust memory. On the other hand, a real user reported > this bug to us. > > I guess I'd lean toward "correctness in -stable", and > add it to the pile, in the end. Thanks. It's a super-simple patch, which helps the decision.