From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C94D2A52C for ; Wed, 16 Oct 2024 15:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B3326B0083; Wed, 16 Oct 2024 11:38:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863206B0088; Wed, 16 Oct 2024 11:38:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72AD86B008A; Wed, 16 Oct 2024 11:38:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5189C6B0083 for ; Wed, 16 Oct 2024 11:38:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D514540762 for ; Wed, 16 Oct 2024 15:38:32 +0000 (UTC) X-FDA: 82679872632.29.6A4B645 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 6D856180020 for ; Wed, 16 Oct 2024 15:38:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bKQgcL0b; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729092958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yHkxVSM7kyk4fkqXakCMn2hmNl9XJoFNo7BerJALfRw=; b=l/nY9Ra3H85tnO2jIPTokobr0GOumCTHBFVFUPlbIFf9gCHau37qKirt5lTO3OATxF3fPU 1eMVrio1Jmzu/DUdD9hyjVCIra5aDuTWek93l51TZF2Vhb3QKPr1HMdMAEioRV7N1uuiB0 6B4ho5B2M7axcHQSEGtVQmN0JUeT5Xk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729092958; a=rsa-sha256; cv=none; b=gEQ6atNL7XHPt+nxTtEj0Jtmh9ZpO7iS9suLyNlSB6Y6U8Ip1cjdR9GlO5tZzhvUFZjy4C FYnaNdmWEqKPhLhaAg50IXxZz/rrgcpe7wOKHG+kYtdPa1g4BUjTSZfof58t6ME0c+IqCW OZQuDQ9drOdTaP8DTt0DMQoV5b9Q52o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bKQgcL0b; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of nathan@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=nathan@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 72FB0A43E4E; Wed, 16 Oct 2024 15:38:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 822A7C4CECF; Wed, 16 Oct 2024 15:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729093116; bh=29ow3Nc5Mi5UPGBCiX3p6gcTOJuG3+bSE570gzg2QgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bKQgcL0b1wNTfytC/wVDlDeCvENl0LBhevXSYBUE6VlyPM3bJDSngob4BdYyiv0gu liwk3uiMiDGYjffxQ88BtNfRTwJa0Fq9saX+1ckbVQ/Nl8BqRflJkkPissKd0Y9ALT V3p/0nYyXNdc0sUEe8LO8G+MYGYALfpZjfvvfMzws63VP30VSLsUwpgKiwrmakoczQ /R7cIW5+Ozv+JNkHJvg/OGx8ILu7V9uX8G2bg6vip2RzJrN/5/anTjhiozWeP5DYi9 7uIFbk1u4w2UeZQfqQ0v2ku2HREFlTTHcBgmirERU+muTV4V1HgoV0YW8L/b9TT79y lVcUqkDFJOAVw== Date: Wed, 16 Oct 2024 08:38:33 -0700 From: Nathan Chancellor To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Guenter Roeck , Arnd Bergmann , David Hildenbrand , Jonathan Cameron Subject: Re: [PATCH -v2] resource: Remove dependency on SPARSEMEM from GET_FREE_REGION Message-ID: <20241016153833.GA385255@thelio-3990X> References: <20241016014730.339369-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016014730.339369-1-ying.huang@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6D856180020 X-Stat-Signature: jnqhb74rt9e93xc3neiqac1zwzori4h3 X-Rspam-User: X-HE-Tag: 1729093115-291528 X-HE-Meta: U2FsdGVkX18vUPGOUu9cR1zE+HS9uQmVrjzk9lHD33VfjYRSdVmw621p7DnIE8MSiiXeQJRnLR73EZ3TYZJ+eYOSLeIyafCZS0jmNF7+bb4dO3hACFI/JSZ3N2z48Gr0J0s3Ekju0FG9aZl7eyLacQ7BeckqU9GkICZfB4hgfOG9j8XzgvWdqHdJdxJsFfGFiatYeEC821wETaWra9Inbcm8LVhDneiihZIYmaZYEsQutpzww09RDinh4j8qJz+On2P+WtXgws2TU2IHWAXzmmCHz+PN2isuQW4iZBuGPRFUeMzTFGfxODoo7jAGbzOefsuuzAweCucU/OqNM0fhnuDmydybLXeW52WJUy7h/De42B/HrWnGEyKXdzbaBPsytD3ZL1ViSgVIRLdo5jWCXDOgBWsEtv8wM2MzEXOmuTp4WAW0N1VOzigYShBRqu4qvmnDpfwD6tZamMqmCdwNhfvDwx28CqHlllMi9sjjHG3XWUFVxDpuDRB9RjOJObgSHOtRduWHcwOkL5GpcfzgHQ//3zURn9hhav4URp26UCGKgZSWl3tISr6SezHJea9YzbDzrSrfnh4ZBaXNsy5hzbSw1KuvZBJumZnsBTS4LVlF7925yHbJdRQusLrmdxe909tKYicls0Stz9RJRH0xmy2IVaaOI6p57PZVo2kF+s6G6vPnYhlG7BYvklWe34/w4CN+C/PuZXc/n8eB6FRj/DZw6RX+IU8b7YECYtnzG7cPKvRBzuKK82dCSeLH988AyrmlaVz+fZPcO6A73Xz6PwtHmB9yItNjCiyOr8qcf28BO/Rw6QmaUpE12HuNaL8b/tJJYad4Gh+Ai/3GYiRMJFnShj2bymFg9Nw8yNV+BXq2G/ymMcUGHCLTP8dz8VJtqwL5qjSA9bUU5ny2Qr7Blylo+JxOlQGC0NJdwT1PnQrIk/7Rok9s0PAcjwwv4qzpkuJGZEpxiZ+djlom9R/ lyNx2BOT pr4P3rCrTocU8/oCewGY+NnEaX/crLSHi14eQ5p0cvwARrfuTY1iBCL6UqBIlGxTJMd58EEAIt3aonR0L4jwRLVNnCZSu3x4VcDjYWs6QckuoefG9k9OZv7Le+W9TushhgqAlamfSC5h6Oqa6mvOUSSS0RtRSnNt/HD30GkYlvUPRSyGBwRaRGrwpD8BjzihUcdLq2NgSFkfQFmL7WQSh7hfpq3DuNJaZsQ8cyTUDkMzBK3o1kltzIS2YCleYfE6DLsrKTsgV2LZ4VQldvgKKkZ1RjbTnd9/GaFHpnkanvb9KM5oAI80F9oIQL+S7BdZPaBQYMRyy12ZivZxINHbqCfZsWc4iCskNN/N+jc8+eVR0gCYI6Hv7VPzUwE7Xdszqq94euBvPcmJVSTxWWAnaOuaA25dGC+w0C/k0pyALWPlvS0Wj0qYXGtjBZJs8/yo9ga+WLdtf+AHMCSdo56WNyf14cvk1SqaWEpC+dtQ/cl3uUhQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 09:47:30AM +0800, Huang Ying wrote: > We want to use the functions (get_free_mem_region()) configured via > GET_FREE_REGION in resource kunit tests. However, GET_FREE_REGION > depends on SPARSEMEM now. This makes resource kunit tests cannot be > built on some architectures lacking SPARSEMEM, or causes config > warning as follows, > > WARNING: unmet direct dependencies detected for GET_FREE_REGION > Depends on [n]: SPARSEMEM [=n] > Selected by [y]: > - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y] > > When get_free_mem_region() was introduced the only consumers were > those looking to pass the address range to memremap_pages(). That > address range needed to be mindful of the maximum addressable platform > physical address which at the time only SPARSMEM defined via > MAX_PHYSMEM_BITS. > > Given that memremap_pages() also depended on SPARSEMEM via > ZONE_DEVICE, it was easier to just depend on that definition than > invent a general MAX_PHYSMEM_BITS concept outside of SPARSEMEM. > > Turns out that decision was buggy and did not account for KASAN > consumption of physical address space. That problem was resolved > recently with commit ea72ce5da228 ("x86/kaslr: Expose and use the end > of the physical memory address space"), and GET_FREE_REGION dropped > its MAX_PHYSMEM_BITS dependency. > > Then commit 99185c10d5d9 ("resource, kunit: add test case for > region_intersects()"), went ahead and fixed up the only remaining > dependency on SPARSEMEM which was usage of the PA_SECTION_SHIFT macro > for setting the default alignment. A PAGE_SIZE fallback is fine in the > SPARSEMEM=n case. > > With those build dependencies gone GET_FREE_REGION no longer depends > on SPARSEMEM. So, the patch removes dependency on SPARSEMEM from > GET_FREE_REGION to fix the build issues. > > Link: https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/ > Fixes: 99185c10d5d9 ("resource, kunit: add test case for region_intersects()") > Signed-off-by: "Huang, Ying" > Co-developed-by: Dan Williams > Signed-off-by: Dan Williams > Tested-by: Guenter Roeck Tested-by: Nathan Chancellor # build Thanks for adding the Fixes tag, as this should go via -hotfixes. > Cc: Arnd Bergmann > Cc: David Hildenbrand > Cc: Jonathan Cameron > --- > mm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 4c9f5ea13271..33fa51d608dc 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1085,7 +1085,6 @@ config HMM_MIRROR > depends on MMU > > config GET_FREE_REGION > - depends on SPARSEMEM > bool > > config DEVICE_PRIVATE > -- > 2.39.2 >