From: Andrew Morton <akpm@linux-foundation.org>
To: Jeongjun Park <aha310510@gmail.com>
Cc: hughd@google.com, yuzhao@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, syzbot <syzkaller@googlegroups.com>,
stable@vger.kernel.org
Subject: Re: [PATCH RESEND] mm: shmem: fix data-race in shmem_getattr()
Date: Wed, 16 Oct 2024 15:16:36 -0700 [thread overview]
Message-ID: <20241016151636.7e2184ca7467a0f8f90d940c@linux-foundation.org> (raw)
In-Reply-To: <CAO9qdTG9wxBSct-rrgG_DevaLZgy4AFirKu+3uu=HOPD1-PRBg@mail.gmail.com>
On Wed, 16 Oct 2024 23:12:43 +0900 Jeongjun Park <aha310510@gmail.com> wrote:
> > Therefore, when calling generic_fillattr() from shmem_getattr(), it is
> > appropriate to protect the inode using inode_lock_shared() and
> > inode_unlock_shared() to prevent data-race.
> >
>
> Cc: stable@vger.kernel.org
>
> I think this patch should be applied from next rc version and also stable
> version. When calling generic_fillattr(), if you don't hold read lock,
> data-race will occur in inode member variables, which can cause unexpected
> behavior. This problem is also present in several stable versions, so I think
> it should be fixed as soon as possible.
OK, thanks, I added the cc:stable amd moved this into the mm-hotfixes
pile for a 6.12-rcX merge.
prev parent reply other threads:[~2024-10-16 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 8:08 Jeongjun Park
2024-10-16 14:12 ` Jeongjun Park
2024-10-16 22:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016151636.7e2184ca7467a0f8f90d940c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aha310510@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox