From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5DCD1AD23 for ; Wed, 16 Oct 2024 08:13:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DAF46B007B; Wed, 16 Oct 2024 04:13:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58B3F6B0082; Wed, 16 Oct 2024 04:13:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 452826B0083; Wed, 16 Oct 2024 04:13:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2736F6B007B for ; Wed, 16 Oct 2024 04:13:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C6E4E41B0F for ; Wed, 16 Oct 2024 08:13:31 +0000 (UTC) X-FDA: 82678751190.28.52A9615 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 34C9280017 for ; Wed, 16 Oct 2024 08:13:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GhcNMOsJ; spf=pass (imf30.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729066271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JtG6b2NVxTkV9p8jCjA1H+O/WXABGIu57jSCxGsFYsQ=; b=11dUH8t0izh/5UTjqicxhG5gQ0I6CcSndmyB8i1YUFy0yedsn0hy3Tdg+ITjcFTdm2Dx96 PIPAZvPYWkrYAxGBH86xAP/O2+tklfiYJoSiZZj3Hs+hy37cLkb2B8BumLYhzyavmqcp1l rGIYQk28qZQbKObg5xfZgKmy6eBNDaw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729066271; a=rsa-sha256; cv=none; b=NkSfkuUth0pOdfdTNjCmGb36zDM+YqadK1lGzdr7Vbt10TShtUt2Yzr89MYM0s8TvC41I4 PjSUOQTjW63WVpvTg25AyFhWp5wnxGXv7HwQ8+ln9rFNYdoK17KkRnVBdb0EhbCytA7Pmg 6NgwWic1VOqukHS4YsU0iU70STbn9Tw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GhcNMOsJ; spf=pass (imf30.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-20ca388d242so34673965ad.2 for ; Wed, 16 Oct 2024 01:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1729066413; x=1729671213; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JtG6b2NVxTkV9p8jCjA1H+O/WXABGIu57jSCxGsFYsQ=; b=GhcNMOsJ8nVWsvAL9oyp+ab/TXoobGozE+nlLXvOzXIeKplAm/2cgiIAT7ema8yjwX /1aHnoS/esqT7T7dutpvlpkt2hVdC/ROCLhnhhLJyTyLCNE2ObGOwTBRVJImlUtXA9XH 44U5iqwo+JdRARlVDXRF2ELH7sYaXli2zcTZe0k1Sd0pftwJ/6pyg5sbwHDDlq5tjBdL lYly0KkkqOoex6m8blRW4pwcgGhpBye5kujiWjMHsKicQWwuK/gDk5/2wIcs12x+FKTr Atxr75kiSS6D0p6aMYychOms2UFwkr6ocnHIb6sImQptgYYWWggLimWevyCHMR6y7WD2 cdQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729066413; x=1729671213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JtG6b2NVxTkV9p8jCjA1H+O/WXABGIu57jSCxGsFYsQ=; b=A+L4dEIBLCTS717eRKRickpJ8Ei/xxF7ERsmQAOpOGrPpHePNbaU7NPZNXpn3r2c7D wxhfr9qq3QF07TXxym0JpkwHAYWvfm1ORzOjXBn7B0xv7X5oDEPJstMTX2OHJq8eXpU6 zWSCIfYE25TL5Ipq88UJ0jUyMwVMLlMd48shZ3ew34Fet74cxSq1IRc/tth/7QWesnxZ 0kOAml+kqy8ATpgqGjm/I3F1JQfsrHBoakSBCtSSEHvpKyBYqd30uGBJpgYqkT9pTKWM Lsy/iXla5YXYlvwbnmh24FhxuNPEvg1aVwNZItTy+prUOo5ZnhEwQ0d6PFz0u6iWBPqW zzmQ== X-Forwarded-Encrypted: i=1; AJvYcCVS2uMvl6GdQf7YF0U78H1AZjnl3GLivNHvV5r4oCd70x+CdIlDiaAu+ku52O3fGPWkBouTPcXOSQ==@kvack.org X-Gm-Message-State: AOJu0YxK7uiCFO/LHM4yZ4WDVKdlFAoFSGys50FIyaqbKwyZrpgzNngY p0WuyGmqEmBOXoHOphFM5a8XsDtzyLSaCZ/NtLDJ2v+fixD6IGDx0hjnAlpNFgY= X-Google-Smtp-Source: AGHT+IHZLOY/8uCT+YzO5BvcN2dZ04an0Mp2plL55IFvjie8wwlI4YAPfrv7CIkhfHTVsEk0R005uA== X-Received: by 2002:a17:902:c952:b0:20b:7ec0:ee3e with SMTP id d9443c01a7336-20cbb17d5eemr254331975ad.11.1729066413524; Wed, 16 Oct 2024 01:13:33 -0700 (PDT) Received: from GQ6QX3JCW2.bytedance.net ([203.208.189.10]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d1805af9fsm23745675ad.241.2024.10.16.01.13.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 16 Oct 2024 01:13:33 -0700 (PDT) From: lizhe.67@bytedance.com To: hch@infradead.org Cc: akpm@linux-foundation.org, boqun.feng@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, longman@redhat.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Date: Wed, 16 Oct 2024 16:13:26 +0800 Message-ID: <20241016081326.45277-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: j8wea98pfjo5wt8n6bjgmpyt1dqcqqpb X-Rspamd-Queue-Id: 34C9280017 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729066398-703167 X-HE-Meta: U2FsdGVkX1+8HXZdLt1wDG8hRg8O7TActWm4iCGN9O8CYAvqHOr4XF/r7LyRqQaY3iqEJFAMOh7aR+jiR8FmnpbbIBrf/fS+WrmOvB2OdTVy77z2APEbGvzOcano+S25vFO6+TCZgzLwQVmO7dlti5+mx/7M9eI7zd6UGsE8ZQRxy/H4A6qbA/n8fbxZQZ+Y8UawTY7TNrTCoBZizxVZU/F+yKri+bVC8AnVTt2kTpTTXVPVvMalQYKGwtEdYdBWwrUTkrFLcUw4YlHHW9Q9nuNRRnmMyfGaNZ3NZXlnKgJhZ8cM/IcHxV8fk+Jbdi0doEAlONms2gcw0HcMhz4E/ZmPonH5tKxVm9bRVM21VCgmKLj6feoX903qEEpYo/qLhp8bOml838S9cY7jiVfZBzAUa06D3Z9qwSN40IHUlJMxVACVu2yCO5xJd0m+QStpFzsewJ219nHI4i3zKv8cmLi+0YplhwMQu7kvRky6cSnmgWMYtxmmChnCZQHPVGckkXYH4JBcvbdVYXxPSTxWJmvNRQo7KudBRpHCKxKe0ifwNw5h20ZjubROYyEd2q1/81fZ5KIiCiN+/q8+TmrTVdW7aGcZiEeyVBC8HoZFzLKRGNMFvN41yfnA4/5RqETR/GkqAzuc/r7VKoHPYJvo7pQgGqBoNdwyRkrLR8VYWECysQ2WiDliIp1u+G1huyjbemlB4ptfkq74VXm2bgjzg2Lb25rAS8xPXOYl9kwbi5br2K24PwPMquzUmTdGhjOve850DPzYPbQ3KRHj1wkuHO1YZg5XVq72rE4g37fANtAfShMZktKyVI3g/tyIb12Ls0L0FYU/e+i/AZTYVI4RThA4oSSLZrldolFgaAPTWmV9QTJta7t7g9Q42CEHxkHEhBwefyNMj49bzedsZokNzAE+W0aTWuoN3d758G0OfXG2hfpETDCnayERATtJNh75ylEC1Wssi4HhxOa/Yel L71z7m3B dikWrELi0EhR3Zdklj+5WwPJSJ4KLf1h9UvvcMsQNlOGmKcygJsq+MXALEQzzoc3JCWlM5wM66EtTIqZZeZ9IQgJa6K4lQ49grDm+1UUQA/b4jVFtKx/poMYdCo7xCc7qBEhsSNS2Rh9HtXVC8aE9TxMCsMJ8POrrVrG5VI+9fHESLOKYPsPHQcB1KXkwS71QR+psN7mn5NJKgvvZvblq4/mMO+pNsEf/D9538VvnmbeNnB6mRtrxP3n5S1IiYKLrvnXP+AiZ00PS46YCKT36uUgomdYJwM2VcfYIjTNqcLy2yyYM4qmJ5R8hwIQwilK8jbYRg1cPAGXItyndsxif3UauSx1sQuiZgjX3XGdtcTOGo3yVKiOIBAfJLo2hsVB6IXsq5QmdPyLrWOvb5yu/xoMQUkczpWwcufYucMSDHRLxUAowbXDjbXoWDBNvTEl3pVcB+rngs387oK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 01:03:33 -0700, hch@infradead.org wrote: >> OK I know what you mean. It is indeed OK to remove "extern", but all function >> declarations in the rwsem.h have the "extern" prefix. I think it would be >> better to keep it consistent. > >They are pointless and should never be added. OK I will remove it in v2. Thanks!