From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76185D1F9DA for ; Tue, 15 Oct 2024 21:29:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7D6F6B007B; Tue, 15 Oct 2024 17:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D306B0082; Tue, 15 Oct 2024 17:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF54C6B0083; Tue, 15 Oct 2024 17:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ADB286B007B for ; Tue, 15 Oct 2024 17:28:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F01CE140985 for ; Tue, 15 Oct 2024 21:28:49 +0000 (UTC) X-FDA: 82677126672.02.5E64303 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf22.hostedemail.com (Postfix) with ESMTP id 78EBEC0013 for ; Tue, 15 Oct 2024 21:28:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gd+8YuJF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729027579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yFN2KyKz+Qvd5YWT2+ySTUc44xG65CKU+dbLtbidzN4=; b=W/FzjMrqQpGof8sbRPOWvDW2szbKW7tWtpJUqlLiF9/wiiL4bvF8ujvd9ln6xW1Ir0OvxQ VuC7/tmD0K5pnViNS/xFXvX5qOHqG7tnIiMXSj/5wsxSwAHI/ufkbJRNRhFiB62ACJkOBA OR/jjx2hUoRbNSJAFxu+dObg0YwzPXE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729027579; a=rsa-sha256; cv=none; b=BT9+8K9p/VxsFTuSD57DvCRH+Ev7l0RiWh4hTlXnzMu9cQddtTOssyo5+pEbhnTxH3QywX aLlU132G0M5DW2pmEt21pjN5C7lTH4Gm/gKGgY7qnOkuwJ6CJpkQpa6zZb6lRzpEX3mB6z luBswH3nM+/DKT5URijVdlpE10OcB6k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gd+8YuJF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729027736; x=1760563736; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xPCIn32QQfr54O0zHazFhSN5jue+7V076iFkE2q84Ik=; b=gd+8YuJFO+l7wpMD0fmqdoad4kJ0NUGFZvuctz8FpMElgnJXbMCJR02h y58JIEHlxvaj5RiySzxGbon84fjJxYLHdITbneX2Ht1CS+Ckokmr02VdD 3lCSH7MIi047Gy/POZqWoTgu5CNAmW4ZMczxcjJ3HdxgiomAq6zvb/vtw vSml6M6XkvxYzNl2Yaj7hLa4oTN5BTN6qJYkjCkBTgbtVJnO6rq4ZX04b td5ni2gKALoDGGRYDBvN+NlV5GAqo57zOQ/8bG79F5qdwtpXIRNn5uw8b SEjoUxmqEanVBzQjbtqYr9/uJwSfLJKWu4+9zjw0q1XSFYLJPc7kp2YsR g==; X-CSE-ConnectionGUID: EaD+iibAQZaHVDjaey+Tnw== X-CSE-MsgGUID: gPwfyXcOROWXZ/eaOPaT8w== X-IronPort-AV: E=McAfee;i="6700,10204,11225"; a="27891397" X-IronPort-AV: E=Sophos;i="6.11,206,1725346800"; d="scan'208";a="27891397" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 14:28:54 -0700 X-CSE-ConnectionGUID: 9ed/BWG1Q563Zf26f963sw== X-CSE-MsgGUID: GLmnR+SHT5mHPhynDws5YQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,206,1725346800"; d="scan'208";a="78861952" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 15 Oct 2024 14:28:52 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t0p61-000Jx7-0T; Tue, 15 Oct 2024 21:28:49 +0000 Date: Wed, 16 Oct 2024 05:27:52 +0800 From: kernel test robot To: Markus Elfring , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, Andrew Morton , Herbert Xu , Peter Zijlstra Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , LKML Subject: Re: [PATCH v3 2/3] lib/digsig: Use scope-based resource management for two MPI variables in digsig_verify_rsa() Message-ID: <202410160438.SOIZeFku-lkp@intel.com> References: <300a0376-f003-4862-bb16-7e004733c9c1@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <300a0376-f003-4862-bb16-7e004733c9c1@web.de> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78EBEC0013 X-Stat-Signature: qdcga4nx3fxzjf7p6zj1t6etfugbw9ue X-Rspam-User: X-HE-Tag: 1729027726-718324 X-HE-Meta: U2FsdGVkX1+UZw4jTaZfgha/TZiphOG1QPmBPyw0vhlAQkAL5r2bX2up6aEWgVHb1ebfHTceF/89PiwbpYN8tlGGxKcmbuPj/8ejPZt6vCfXhNeWC/vKFa8Ur8o89GOjGQZcxHB4akpZIkOeTdYWvSqlbAOKnUt1ouJ8DmPhMo4wOa04ZF1P7bW9lbNWOaAQI5L2VX34xolVEoVdX7rDwiQyLBBrncrkRe7D+9uF0HH8yQCUl5uofW/7sFeOh1qKq6OfQjlNep7WTpO+mpMNWRss/vdMfUHPdeSGDmIPtr3sVqSHCxZuwxBlxhGBm92vHqcaj/eivVDEJGaAnV1TMYFsNnT1SixjuZ54F6Xo0Y+lKZldzG5Ulq6yaM/bHuzIGrYRZt+DF9Ao1sJzDLkTLsnf1cNSbJPQXTpytk3dTFoiSIGy/MxjXFLM5CwiRfQe+c10tOVWG/f7hfhaORwOlSVbB2r3qy4xgPaAeI/WBbzfj2PXvV5b30K7Op53kBmE0BDoIc+UyLJP9A4y4ac0dlEjrQmfe5qir02n2G3EmHeUZ4ErYGbx0N5oFTm/2CQvEJWzrXFnFyxg9UFWN/UXrL2z2c9FTWyU7JXG00T9RBKm4HNvZ3TDpsYckgziofWTW8K8gEl9gFRACeHSQuhUXMFAA1XGPvp3DeJaxL/hCqlOnlxQLS3n3D3Ow62X3O3C7I9ip2VRDjqPIM2oWXrQ1kKEHjRhjF208XqOydIruk/l+DYjqPoAdFtAZCQpeDBf9/FLhasQEaVLj/zBTQxG68y2Gm2CWv4r9010vA6nUQkYV5jG4pt0GnYLWwgc12gCMAaEM/221yI4ye3jMCE3y+vq7NMW2cSilkYSjZMOrgzSlsTGetYtZ5MWxpUXfCen4gJ0CK7vO356qwx0jv1qrroglsABUyN9HZrAW/OKZ/s0hivpvRHV4Suqt2j3kvlyobyOZ1j/N1oHWnPjvC8 5v4UrOBg A894FiN0YAavXm0Y6wonz0Bn405O/yp4FTVyUYjJJhqtMk2PC4Z1WPGWs9YGW3fbAYgG+D/BZAafZgC2RFUTgqqisYaktYjJJ3eEvNamoZ6aJ79XJD0GWVNUwy5BfnkFd4OpcT4/ganS1nFfpinUA98as6edxlxJDl2s/i2//jpBAqo7rVafYC5VZm+DjNBw5OwsETeha7kjQpWupRZLhvfvfP1bRmsEGBzFxNzo6CKQ202Y4T1DWHCRIpk6Xkt/Vf4ltk6De2ph1CdWH7ii6TQtFSDgFE4147sgotQZB5e0NipTjtlo9c9KS53Qx1uMQVnb+K7L61h7W4Y5ihKs5+mK3E7STIjwyI7jn0hFts+OP9HGNRh1ErcQ4f6hqcbGeo2Mbwqhjl0/7EPnjczPiENFD2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Markus, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-nonmm-unstable] [also build test WARNING on herbert-crypto-2.6/master herbert-cryptodev-2.6/master linus/master v6.12-rc3 next-20241015] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/crypto-lib-mpi-Extend-support-for-scope-based-resource-management/20241012-231156 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/300a0376-f003-4862-bb16-7e004733c9c1%40web.de patch subject: [PATCH v3 2/3] lib/digsig: Use scope-based resource management for two MPI variables in digsig_verify_rsa() config: arm-randconfig-002-20241016 (https://download.01.org/0day-ci/archive/20241016/202410160438.SOIZeFku-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 70e0a7e7e6a8541bcc46908c592eed561850e416) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410160438.SOIZeFku-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410160438.SOIZeFku-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from lib/digsig.c:25: In file included from include/linux/mpi.h:21: In file included from include/linux/scatterlist.h:8: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> lib/digsig.c:176:3: warning: label at end of compound statement is a C23 extension [-Wc23-extensions] 176 | } | ^ lib/digsig.c:178:2: warning: label at end of compound statement is a C23 extension [-Wc23-extensions] 178 | } | ^ 3 warnings generated. vim +176 lib/digsig.c 16 17 #include 18 #include 19 #include 20 #include 21 #include 22 #include 23 #include 24 #include > 25 #include 26 #include 27 28 static struct crypto_shash *shash; 29 30 static const char *pkcs_1_v1_5_decode_emsa(const unsigned char *msg, 31 unsigned long msglen, 32 unsigned long modulus_bitlen, 33 unsigned long *outlen) 34 { 35 unsigned long modulus_len, ps_len, i; 36 37 modulus_len = (modulus_bitlen >> 3) + (modulus_bitlen & 7 ? 1 : 0); 38 39 /* test message size */ 40 if ((msglen > modulus_len) || (modulus_len < 11)) 41 return NULL; 42 43 /* separate encoded message */ 44 if (msg[0] != 0x00 || msg[1] != 0x01) 45 return NULL; 46 47 for (i = 2; i < modulus_len - 1; i++) 48 if (msg[i] != 0xFF) 49 break; 50 51 /* separator check */ 52 if (msg[i] != 0) 53 /* There was no octet with hexadecimal value 0x00 54 to separate ps from m. */ 55 return NULL; 56 57 ps_len = i - 2; 58 59 *outlen = (msglen - (2 + ps_len + 1)); 60 61 return msg + 2 + ps_len + 1; 62 } 63 64 /* 65 * RSA Signature verification with public key 66 */ 67 static int digsig_verify_rsa(struct key *key, 68 const char *sig, int siglen, 69 const char *h, int hlen) 70 { 71 int err = -EINVAL; 72 unsigned long len; 73 unsigned long mlen, mblen; 74 unsigned int l; 75 int head, i; 76 unsigned char *out1 = NULL; 77 const char *m; 78 MPI pkey[2]; 79 uint8_t *p, *datap; 80 const uint8_t *endp; 81 const struct user_key_payload *ukp; 82 struct pubkey_hdr *pkh; 83 84 down_read(&key->sem); 85 ukp = user_key_payload_locked(key); 86 87 if (!ukp) { 88 /* key was revoked before we acquired its semaphore */ 89 err = -EKEYREVOKED; 90 goto err1; 91 } 92 93 if (ukp->datalen < sizeof(*pkh)) 94 goto err1; 95 96 pkh = (struct pubkey_hdr *)ukp->data; 97 98 if (pkh->version != 1) 99 goto err1; 100 101 if (pkh->algo != PUBKEY_ALGO_RSA) 102 goto err1; 103 104 if (pkh->nmpi != 2) 105 goto err1; 106 107 datap = pkh->mpi; 108 endp = ukp->data + ukp->datalen; 109 110 for (i = 0; i < pkh->nmpi; i++) { 111 unsigned int remaining = endp - datap; 112 pkey[i] = mpi_read_from_buffer(datap, &remaining); 113 if (IS_ERR(pkey[i])) { 114 err = PTR_ERR(pkey[i]); 115 goto free_keys; 116 } 117 datap += remaining; 118 } 119 120 mblen = mpi_get_nbits(pkey[0]); 121 mlen = DIV_ROUND_UP(mblen, 8); 122 123 if (mlen == 0) { 124 err = -EINVAL; 125 goto free_keys; 126 } 127 128 err = -ENOMEM; 129 130 out1 = kzalloc(mlen, GFP_KERNEL); 131 if (!out1) 132 goto free_keys; 133 134 { 135 unsigned int nret = siglen; 136 MPI in __free(mpi_free) = mpi_read_from_buffer(sig, &nret); 137 138 if (IS_ERR(in)) { 139 err = PTR_ERR(in); 140 goto in_exit; 141 } 142 143 { 144 MPI res __free(mpi_free) = mpi_alloc(mpi_get_nlimbs(in) * 2); 145 146 if (!res) 147 goto res_exit; 148 149 err = mpi_powm(res, in, pkey[1], pkey[0]); 150 if (err) 151 goto res_exit; 152 153 if (mpi_get_nlimbs(res) * BYTES_PER_MPI_LIMB > mlen) { 154 err = -EINVAL; 155 goto res_exit; 156 } 157 158 p = mpi_get_buffer(res, &l, NULL); 159 if (!p) { 160 err = -EINVAL; 161 goto res_exit; 162 } 163 164 len = mlen; 165 head = len - l; 166 memset(out1, 0, head); 167 memcpy(out1 + head, p, l); 168 169 kfree(p); 170 171 m = pkcs_1_v1_5_decode_emsa(out1, len, mblen, &len); 172 173 if (!m || len != hlen || memcmp(m, h, hlen)) 174 err = -EINVAL; 175 res_exit: > 176 } 177 in_exit: 178 } 179 180 kfree(out1); 181 free_keys: 182 while (--i >= 0) 183 mpi_free(pkey[i]); 184 err1: 185 up_read(&key->sem); 186 187 return err; 188 } 189 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki